From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D09BECE58D for ; Wed, 9 Oct 2019 20:58:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18BEB218AC for ; Wed, 9 Oct 2019 20:58:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b+MkdQxg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731936AbfJIU6n (ORCPT ); Wed, 9 Oct 2019 16:58:43 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:27278 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731781AbfJIU6m (ORCPT ); Wed, 9 Oct 2019 16:58:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570654721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SXdPrh5SQBY2g5E44Kbwxu0eoL2g32/Mh7xHjPoo0bo=; b=b+MkdQxgCXYhaf2rMUnZAHqJRzXZvIRdOzD3b3+scqFmOtDYAJLkuQJc8LNG5jR8P7mj/T xbphmPiVKibSfZZkEgMnESKqIHNgmH9KRse0b3T529Y/ajhGhFXh1VcZAiYm9YDgzYYwd4 3TmuD4vCyVaXxAJddXEqM8E9YzFDN/k= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-xDXekkO7PBSylIjXzmqaEQ-1; Wed, 09 Oct 2019 16:58:40 -0400 Received: by mail-wm1-f70.google.com with SMTP id o8so1595954wmc.2 for ; Wed, 09 Oct 2019 13:58:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MZCiTiFbtDiMRheTU38K9dij6O6J26jyHcq0IPo3YkI=; b=koiD6NVh7TqRtlOMQKGZA+WigmRKmGArrccY+67UidCIZvsYVUCCgR3EUGyQqJjiaI SCYO/h/3IkchqcKnH8g0q3aTCj+NsIaY52PLuzcj5kNbwIIXRdzmf7XpljFMQb2xbV5y Dd+/axV9SHOaZnlqsIW3m9WzVMJc9Pps0wXCfyTUqZ+pp428nME1+7oKUtmssEl3zXeQ V4EBGD4/TLZ2jSxrjblu5ndegifiQgA2JDyW7A5ANTGNdByzTia3tmrBFq0+qjFs0A3V jnP6QDjqU/4HSG3eeQMZshid3xu2sBqBW58H0KfF7U/PU1GUzmoCc7tl74PDy0YeGcFv hh6Q== X-Gm-Message-State: APjAAAUK+b2zoO6iUE1nu8AWVGP1FM14+UuUsmpKF9q5/ftDDZtBmK3o PYLB0gJPraHuIOuVj0813hEd6whKX4VKTOnm2tozO3ugF+2ng15FwaPik1ieovIaIc5STZGJiMq EcdI7qbwl9hd0ukSr X-Received: by 2002:a5d:544a:: with SMTP id w10mr2258715wrv.271.1570654718001; Wed, 09 Oct 2019 13:58:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqxX7JfRvkV9uOOZ0iYaYnAdc1Oax5CH0j4BaeLo2KW73O0Nr1ynOw/1ZdsltoZnfUbPMApWTw== X-Received: by 2002:a5d:544a:: with SMTP id w10mr2258693wrv.271.1570654717701; Wed, 09 Oct 2019 13:58:37 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:1032:7ea1:7f8f:1e5? ([2001:b07:6468:f312:1032:7ea1:7f8f:1e5]) by smtp.gmail.com with ESMTPSA id o9sm5463455wrh.46.2019.10.09.13.58.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Oct 2019 13:58:37 -0700 (PDT) Subject: Re: [PATCH AUTOSEL 4.19 08/26] kvm: x86: Improve emulation of CPUID leaves 0BH and 1FH To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jim Mattson , Marc Orr , Peter Shier , Jacob Xu , Sean Christopherson , kvm@vger.kernel.org References: <20191009170558.32517-1-sashal@kernel.org> <20191009170558.32517-8-sashal@kernel.org> From: Paolo Bonzini Message-ID: <5fcb0e38-3542-dd39-6a1c-449b4f9f435e@redhat.com> Date: Wed, 9 Oct 2019 22:58:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191009170558.32517-8-sashal@kernel.org> Content-Language: en-US X-MC-Unique: xDXekkO7PBSylIjXzmqaEQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 09/10/19 19:05, Sasha Levin wrote: > From: Jim Mattson >=20 > [ Upstream commit 43561123ab3759eb6ff47693aec1a307af0aef83 ] >=20 > For these CPUID leaves, the EDX output is not dependent on the ECX > input (i.e. the SIGNIFCANT_INDEX flag doesn't apply to > EDX). Furthermore, the low byte of the ECX output is always identical > to the low byte of the ECX input. KVM does not produce the correct ECX > and EDX outputs for any undefined subleaves beyond the first. >=20 > Special-case these CPUID leaves in kvm_cpuid, so that the ECX and EDX > outputs are properly generated for all undefined subleaves. >=20 > Fixes: 0771671749b59a ("KVM: Enhance guest cpuid management") > Fixes: a87f2d3a6eadab ("KVM: x86: Add Intel CPUID.1F cpuid emulation supp= ort") > Signed-off-by: Jim Mattson > Reviewed-by: Marc Orr > Reviewed-by: Peter Shier > Reviewed-by: Jacob Xu > Cc: Sean Christopherson > Cc: Paolo Bonzini > Signed-off-by: Paolo Bonzini > Signed-off-by: Sasha Levin > --- > arch/x86/kvm/cpuid.c | 83 +++++++++++++++++++++++++------------------- > 1 file changed, 47 insertions(+), 36 deletions(-) This is absolutely not stable material. Is it possible for KVM to opt out of this AUTOSEL nonsense? Paolo