From: John Donnelly <john.p.donnelly@oracle.com>
To: Sasha Levin <sashal@kernel.org>
Cc: Mike Snitzer <snitzer@redhat.com>,
stable@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache
Date: Mon, 27 Jul 2020 15:38:38 -0500 [thread overview]
Message-ID: <6F764B9B-DEE6-4060-9F11-050D2F0999ED@oracle.com> (raw)
In-Reply-To: <20200727201700.GJ406581@sasha-vm>
> On Jul 27, 2020, at 3:17 PM, Sasha Levin <sashal@kernel.org> wrote:
>
> On Mon, Jul 27, 2020 at 02:38:52PM -0500, John Donnelly wrote:
>>
>>
>>> On Jul 27, 2020, at 2:18 PM, Sasha Levin <sashal@kernel.org> wrote:
>>>
>>> On Mon, Jul 27, 2020 at 11:00:14AM -0400, Mike Snitzer wrote:
>>>> This mail needs to be saent to stable@vger.kernel.org (now cc'd).
>>>>
>>>> Greg et al: please backport 2df3bae9a6543e90042291707b8db0cbfbae9ee9
>>>
>>> Hm, what's the issue that this patch addresses? It's not clear from the
>>> commit message.
>>>
>>> --
>>> Thanks,
>>> Sasha
>>
>> HI Sasha ,
>>
>> In an off-line conversation I had with Mike , he indicated that :
>>
>>
>> commit 1b17159e52bb31f982f82a6278acd7fab1d3f67b
>> Author: Mike Snitzer <snitzer@redhat.com>
>> Date: Fri Feb 28 18:00:53 2020 -0500
>>
>> dm bio record: save/restore bi_end_io and bi_integrity
>>
>>
>> commit 248aa2645aa7fc9175d1107c2593cc90d4af5a4e
>> Author: Mike Snitzer <snitzer@redhat.com>
>> Date: Fri Feb 28 18:11:53 2020 -0500
>>
>> dm integrity: use dm_bio_record and dm_bio_restore
>>
>>
>> Were picked up in "stable" kernels picked up even though
>> neither was marked for stable@vger.kernel.org
>>
>> Adding this missing commit :
>>
>> 2df3bae9a6543e90042291707b8db0cbfbae9ee9
>>
>>
>> Completes the series
>
> Should we just revert those two commits instead if they're not needed?
>
> --
> Thanks,
> Sasha
As I stated above:
> Fixes: 705559706d62038b74c5088114c1799cf2c9dce8 (dm bio record:
> save/restore bi_end_io and bi_integrity, version 4.14.188)
>
> 70555970 introduced a mkfs.ext4 hang on a LVM device that has been
> modified with lvconvert --cachemode=writethrough.
It corrects an issue we discovered in 4.14.188 . Any other branches those two commits have migrated to will likely have the same regression.
I am confident linux-4.14.y will be better off with it ;-)
next prev parent reply other threads:[~2020-07-27 20:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <37c5a615-655d-c106-afd0-54e03f3c0eef@oracle.com>
2020-07-27 15:00 ` (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache Mike Snitzer
2020-07-27 19:18 ` Sasha Levin
2020-07-27 19:38 ` John Donnelly
2020-07-27 20:17 ` Sasha Levin
2020-07-27 20:30 ` Mike Snitzer
2020-07-27 20:38 ` John Donnelly [this message]
2020-07-29 11:51 ` Greg KH
2020-07-29 11:55 ` Greg KH
2020-07-29 14:16 ` Mike Snitzer
2020-07-29 23:45 ` John Donnelly
2020-07-30 5:21 ` Greg KH
2020-07-30 14:40 ` John Donnelly
2020-07-31 6:36 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6F764B9B-DEE6-4060-9F11-050D2F0999ED@oracle.com \
--to=john.p.donnelly@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=snitzer@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).