From: David Laight <David.Laight@ACULAB.COM>
To: David Laight <David.Laight@ACULAB.COM>,
'Dan Williams' <dan.j.williams@intel.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "X86 ML" <x86@kernel.org>,
stable <stable@vger.kernel.org>, Borislav Petkov <bp@alien8.de>,
Tony Luck <tony.luck@intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: RE: [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
Date: Wed, 20 May 2020 15:34:50 +0000 [thread overview]
Message-ID: <6a7200e6c57843eb8c6c08db9f991064@AcuMS.aculab.com> (raw)
In-Reply-To: <380699aca2424f5ab1fb55c220350908@AcuMS.aculab.com>
> From: Dan Williams
> > Sent: 20 May 2020 16:26
> ...
> > > > +#ifdef CONFIG_ARCH_HAS_COPY_MC
> > > > +extern unsigned long __must_check
> > >
> > > We try not to add extern in headers anymore.
> >
> > Ok, I was doing the copy-pasta dance, but I'll remove this.
>
> It is data not code, it needs the extern to not be 'common'.
> OTOH what is a global variable being used for?
Aaarg not enough context...
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-05-20 15:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 22:12 [PATCH v3 0/2] Renovate memcpy_mcsafe with copy_mc_to_{user, kernel} Dan Williams
2020-05-19 22:12 ` [PATCH v3 1/2] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}() Dan Williams
2020-05-20 4:37 ` kbuild test robot
2020-05-20 9:53 ` Michael Ellerman
2020-05-20 15:25 ` Dan Williams
2020-05-20 15:33 ` David Laight
2020-05-20 15:34 ` David Laight [this message]
2020-05-22 0:12 ` Sasha Levin
2020-05-19 22:12 ` [PATCH v3 2/2] x86/copy_mc: Introduce copy_mc_generic() Dan Williams
2020-05-20 19:13 ` Vivek Goyal
2020-05-20 21:57 ` Dan Williams
2020-05-22 0:12 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a7200e6c57843eb8c6c08db9f991064@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=acme@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mingo@redhat.com \
--cc=mpatocka@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).