stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Naresh Kamboju <naresh.kamboju@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Marc Zyngier <maz@kernel.org>
Cc: open list <linux-kernel@vger.kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	patches@kernelci.org, lkft-triage@lists.linaro.org,
	Ben Hutchings <ben.hutchings@codethink.co.uk>,
	linux- stable <stable@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	w@1wt.eu, Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH 5.7 0/6] 5.7.14-rc1 review
Date: Wed, 5 Aug 2020 11:24:22 -0700	[thread overview]
Message-ID: <71a132bf-5ddb-a97a-9b65-6767fd806ee9@roeck-us.net> (raw)
In-Reply-To: <CA+G9fYv_aX36Kq_RD5dAL_By4AFq=-ZY_qh7VhLG=HJQv5mDzg@mail.gmail.com>

On 8/5/20 10:39 AM, Naresh Kamboju wrote:
> On Wed, 5 Aug 2020 at 21:22, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
>>
>> This is the start of the stable review cycle for the 5.7.14 release.
>> There are 6 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Fri, 07 Aug 2020 15:34:53 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>         https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.7.14-rc1.gz
>> or in the git tree and branch at:
>>         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.7.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>>
>> -------------
>> Pseudo-Shortlog of commits:
>>
>> Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>     Linux 5.7.14-rc1
>>
>> Marc Zyngier <maz@kernel.org>
>>     arm64: Workaround circular dependency in pointer_auth.h
>>
>> Linus Torvalds <torvalds@linux-foundation.org>
>>     random32: move the pseudo-random 32-bit definitions to prandom.h
>>
>> Linus Torvalds <torvalds@linux-foundation.org>
>>     random32: remove net_rand_state from the latent entropy gcc plugin
>>
>> Willy Tarreau <w@1wt.eu>
>>     random: fix circular include dependency on arm64 after addition of percpu.h
>>
>> Grygorii Strashko <grygorii.strashko@ti.com>
>>     ARM: percpu.h: fix build error
>>
>> Willy Tarreau <w@1wt.eu>
>>     random32: update the net random state on interrupt and activity
>>
> 
> [ sorry if it is not interesting ! ]
> 
> While building with old gcc-7.3.0 the build breaks for arm64
> whereas build PASS on gcc-8, gcc-9 and gcc-10.
> 
> with gcc 7.3.0 build breaks log,
> 
Same with older versions of gcc. I don't see the problem with the
mainline kernel.

I think this is caused by more recursive includes.
arch/arm64/include/asm/archrandom.h includes include/linux/random.h
which includes arch/arm64/include/asm/archrandom.h to get the definition
of arch_get_random_seed_long_early (which it won't get because of
the recursion).

What I don't really understand is how this works with new versions
of gcc.

Guenter

> In file included from arch/arm64/include/asm/archrandom.h:9:0,
>                  from arch/arm64/kernel/kaslr.c:14:
> include/linux/random.h: In function 'arch_get_random_seed_long_early':
> include/linux/random.h:149:9: error: implicit declaration of function
> 'arch_get_random_seed_long'; did you mean
> 'arch_get_random_seed_long_early'?
> [-Werror=implicit-function-declaration]
>   return arch_get_random_seed_long(v);
>          ^~~~~~~~~~~~~~~~~~~~~~~~~
>          arch_get_random_seed_long_early
> include/linux/random.h: In function 'arch_get_random_long_early':
> include/linux/random.h:157:9: error: implicit declaration of function
> 'arch_get_random_long'; did you mean 'get_random_long'?
> [-Werror=implicit-function-declaration]
>   return arch_get_random_long(v);
>          ^~~~~~~~~~~~~~~~~~~~
>          get_random_long
> In file included from arch/arm64/kernel/kaslr.c:14:0:
> arch/arm64/include/asm/archrandom.h: At top level:
> arch/arm64/include/asm/archrandom.h:30:33: error: conflicting types
> for 'arch_get_random_long'
>  static inline bool __must_check arch_get_random_long(unsigned long *v)
>                                  ^~~~~~~~~~~~~~~~~~~~
> In file included from arch/arm64/include/asm/archrandom.h:9:0,
>                  from arch/arm64/kernel/kaslr.c:14:
> include/linux/random.h:157:9: note: previous implicit declaration of
> 'arch_get_random_long' was here
>   return arch_get_random_long(v);
>          ^~~~~~~~~~~~~~~~~~~~
> In file included from arch/arm64/kernel/kaslr.c:14:0:
> arch/arm64/include/asm/archrandom.h:40:33: error: conflicting types
> for 'arch_get_random_seed_long'
>  static inline bool __must_check arch_get_random_seed_long(unsigned long *v)
>                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from arch/arm64/include/asm/archrandom.h:9:0,
>                  from arch/arm64/kernel/kaslr.c:14:
> include/linux/random.h:149:9: note: previous implicit declaration of
> 'arch_get_random_seed_long' was here
>   return arch_get_random_seed_long(v);
>          ^~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from arch/arm64/kernel/kaslr.c:14:0:
> arch/arm64/include/asm/archrandom.h:72:1: error: redefinition of
> 'arch_get_random_seed_long_early'
>  arch_get_random_seed_long_early(unsigned long *v)
>  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> In file included from arch/arm64/include/asm/archrandom.h:9:0,
>                  from arch/arm64/kernel/kaslr.c:14:
> include/linux/random.h:146:27: note: previous definition of
> 'arch_get_random_seed_long_early' was here
>  static inline bool __init arch_get_random_seed_long_early(unsigned long *v)
> 
> 


  parent reply	other threads:[~2020-08-05 19:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-05 15:52 [PATCH 5.7 0/6] 5.7.14-rc1 review Greg Kroah-Hartman
2020-08-05 15:52 ` [PATCH 5.7 1/6] random32: update the net random state on interrupt and activity Greg Kroah-Hartman
2020-08-05 15:52 ` [PATCH 5.7 2/6] ARM: percpu.h: fix build error Greg Kroah-Hartman
2020-08-05 15:52 ` [PATCH 5.7 3/6] random: fix circular include dependency on arm64 after addition of percpu.h Greg Kroah-Hartman
2020-08-05 15:52 ` [PATCH 5.7 4/6] random32: remove net_rand_state from the latent entropy gcc plugin Greg Kroah-Hartman
2020-08-05 15:52 ` [PATCH 5.7 5/6] random32: move the pseudo-random 32-bit definitions to prandom.h Greg Kroah-Hartman
2020-08-05 15:52 ` [PATCH 5.7 6/6] [PATCH] arm64: Workaround circular dependency in pointer_auth.h Greg Kroah-Hartman
2020-08-05 17:39 ` [PATCH 5.7 0/6] 5.7.14-rc1 review Naresh Kamboju
2020-08-05 18:01   ` Linus Torvalds
2020-08-05 18:27     ` Guenter Roeck
2020-08-05 18:24   ` Guenter Roeck [this message]
2020-08-05 18:37     ` Linus Torvalds
2020-08-05 19:24       ` Guenter Roeck
2020-08-05 19:45         ` Linus Torvalds
2020-08-05 19:58           ` Greg Kroah-Hartman
2020-08-06  0:09           ` Guenter Roeck
2020-08-05 19:26       ` Daniel Díaz
2020-08-05 19:52 ` Jon Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71a132bf-5ddb-a97a-9b65-6767fd806ee9@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=akpm@linux-foundation.org \
    --cc=ben.hutchings@codethink.co.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=maz@kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=patches@kernelci.org \
    --cc=shuah@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=w@1wt.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).