From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E08C433EF for ; Tue, 7 Dec 2021 15:09:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbhLGPNV (ORCPT ); Tue, 7 Dec 2021 10:13:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51281 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238637AbhLGPNO (ORCPT ); Tue, 7 Dec 2021 10:13:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1638889783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R245khe8xk07RNyH0EVz6ZGFqepWH2fvgXb9UQjIJSY=; b=aEerPpXc0Wv1tOiW3de5FGltYLqZq/Uq574h9Cq/jMZBZXvoCBjHNtIUJj0xKhLfpay3zS WS5nU6ybDirhYzD5OU+q1WL1wrHqA8ruuT1ShGr9S9iBOlV96uY0ovyT4LOf2PNP8ddrdx AfYx3SrkKl8xBbCl1XK7HLVh4/lJao0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-58-PU5D9SRMOhCvFmfzBHcKCA-1; Tue, 07 Dec 2021 10:09:42 -0500 X-MC-Unique: PU5D9SRMOhCvFmfzBHcKCA-1 Received: by mail-wm1-f69.google.com with SMTP id n41-20020a05600c502900b003335ab97f41so1499707wmr.3 for ; Tue, 07 Dec 2021 07:09:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=R245khe8xk07RNyH0EVz6ZGFqepWH2fvgXb9UQjIJSY=; b=s2xJFJP7LMEnQkq1WUcz7V/8ZW8ZL/okWKUAaTFU4KRHa3QJcEoCbL1JeLIL4j0oOS U+lMGra21uflXRqrSt9vqvShQTgMtXofj7PeO0lckumGAfjJWRTn+kYdI/CAKozZEKzi +oZOnlIsVxCGFF7wJiYS2QdfU5hovljfC1Hz8/rcQovmQShj3c5InBOjvH8BcgHC6IQA nqC7UVXZp2OnzmZJ7Px8TEuSxzrOy1lWw/qX934dWSx4Qr5C4fM43OYhHW8VggtyFW7k Z3vlFovyyMvGTIY2YI5a4Txn5s4xvOZgO7DTehX7MoQQj4AuyHWS812YMY14j767A5nP MbGQ== X-Gm-Message-State: AOAM530HEvVqr7ZtwuNzpChlJOFZ0mECKTSVVd4d7GBet1gg4IKijF5d 0+UE/VWxi8KK/qssUfuGQ6tdwPbzgjnaKB+J/41J8ZGiW0Vv4LQC21UL1h1vfLHQe9vMi+11meg 2U5Hzr21e2bfi7hSR X-Received: by 2002:adf:df0b:: with SMTP id y11mr50895478wrl.181.1638889781562; Tue, 07 Dec 2021 07:09:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXXWyseqL9/W2Gvac7QFnbIgZaUx6fF5pn8ANZ1qKu/BbVDPYxGE2dYV1lAqjltt8gZjUXuw== X-Received: by 2002:adf:df0b:: with SMTP id y11mr50895445wrl.181.1638889781333; Tue, 07 Dec 2021 07:09:41 -0800 (PST) Received: from [192.168.3.132] (p4ff23e57.dip0.t-ipconnect.de. [79.242.62.87]) by smtp.gmail.com with ESMTPSA id m17sm14723297wrz.22.2021.12.07.07.09.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 07:09:40 -0800 (PST) Message-ID: <77e785e6-cf34-0cff-26a5-852d3786a9b8@redhat.com> Date: Tue, 7 Dec 2021 16:09:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v3] mm: fix panic in __alloc_pages Content-Language: en-US To: Michal Hocko Cc: Alexey Makhalov , Dennis Zhou , Eric Dumazet , "linux-mm@kvack.org" , Andrew Morton , Oscar Salvador , Tejun Heo , Christoph Lameter , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" References: <5239D699-523C-4F0C-923A-B068E476043E@vmware.com> <1043a1a4-b7f2-8730-d192-7cab9f15ee24@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 07.12.21 14:23, Michal Hocko wrote: > On Tue 07-12-21 13:28:31, David Hildenbrand wrote: > [...] >> But maybe I am missing something important regarding online vs. offline >> nodes that your patch changes? > > I am relying on alloc_node_data setting the node online. But if we are > to change the call to arch_alloc_node_data then the patch needs to be > more involved. Here is what I have right now. If this happens to be the > right way then there is some additional work to sync up with the hotplug > code. > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index c5952749ad40..a296e934ad2f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -8032,8 +8032,23 @@ void __init free_area_init(unsigned long *max_zone_pfn) > /* Initialise every node */ > mminit_verify_pageflags_layout(); > setup_nr_node_ids(); > - for_each_online_node(nid) { > - pg_data_t *pgdat = NODE_DATA(nid); > + for_each_node(nid) { > + pg_data_t *pgdat; > + > + if (!node_online(nid)) { > + pr_warn("Node %d uninitialized by the platform. Please report with memory map.\n", nid); > + pgdat = arch_alloc_nodedata(nid); > + pgdat->per_cpu_nodestats = alloc_percpu(struct per_cpu_nodestat); > + arch_refresh_nodedata(nid, pgdat); > + node_set_online(nid); Setting all possible nodes online might result in quite some QE noice, because all these nodes will then be visible in the sysfs and try_offline_nodes() is essentially for the trash. I agree to prealloc the pgdat, I don't think we should actually set the nodes online. Node onlining/offlining should be done when we do have actual CPUs/memory populated. -- Thanks, David / dhildenb