From: Aditya Garg <gargaditya08@live.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Thorsten Leemhuis <regressions@leemhuis.info>,
Orlando Chamberlain <redecorating@protonmail.com>,
Daniel Winkler <danielwinkler@google.com>,
Johan Hedberg <johan.hedberg@intel.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"regressions@lists.linux.dev" <regressions@lists.linux.dev>,
"sonnysasaka@chromium.org" <sonnysasaka@chromium.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: [PATCH v7 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip
Date: Tue, 30 Nov 2021 11:40:09 +0000 [thread overview]
Message-ID: <83D9E5B4-980D-4F1C-B1B8-78E9E7E1095A@live.com> (raw)
In-Reply-To: <A6DD9616-E669-4382-95A0-B9DBAF46712D@live.com>
From: Aditya Garg <gargaditya08@live.com>
Some Macs with the T2 security chip had Bluetooth not working.
To fix it we add DMI based quirks to disable querying of LE Tx power.
Signed-off-by: Aditya Garg <gargaditya08@live.com>
Reported-by: Orlando Chamberlain <redecorating@protonmail.com>
Tested-by: Orlando Chamberlain <redecorating@protonmail.com>
Link:
https://lore.kernel.org/r/4970a940-211b-25d6-edab-21a815313954@protonmail.com
Fixes: 7c395ea521e6 ("Bluetooth: Query LE tx power on startup")
---
v7 :- Removed unused variable and added Tested-by.
drivers/bluetooth/btbcm.c | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index e4182acee488c5..07fabaa5aa2979 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -8,6 +8,7 @@
#include <linux/module.h>
#include <linux/firmware.h>
+#include <linux/dmi.h>
#include <asm/unaligned.h>
#include <net/bluetooth/bluetooth.h>
@@ -343,6 +344,40 @@ static struct sk_buff *btbcm_read_usb_product(struct hci_dev *hdev)
return skb;
}
+static const struct dmi_system_id disable_broken_read_transmit_power[] = {
+ {
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Apple Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro16,1"),
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Apple Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro16,2"),
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Apple Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro16,4"),
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Apple Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "iMac20,1"),
+ },
+ },
+ {
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Apple Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "iMac20,2"),
+ },
+ },
+ { }
+};
+
static int btbcm_read_info(struct hci_dev *hdev)
{
struct sk_buff *skb;
@@ -363,6 +398,10 @@ static int btbcm_read_info(struct hci_dev *hdev)
bt_dev_info(hdev, "BCM: features 0x%2.2x", skb->data[1]);
kfree_skb(skb);
+ /* Read DMI and disable broken Read LE Min/Max Tx Power */
+ if (dmi_first_match(disable_broken_read_transmit_power))
+ set_bit(HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER, &hdev->quirks);
+
return 0;
}
next prev parent reply other threads:[~2021-11-30 11:40 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20211001083412.3078-1-redecorating@protonmail.com>
[not found] ` <YYePw07y2DzEPSBR@kroah.com>
[not found] ` <70a875d0-7162-d149-dbc1-c2f5e1a8e701@leemhuis.info>
[not found] ` <20211116090128.17546-1-redecorating@protonmail.com>
[not found] ` <e75bf933-9b93-89d2-d73f-f85af65093c8@leemhuis.info>
[not found] ` <3B8E16FA-97BF-40E5-9149-BBC3E2A245FE@live.com>
[not found] ` <YZSuWHB6YCtGclLs@kroah.com>
[not found] ` <52DEDC31-EEB2-4F39-905F-D5E3F2BBD6C0@live.com>
[not found] ` <8919a36b-e485-500a-2722-529ffa0d2598@leemhuis.info>
[not found] ` <20211117124717.12352-1-redecorating@protonmail.com>
[not found] ` <F8D12EA8-4B37-4887-998E-DC0EBE60E730@holtmann.org>
[not found] ` <40550C00-4EE5-480F-AFD4-A2ACA01F9DBB@live.com>
[not found] ` <332a19f1-30f0-7058-ac18-c21cf78759bb@leemhuis.info>
[not found] ` <D9375D91-1062-4265-9DE9-C7CF2B705F3F@live.com>
2021-11-29 7:22 ` [PATCH 1/6] Bluetooth: add quirk disabling LE Read Transmit Power Aditya Garg
2021-11-29 7:27 ` [PATCH 2/6] btbcm: disable read tx power for MacBook Pro 16,1 (16 inch, 2019) Aditya Garg
2021-11-29 7:28 ` [PATCH 3/6] btbcm: disable read tx power for MacBook Pro 16,2 (13 inch - 4 Thunderbolt Ports, 2020) Aditya Garg
2021-11-29 7:30 ` [PATCH 4/6] btbcm: disable read tx power for MacBook Pro 16,4 (16 inch, 2019) Aditya Garg
2021-11-29 7:31 ` [PATCH 5/6] btbcm: disable read tx power for iMac 20,1 (Retina 5K, 27-inch, 2020) Aditya Garg
2021-11-29 7:32 ` [PATCH 6/6] btbcm: disable read tx power for iMac 20,2 " Aditya Garg
2021-11-29 7:46 ` [PATCH v2 4/6] btbcm: disable read tx power for MacBook Pro 16,4 (16 inch, 2019) Aditya Garg
2021-11-29 7:45 ` [PATCH v2 3/6] btbcm: disable read tx power for MacBook Pro 16,2 (13 inch - 4 Thunderbolt Ports, 2020) Aditya Garg
2021-11-29 7:44 ` [PATCH v2 2/6] btbcm: disable read tx power for MacBook Pro 16,1 (16 inch, 2019) Aditya Garg
2021-11-29 8:08 ` [PATCH " Marcel Holtmann
2021-11-29 8:11 ` Aditya Garg
2021-11-29 8:22 ` Marcel Holtmann
2021-11-29 8:42 ` Aditya Garg
2021-11-29 7:32 ` [PATCH 1/6] Bluetooth: add quirk disabling LE Read Transmit Power Greg KH
2021-11-29 7:42 ` [PATCH v2 " Aditya Garg
2021-11-29 7:47 ` Greg KH
2021-11-29 7:49 ` Aditya Garg
2021-11-29 7:47 ` Greg KH
2021-11-29 8:05 ` Marcel Holtmann
2021-11-29 8:32 ` [PATCH v3 1/2] " Aditya Garg
2021-11-29 8:35 ` [PATCH v3 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-11-29 8:50 ` [PATCH v3 resend " Aditya Garg
2021-11-29 9:05 ` [PATCH v4 " Aditya Garg
2021-11-29 9:25 ` [PATCH v5 " Aditya Garg
2021-11-29 11:03 ` [PATCH v3 resend " Marcel Holtmann
2021-11-29 12:01 ` Aditya Garg
2021-11-29 8:47 ` [PATCH v3 resend 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Aditya Garg
2021-11-29 9:03 ` [PATCH v4 " Aditya Garg
2021-11-29 9:24 ` [PATCH v5 " Aditya Garg
2021-11-29 13:59 ` [PATCH v6 " Aditya Garg
2021-11-29 14:00 ` [PATCH v6 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-11-30 8:45 ` Aditya Garg
2021-11-30 8:54 ` Greg KH
2021-11-30 10:28 ` Orlando Chamberlain
2021-11-30 11:38 ` [PATCH v7 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Aditya Garg
2021-11-30 11:40 ` Aditya Garg [this message]
2021-11-30 11:41 ` Greg KH
2021-11-30 11:50 ` Aditya Garg
2021-11-30 11:48 ` [PATCH v7 resend " Aditya Garg
2021-11-30 11:49 ` [PATCH v7 resend 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-11-30 12:03 ` [PATCH v7 resend 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Greg KH
2021-11-30 12:53 ` Aditya Garg
2021-11-30 12:53 ` [PATCH v8 " Aditya Garg
2021-11-30 12:54 ` [PATCH v8 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-12-01 7:25 ` [PATCH v8 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Marcel Holtmann
2021-12-02 10:15 ` [PATCH v9 " Aditya Garg
2021-12-02 10:16 ` [PATCH v9 2/2] btbcm: disable read tx power for affected Macs with the T2 Security chip Aditya Garg
2021-12-02 12:41 ` [PATCH v10 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Aditya Garg
2021-12-02 12:42 ` [PATCH v10 2/2] btbcm: disable read tx power for some Macs with the T2 Security chip Aditya Garg
2021-12-03 21:28 ` Marcel Holtmann
2021-12-21 13:44 ` Thorsten Leemhuis
2021-12-03 21:28 ` [PATCH v10 1/2] Bluetooth: add quirk disabling LE Read Transmit Power Marcel Holtmann
2021-11-29 8:52 ` [PATCH v3 " Thorsten Leemhuis
2021-11-29 11:02 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83D9E5B4-980D-4F1C-B1B8-78E9E7E1095A@live.com \
--to=gargaditya08@live.com \
--cc=danielwinkler@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=redecorating@protonmail.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=sonnysasaka@chromium.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).