From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Martin Faltesek <mfaltesek@google.com>, kuba@kernel.org
Cc: christophe.ricard@gmail.com, gregkh@linuxfoundation.org,
groeck@google.com, jordy@pwning.systems, krzk@kernel.org,
martin.faltesek@gmail.com, netdev@vger.kernel.org,
linux-nfc@lists.01.org, sameo@linux.intel.com, wklin@google.com,
theflamefire89@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH net v3 2/3] nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
Date: Tue, 7 Jun 2022 19:15:31 +0200 [thread overview]
Message-ID: <83fd531e-9135-37b5-e92a-76b6c949587e@linaro.org> (raw)
In-Reply-To: <20220607025729.1673212-3-mfaltesek@google.com>
On 07/06/2022 04:57, Martin Faltesek wrote:
> Error paths do not free previously allocated memory. Add devm_kfree() to
> those failure paths.
>
> Fixes: 26fc6c7f02cb ("NFC: st21nfca: Add HCI transaction event support")
> Fixes: 4fbcc1a4cb20 ("nfc: st21nfca: Fix potential buffer overflows in EVT_TRANSACTION")
> Cc: stable@vger.kernel.org
> Signed-off-by: Martin Faltesek <mfaltesek@google.com>
Standard disclaimer:
---------
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
If a tag was not added on purpose, please state why and what changed.
---------
So you dropped all my review tags?
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-06-07 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220607025729.1673212-1-mfaltesek@google.com>
2022-06-07 2:57 ` [PATCH net v3 1/3] nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION Martin Faltesek
2022-06-07 15:06 ` Guenter Roeck
2022-06-07 17:13 ` Krzysztof Kozlowski
2022-06-07 2:57 ` [PATCH net v3 2/3] nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling Martin Faltesek
2022-06-07 15:07 ` Guenter Roeck
2022-06-07 17:15 ` Krzysztof Kozlowski [this message]
2022-06-07 2:57 ` [PATCH net v3 3/3] nfc: st21nfca: fix incorrect sizing calculations in EVT_TRANSACTION Martin Faltesek
2022-06-07 15:09 ` Guenter Roeck
2022-06-08 7:09 ` Krzysztof Kozlowski
[not found] <20220607025519.1670876-1-mfaltesek@google.com>
2022-06-07 2:55 ` [PATCH net v3 2/3] nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling Martin Faltesek
[not found] <20220607024819.1667984-1-mfaltesek@google.com>
2022-06-07 2:48 ` Martin Faltesek
[not found] <20220607024117.1344044-1-mfaltesek@google.com>
2022-06-07 2:41 ` Martin Faltesek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fd531e-9135-37b5-e92a-76b6c949587e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=christophe.ricard@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@google.com \
--cc=jordy@pwning.systems \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=martin.faltesek@gmail.com \
--cc=mfaltesek@google.com \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=theflamefire89@gmail.com \
--cc=wklin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).