From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C29CAC433FE for ; Mon, 21 Mar 2022 08:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345192AbiCUIRe convert rfc822-to-8bit (ORCPT ); Mon, 21 Mar 2022 04:17:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345232AbiCUIRQ (ORCPT ); Mon, 21 Mar 2022 04:17:16 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F01761275A9 for ; Mon, 21 Mar 2022 01:15:30 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWDBd-0004Zy-AB; Mon, 21 Mar 2022 09:14:45 +0100 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nWDBW-0023Fj-7t; Mon, 21 Mar 2022 09:14:39 +0100 Received: from pza by lupine with local (Exim 4.94.2) (envelope-from ) id 1nWDBW-0001PK-AO; Mon, 21 Mar 2022 09:14:38 +0100 Message-ID: <84f2c72ced35506522ea3a6be72879d1699f885b.camel@pengutronix.de> Subject: Re: [PATCH 1/2] net: mdio: add reset deassertion for Aspeed MDIO From: Philipp Zabel To: Dylan Hung , robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au, andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: BMC-SW@aspeedtech.com, stable@vger.kernel.org Date: Mon, 21 Mar 2022 09:14:38 +0100 In-Reply-To: <20220321070131.23363-2-dylan_hung@aspeedtech.com> References: <20220321070131.23363-1-dylan_hung@aspeedtech.com> <20220321070131.23363-2-dylan_hung@aspeedtech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: stable@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Dylan, On Mo, 2022-03-21 at 15:01 +0800, Dylan Hung wrote: > Add reset deassertion for Aspeed MDIO.  There are 4 MDIO controllers > embedded in Aspeed AST2600 SOC and share one reset control register > SCU50[3]. So devm_reset_control_get_shared is used in this change. > > Signed-off-by: Dylan Hung > Cc: stable@vger.kernel.org > --- >  drivers/net/mdio/mdio-aspeed.c | 8 ++++++++ >  1 file changed, 8 insertions(+) > > diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio- > aspeed.c > index e2273588c75b..8ac262a12d13 100644 > --- a/drivers/net/mdio/mdio-aspeed.c > +++ b/drivers/net/mdio/mdio-aspeed.c > @@ -3,6 +3,7 @@ >   >  #include >  #include > +#include >  #include >  #include >  #include > @@ -37,6 +38,7 @@ >   >  struct aspeed_mdio { >         void __iomem *base; > +       struct reset_control *reset; >  }; >   >  static int aspeed_mdio_read(struct mii_bus *bus, int addr, int > regnum) > @@ -120,6 +122,12 @@ static int aspeed_mdio_probe(struct > platform_device *pdev) >         if (IS_ERR(ctx->base)) >                 return PTR_ERR(ctx->base); >   > +       ctx->reset = devm_reset_control_get_shared(&pdev->dev, NULL); The device tree bindings should have a required reset control property documented before this is added. > +       if (IS_ERR(ctx->reset)) > +               return PTR_ERR(ctx->reset); > + > +       reset_control_deassert(ctx->reset); > + This is missing a corresponding reset_control_assert() in aspeed_mdio_remove() and in the error path of of_mdiobus_register(). That would allow to assert the reset line again after all MDIO controllers are unbound. regards Philipp