stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: stable <stable@vger.kernel.org>
Subject: Re: netfilter/x_tables patches for v4.4.y..v4.14.y
Date: Thu, 15 Apr 2021 22:25:14 -0700	[thread overview]
Message-ID: <8689e6b0-215a-bd62-e105-dae58d9b824a@roeck-us.net> (raw)
In-Reply-To: <YHkex2OYIOQa8G+g@kroah.com>

On 4/15/21 10:21 PM, Greg Kroah-Hartman wrote:
> On Thu, Apr 15, 2021 at 10:41:46AM -0700, Guenter Roeck wrote:
>> On Thu, Apr 15, 2021 at 06:37:41PM +0200, Greg Kroah-Hartman wrote:
>>> On Thu, Apr 15, 2021 at 09:28:15AM -0700, Guenter Roeck wrote:
>>>> Hi Greg,
>>>>
>>>> please consider applying the following two patches to v4.4.y, v4.9.y, and v4.14.y
>>>>
>>>> 80055dab5de0 ("netfilter: x_tables: make xt_replace_table wait until old rules are not used anymore")
>>>> 175e476b8cdf ("netfilter: x_tables: Use correct memory barriers.")
>>>
>>> The second patch here says that it's only needed to go back until:
>>> 	    Fixes: 7f5c6d4f665b ("netfilter: get rid of atomic ops in fast path")
>>>
>>> Which is only backported to 4.19.  So why do older kernels need that, is
>>> the fixes tag wrong?
>>>
>> Where do you get that from ? 7f5c6d4f665b is, from what I can see, in v3.0.
>>
>> $ git describe 7f5c6d4f665b
>> v2.6.39-rc1-159-g7f5c6d4f665b
>> $ git log --oneline v2.6.39..v3.0 | grep "netfilter: get rid of atomic ops in fast path"
>> 7f5c6d4f665b netfilter: get rid of atomic ops in fast path
> 
> Ah, my tool that checks where a patch comes from doesn't look past 3.1
> if it finds that it was mentioned in a released tree for various
> reasons, but when I look at the full sha1, it finds it properly, my
> fault...
> 

Yes, but still please don't apply anything. As mentioned in the other patch,
80055dab5de0 was fixed twice subsequently, and those fixes don't apply cleanly.
Better leave this alone.

Thanks,
Guenter


  reply	other threads:[~2021-04-16  5:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 16:28 Guenter Roeck
2021-04-15 16:37 ` Greg Kroah-Hartman
2021-04-15 17:41   ` Guenter Roeck
2021-04-16  5:21     ` Greg Kroah-Hartman
2021-04-16  5:25       ` Guenter Roeck [this message]
2021-04-15 17:49   ` Guenter Roeck
2021-04-15 17:54     ` Guenter Roeck
2021-04-16  5:21       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8689e6b0-215a-bd62-e105-dae58d9b824a@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --subject='Re: netfilter/x_tables patches for v4.4.y..v4.14.y' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).