From: Michael Walle <michael@walle.cc>
To: Saravana Kannan <saravanak@google.com>
Cc: stable <stable@vger.kernel.org>,
Android Kernel Team <kernel-team@android.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] driver core: Fix SYNC_STATE_ONLY device link implementation
Date: Mon, 25 May 2020 13:31:27 +0200 [thread overview]
Message-ID: <86f3036b44941870d12e432948a7cbb6@walle.cc> (raw)
In-Reply-To: <41760105c011f9382f4d5fdc9feed017@walle.cc>
Am 2020-05-23 00:47, schrieb Michael Walle:
> Am 2020-05-23 00:21, schrieb Saravana Kannan:
>> On Fri, May 22, 2020 at 11:41 AM Michael Walle <michael@walle.cc>
>> wrote:
>>>
>>> Am Mon, 18 May 2020 23:30:00 -0700
>>> schrieb Saravana Kannan <saravanak@google.com>:
>>>
>>> > When SYNC_STATE_ONLY support was added in commit 05ef983e0d65 ("driver
>>> > core: Add device link support for SYNC_STATE_ONLY flag"),
>>> > device_link_add() incorrectly skipped adding the new SYNC_STATE_ONLY
>>> > device link to the supplier's and consumer's "device link" list.
>>> >
>>> > This causes multiple issues:
>>> > - The device link is lost forever from driver core if the caller
>>> > didn't keep track of it (caller typically isn't expected to). This
>>> > is a memory leak.
>>> > - The device link is also never visible to any other code path after
>>> > device_link_add() returns.
>>> >
>>> > If we fix the "device link" list handling, that exposes a bunch of
>>> > issues.
>>> >
>>> > 1. The device link "status" state management code rightfully doesn't
>>> > handle the case where a DL_FLAG_MANAGED device link exists between a
>>> > supplier and consumer, but the consumer manages to probe successfully
>>> > before the supplier. The addition of DL_FLAG_SYNC_STATE_ONLY links
>>> > break this assumption. This causes device_links_driver_bound() to
>>> > throw a warning when this happens.
>>> >
>>> > Since DL_FLAG_SYNC_STATE_ONLY device links are mainly used for
>>> > creating proxy device links for child device dependencies and aren't
>>> > useful once the consumer device probes successfully, this patch just
>>> > deletes DL_FLAG_SYNC_STATE_ONLY device links once its consumer device
>>> > probes. This way, we avoid the warning, free up some memory and avoid
>>> > complicating the device links "status" state management code.
>>> >
>>> > 2. Creating a DL_FLAG_STATELESS device link between two devices that
>>> > already have a DL_FLAG_SYNC_STATE_ONLY device link will result in the
>>> > DL_FLAG_STATELESS flag not getting set correctly. This patch also
>>> > fixes this.
>>> >
>>> > Lastly, this patch also fixes minor whitespace issues.
>>>
>>> My board triggers the
>>> WARN_ON(link->status != DL_STATE_CONSUMER_PROBE);
>>>
>>> Full bootlog:
> [..]
>
>> Thanks for the log and report. I haven't spent too much time thinking
>> about this, but can you give this a shot?
>> https://lore.kernel.org/lkml/20200520043626.181820-1-saravanak@google.com/
>
> I've already tried that, as this is already in linux-next. Doesn't fix
> it,
> though.
btw. this only happens on linux-next (tested with next-20200522), not on
5.7-rc7 (which has the same two patches of yours)
-michael
next prev parent reply other threads:[~2020-05-25 11:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 8:07 [PATCH v1] driver core: Fix memory leak when adding SYNC_STATE_ONLY device links Saravana Kannan
2020-05-18 7:48 ` Saravana Kannan
2020-05-18 8:03 ` Greg Kroah-Hartman
2020-05-18 19:47 ` Saravana Kannan
2020-05-19 3:00 ` [PATCH v2] driver core: Fix SYNC_STATE_ONLY device link implementation Saravana Kannan
2020-05-19 5:48 ` Greg Kroah-Hartman
2020-05-19 6:30 ` [PATCH v3] " Saravana Kannan
2020-05-19 10:47 ` Rafael J. Wysocki
2020-05-22 18:41 ` Michael Walle
2020-05-22 22:21 ` Saravana Kannan
2020-05-22 22:47 ` Michael Walle
2020-05-25 11:31 ` Michael Walle [this message]
2020-05-25 18:39 ` Saravana Kannan
2020-05-25 19:04 ` Michael Walle
2020-05-25 21:24 ` Saravana Kannan
2020-05-25 21:38 ` Michael Walle
[not found] ` <20200526070518.107333-1-saravanak@google.com>
2020-05-26 7:07 ` [PATCH v1] driver core: Update device link status correctly for SYNC_STATE_ONLY links Saravana Kannan
2020-05-26 11:04 ` Michael Walle
2020-05-26 18:08 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86f3036b44941870d12e432948a7cbb6@walle.cc \
--to=michael@walle.cc \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=saravanak@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).