From: Nix <nix@esperi.org.uk>
To: Coly Li <colyli@suse.de>
Cc: Eric Wheeler <bcache@lists.ewheeler.net>,
linux-bcache@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] bcache: back to cache all readahead I/Os
Date: Wed, 15 Jan 2020 12:39:29 +0000 [thread overview]
Message-ID: <875zhc3ncu.fsf@esperi.org.uk> (raw)
In-Reply-To: <5af6593d-b6aa-74a7-0aae-e3c689cebc67@suse.de> (Coly Li's message of "Wed, 15 Jan 2020 14:21:05 +0800")
On 15 Jan 2020, Coly Li stated:
> I have two reports offline and directly to me, one is from an email
> address of github and forwarded to me by Jens, one is from a China local
> storage startup.
>
> The first report complains the desktop-pc benchmark is about 50% down
> and the root cause is located on commit b41c9b0 ("bcache: update
> bio->bi_opf bypass/writeback REQ_ flag hints").
>
> The second report complains their small file workload (mixed read and
> write) has around 20%+ performance drop and the suspicious change is
> also focused on the readahead restriction.
>
> The second reporter verifies this patch and confirms the performance
> issue has gone. I don't know who is the first report so no response so far.
Hah! OK, looks like readahead is frequently-enough useful that caching
it is better than not caching it :) I guess the problem is that if you
don't cache it, it never gets cached at all even if it was useful, so
the next time round you'll end up having to readahead it again :/
One wonders what effect this will have on a bcache-atop-RAID: will we
end up caching whole stripes most of the time?
next prev parent reply other threads:[~2020-01-15 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 6:58 [PATCH] bcache: back to cache all readahead I/Os Coly Li
2020-01-06 22:57 ` Eric Wheeler
2020-01-14 12:34 ` Nix
2020-01-15 6:21 ` Coly Li
2020-01-15 12:39 ` Nix [this message]
2020-01-16 0:00 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zhc3ncu.fsf@esperi.org.uk \
--to=nix@esperi.org.uk \
--cc=bcache@lists.ewheeler.net \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).