From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org
Cc: John Youn <John.Youn@synopsys.com>, stable@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: gadget: Fix START_TRANSFER link state check
Date: Tue, 20 Apr 2021 10:47:25 +0300 [thread overview]
Message-ID: <87eef5mm7m.fsf@kernel.org> (raw)
In-Reply-To: <bcefaa9ecbc3e1936858c0baa14de6612960e909.1618884221.git.Thinh.Nguyen@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
Hi,
Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> The START_TRANSFER command needs to be executed while in ON/U0 link
> state (with an exception during register initialization). Don't use
> dwc->link_state to check this since the driver only tracks the link
> state when the link state change interrupt is enabled. Check the link
> state from DSTS register instead.
>
> Note that often the host already brings the device out of low power
> before it sends/requests the next transfer. So, the user won't see any
> issue when the device starts transfer then. This issue is more
> noticeable in cases when the device delays starting transfer, which can
> happen during delayed control status after the host put the device in
> low power.
>
> Cc: <stable@vger.kernel.org>
> Fixes: 799e9dc82968 ("usb: dwc3: gadget: conditionally disable Link State change events")
> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
prev parent reply other threads:[~2021-04-20 7:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 2:11 [PATCH] usb: dwc3: gadget: Fix START_TRANSFER link state check Thinh Nguyen
2021-04-20 7:47 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eef5mm7m.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).