From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1665C43460 for ; Wed, 21 Apr 2021 17:57:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9416061453 for ; Wed, 21 Apr 2021 17:57:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235836AbhDUR6L (ORCPT ); Wed, 21 Apr 2021 13:58:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:35976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235658AbhDUR6L (ORCPT ); Wed, 21 Apr 2021 13:58:11 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 919E16141C; Wed, 21 Apr 2021 17:57:37 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lZH6V-008kJm-39; Wed, 21 Apr 2021 18:57:35 +0100 Date: Wed, 21 Apr 2021 18:57:34 +0100 Message-ID: <87sg3jsepd.wl-maz@kernel.org> From: Marc Zyngier To: Sudeep Holla Cc: Lorenzo Pieralisi , Hanjun Guo , dann frazier , Fu Wei , Len Brown , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org Subject: Re: [PATCH 1/2] ACPI: GTDT: Don't corrupt interrupt mappings on watchdow probe failure In-Reply-To: <20210421172056.n2yoggo5epqwdhtc@bogus> References: <20210421164317.1718831-1-maz@kernel.org> <20210421164317.1718831-2-maz@kernel.org> <20210421172056.n2yoggo5epqwdhtc@bogus> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: sudeep.holla@arm.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, dann.frazier@canonical.com, wefu@redhat.com, lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, 21 Apr 2021 18:20:56 +0100, Sudeep Holla wrote: > > (with stable email fixed, but may need separate posting anyways) > > On Wed, Apr 21, 2021 at 05:43:16PM +0100, Marc Zyngier wrote: > > When failing the driver probe because of invalid firmware properties, > > the GTDT driver unmaps the interrupt that it mapped earlier. > > > > However, it never checks whether the mapping of the interrupt actially > > succeeded. Even more, should the firmware report an illegal interrupt > > number that overlaps with the GIC SGI range, this can result in an > > IPI being unmapped, and subsequent fireworks (as reported by Dann > > Frazier). > > > > Rework the driver to have a slightly saner behaviour and actually > > check whether the interrupt has been mapped before unmapping things. > > > > Reported-by: dann frazier > > Fixes: ca9ae5ec4ef0 ("acpi/arm64: Add SBSA Generic Watchdog support in GTDT driver") > > Signed-off-by: Marc Zyngier > > Link: https://lore.kernel.org/r/YH87dtTfwYgavusz@xps13.dannf > > Cc: stable@vgerlkernel.org > ^^^ > > I thought I messed up while replying with my fat fingers, but here is the > culprit. I got mail delivery failure to my reply, thought I will let you > know as it may be difficult to notice this when using git send-email. I'm definitely the one with very fat fingers. I'll fix the patch in my tree. Thanks for the heads up, M. -- Without deviation from the norm, progress is not possible.