From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7089BC4363A for ; Tue, 27 Oct 2020 09:11:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 236212225C for ; Tue, 27 Oct 2020 09:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603789879; bh=3nJVYPqAmda6ppGiGO4U2OH69glESivKp8oHSZq5RgQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-ID:From; b=E0NHR836bc24prLG4OaYQHU57iZrrkxYfSbjOc2rhmXm3hwtzxafFn3HCYBFet6/D Hzc8xHNpv95xk+TrN3ZDCgz/F0lEB9P4UzAAq8kxHSCgjmK2gUTI0QLbPjZpdFvZ81 L0EqPmbeS+vA+9dTTy6MDTZaL8ykaSrtQ5N3SmE8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895452AbgJ0JLS (ORCPT ); Tue, 27 Oct 2020 05:11:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:59302 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895450AbgJ0JLS (ORCPT ); Tue, 27 Oct 2020 05:11:18 -0400 Received: from saruman (88-113-213-94.elisa-laajakaista.fi [88.113.213.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E405B20747; Tue, 27 Oct 2020 09:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603789878; bh=3nJVYPqAmda6ppGiGO4U2OH69glESivKp8oHSZq5RgQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BQQ5PYMeAAZOQBfDzfWSSSm1iXaA0ftEvw9m0C3jTA4gElvkiXn39YZX/bhjF0quH F8A9lQk6EBD+k5bHnuv8kBDYkPJoWDICDEbEwAxF6jPMN4+5hkvm+emddAXor9FlpA ENOszDhRCQ+zbSYHIVDp8iHX5LQ9Ybsdb7Vwek38= From: Felipe Balbi To: Peter Chen , pawell@cadence.com, rogerq@ti.com Cc: linux-usb@vger.kernel.org, linux-imx@nxp.com, gregkh@linuxfoundation.org, jun.li@nxp.com, stable@vger.kernel.org, Peter Chen Subject: Re: [PATCH 3/3] usb: cdns3: Fix on-chip memory overflow issue In-Reply-To: <20201016101659.29482-4-peter.chen@nxp.com> References: <20201016101659.29482-1-peter.chen@nxp.com> <20201016101659.29482-4-peter.chen@nxp.com> Date: Tue, 27 Oct 2020 11:11:13 +0200 Message-ID: <87sga0c9u6.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi, Peter Chen writes: > From: Pawel Laszczak > > Patch fixes issue caused setting On-chip memory overflow bit in usb_sts > register. The issue occurred because EP_CFG register was set twice > before USB_STS.CFGSTS was set. Every write operation on EP_CFG.BUFFERING > causes that controller increases internal counter holding the number > of reserved on-chip buffers. First time this register was updated in > function cdns3_ep_config before delegating SET_CONFIGURATION request > to class driver and again it was updated when class wanted to enable > endpoint. This patch fixes this issue by configuring endpoints > enabled by class driver in cdns3_gadget_ep_enable and others just > before status stage. > > Cc: #v5.8+ > Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") > Reported-and-tested-by: Peter Chen > Signed-off-by: Pawel Laszczak > Signed-off-by: Peter Chen This looks very large for a fix, are you sure there isn't a minimal fix hidden somewhere? -- balbi