From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E5C3C432C0 for ; Mon, 2 Dec 2019 11:36:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFEA1215E5 for ; Mon, 2 Dec 2019 11:36:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727332AbfLBLgH (ORCPT ); Mon, 2 Dec 2019 06:36:07 -0500 Received: from mga04.intel.com ([192.55.52.120]:16401 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726330AbfLBLgH (ORCPT ); Mon, 2 Dec 2019 06:36:07 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 03:36:07 -0800 X-IronPort-AV: E=Sophos;i="5.69,268,1571727600"; d="scan'208";a="204524536" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.66.161]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Dec 2019 03:36:04 -0800 From: Jani Nikula To: "Peres\, Martin" , Chris Wilson , "intel-gfx\@lists.freedesktop.org" Cc: Joonas Lahtinen , "Vivi\, Rodrigo" , "stable\@vger.kernel.org" Subject: Re: [PATCH] drm/i915: Update bug URL to point at gitlab issues In-Reply-To: <56A4AB1F0E1B5D4C83D27F43C50F662E5908DD0B@IRSMSX107.ger.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20191125104248.1690891-1-chris@chris-wilson.co.uk> <878snvkojl.fsf@intel.com> <56A4AB1F0E1B5D4C83D27F43C50F662E5908DD0B@IRSMSX107.ger.corp.intel.com> Date: Mon, 02 Dec 2019 13:36:01 +0200 Message-ID: <87zhgbj6xq.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 02 Dec 2019, "Peres, Martin" wrote: > On 02/12/2019 12:30, Jani Nikula wrote: >> On Mon, 25 Nov 2019, Chris Wilson wrote: >>> We are moving our issue tracking over from bugs.fd.o to gitlab.fd.o, so >>> update the user instructions accordingly. >>> >>> Signed-off-by: Chris Wilson >>> Cc: Martin Peres >>> Cc: Joonas Lahtinen >>> Cc: Rodrigo Vivi >>> Cc: Jani Nikula >>> Cc: stable@vger.kernel.org >>> --- >>> drivers/gpu/drm/i915/i915_gpu_error.c | 2 +- >>> drivers/gpu/drm/i915/i915_utils.c | 3 +-- >>> drivers/gpu/drm/i915/i915_utils.h | 2 ++ >>> 3 files changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c >>> index 2b30a45fa25c..1cf53fd4fe66 100644 >>> --- a/drivers/gpu/drm/i915/i915_gpu_error.c >>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c >>> @@ -1817,7 +1817,7 @@ void i915_capture_error_state(struct drm_i915_private *i915, >>> if (!xchg(&warned, true) && >>> ktime_get_real_seconds() - DRIVER_TIMESTAMP < DAY_AS_SECONDS(180)) { >>> pr_info("GPU hangs can indicate a bug anywhere in the entire gfx stack, including userspace.\n"); >>> - pr_info("Please file a _new_ bug report on bugs.freedesktop.org against DRI -> DRM/Intel\n"); >>> + pr_info("Please file a _new_ bug report on " FDO_BUG_URL "\n"); >>> pr_info("drm/i915 developers can then reassign to the right component if it's not a kernel issue.\n"); >>> pr_info("The GPU crash dump is required to analyze GPU hangs, so please always attach it.\n"); >>> pr_info("GPU crash dump saved to /sys/class/drm/card%d/error\n", >>> diff --git a/drivers/gpu/drm/i915/i915_utils.c b/drivers/gpu/drm/i915/i915_utils.c >>> index c47261ae86ea..9b68b21becf1 100644 >>> --- a/drivers/gpu/drm/i915/i915_utils.c >>> +++ b/drivers/gpu/drm/i915/i915_utils.c >>> @@ -8,8 +8,7 @@ >>> #include "i915_drv.h" >>> #include "i915_utils.h" >>> >>> -#define FDO_BUG_URL "https://bugs.freedesktop.org/enter_bug.cgi?product=DRI" >>> -#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL " against DRM/Intel " \ >>> +#define FDO_BUG_MSG "Please file a bug at " FDO_BUG_URL \ >>> "providing the dmesg log by booting with drm.debug=0xf" >> >> Space between URL and "providing"? > > If the following comment is accepted, then we need to change this > sentence to: > > Please file bugs according to the instruction found at FDO_BUG_URL. > >> >>> >>> void >>> diff --git a/drivers/gpu/drm/i915/i915_utils.h b/drivers/gpu/drm/i915/i915_utils.h >>> index 04139ba1191e..13674b016092 100644 >>> --- a/drivers/gpu/drm/i915/i915_utils.h >>> +++ b/drivers/gpu/drm/i915/i915_utils.h >>> @@ -34,6 +34,8 @@ >>> struct drm_i915_private; >>> struct timer_list; >>> >>> +#define FDO_BUG_URL "https://gitlab.freedesktop.org/drm/intel/issues/new?" >> >> Do we really need the question mark? > > We may want to point to > https://gitlab.freedesktop.org/drm/intel/wikis/How-to-file-file-i915-bugs, > don't you think? Does gitlab let you set the URL, or is it always autogenerated from the title? Need to at least fix the "file file" there. ;) BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center