Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

[Christophe Leroy]

   CC      fs/io_uring.o
fs/io_uring.c: In function ‘loop_rw_iter’:
fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’ 
[-Werror=implicit-function-declaration]
     iovec.iov_base = kmap(iter->bvec->bv_page)
                      ^
fs/io_uring.c:1628:19: warning: assignment makes pointer from integer 
without a cast [-Wint-conversion]
     iovec.iov_base = kmap(iter->bvec->bv_page)
                    ^
fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’ 
[-Werror=implicit-function-declaration]
     kunmap(iter->bvec->bv_page);
     ^


Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter 
fixed rw") clears the failure.

Most likely an #include is missing.


Christophe

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

[Jens Axboe]

On 11/29/19 6:53 AM, Christophe Leroy wrote:
>     CC      fs/io_uring.o
> fs/io_uring.c: In function ‘loop_rw_iter’:
> fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’
> [-Werror=implicit-function-declaration]
>       iovec.iov_base = kmap(iter->bvec->bv_page)
>                        ^
> fs/io_uring.c:1628:19: warning: assignment makes pointer from integer
> without a cast [-Wint-conversion]
>       iovec.iov_base = kmap(iter->bvec->bv_page)
>                      ^
> fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’
> [-Werror=implicit-function-declaration]
>       kunmap(iter->bvec->bv_page);
>       ^
> 
> 
> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter
> fixed rw") clears the failure.
> 
> Most likely an #include is missing.

Huh weird how the build bots didn't catch that. Does the below work?


diff --git a/fs/io_uring.c b/fs/io_uring.c
index 2c2e8c25da01..745eb005fefe 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -69,6 +69,7 @@
  #include <linux/nospec.h>
  #include <linux/sizes.h>
  #include <linux/hugetlb.h>
+#include <linux/highmem.h>
  
  #define CREATE_TRACE_POINTS
  #include <trace/events/io_uring.h>

-- 
Jens Axboe

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

[Christophe Leroy]

Le 29/11/2019 à 17:04, Jens Axboe a écrit :
> On 11/29/19 6:53 AM, Christophe Leroy wrote:
>>     CC      fs/io_uring.o
>> fs/io_uring.c: In function ‘loop_rw_iter’:
>> fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’
>> [-Werror=implicit-function-declaration]
>>       iovec.iov_base = kmap(iter->bvec->bv_page)
>>                        ^
>> fs/io_uring.c:1628:19: warning: assignment makes pointer from integer
>> without a cast [-Wint-conversion]
>>       iovec.iov_base = kmap(iter->bvec->bv_page)
>>                      ^
>> fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’
>> [-Werror=implicit-function-declaration]
>>       kunmap(iter->bvec->bv_page);
>>       ^
>>
>>
>> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter
>> fixed rw") clears the failure.
>>
>> Most likely an #include is missing.
> 
> Huh weird how the build bots didn't catch that. Does the below work?

Yes it works, thanks.

Christophe

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

[Jens Axboe]

On 11/29/19 8:14 AM, Christophe Leroy wrote:
> 
> 
> Le 29/11/2019 à 17:04, Jens Axboe a écrit :
>> On 11/29/19 6:53 AM, Christophe Leroy wrote:
>>>      CC      fs/io_uring.o
>>> fs/io_uring.c: In function ‘loop_rw_iter’:
>>> fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’
>>> [-Werror=implicit-function-declaration]
>>>        iovec.iov_base = kmap(iter->bvec->bv_page)
>>>                         ^
>>> fs/io_uring.c:1628:19: warning: assignment makes pointer from integer
>>> without a cast [-Wint-conversion]
>>>        iovec.iov_base = kmap(iter->bvec->bv_page)
>>>                       ^
>>> fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’
>>> [-Werror=implicit-function-declaration]
>>>        kunmap(iter->bvec->bv_page);
>>>        ^
>>>
>>>
>>> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter
>>> fixed rw") clears the failure.
>>>
>>> Most likely an #include is missing.
>>
>> Huh weird how the build bots didn't catch that. Does the below work?
> 
> Yes it works, thanks.

Thanks for reporting and testing, I've queued it up with your reported
and tested-by.

-- 
Jens Axboe

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

[Pavel Begunkov]

[-- Attachment #1.1: Type: text/plain, Size: 531 bytes --]

On 29/11/2019 20:16, Jens Axboe wrote:
> On 11/29/19 8:14 AM, Christophe Leroy wrote:
>>>>
>>>> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter
>>>> fixed rw") clears the failure.
>>>>
>>>> Most likely an #include is missing.
>>>
>>> Huh weird how the build bots didn't catch that. Does the below work?
>>
>> Yes it works, thanks.
> 
> Thanks for reporting and testing, I've queued it up with your reported
> and tested-by.
> 
My bad, thanks for the report and fixing.

-- 
Pavel Begunkov


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

[Jens Axboe]

On 11/29/19 10:07 AM, Pavel Begunkov wrote:
> On 29/11/2019 20:16, Jens Axboe wrote:
>> On 11/29/19 8:14 AM, Christophe Leroy wrote:
>>>>>
>>>>> Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter
>>>>> fixed rw") clears the failure.
>>>>>
>>>>> Most likely an #include is missing.
>>>>
>>>> Huh weird how the build bots didn't catch that. Does the below work?
>>>
>>> Yes it works, thanks.
>>
>> Thanks for reporting and testing, I've queued it up with your reported
>> and tested-by.
>>
> My bad, thanks for the report and fixing.

No worries, usually the build bots are great at finding these before
patches go upstream. They have been unreliable lately, unfortunately.

-- 
Jens Axboe

Re: Build failure on latest powerpc/merge (311ae9e159d8 io_uring: fix dead-hung for non-iter fixed rw)

[Geert Uytterhoeven]

Hi Jens,

On Fri, Nov 29, 2019 at 5:06 PM Jens Axboe <axboe@kernel.dk> wrote:
> On 11/29/19 6:53 AM, Christophe Leroy wrote:
> >     CC      fs/io_uring.o
> > fs/io_uring.c: In function ‘loop_rw_iter’:
> > fs/io_uring.c:1628:21: error: implicit declaration of function ‘kmap’
> > [-Werror=implicit-function-declaration]
> >       iovec.iov_base = kmap(iter->bvec->bv_page)
> >                        ^
> > fs/io_uring.c:1628:19: warning: assignment makes pointer from integer
> > without a cast [-Wint-conversion]
> >       iovec.iov_base = kmap(iter->bvec->bv_page)
> >                      ^
> > fs/io_uring.c:1643:4: error: implicit declaration of function ‘kunmap’
> > [-Werror=implicit-function-declaration]
> >       kunmap(iter->bvec->bv_page);
> >       ^
> >
> >
> > Reverting commit 311ae9e159d8 ("io_uring: fix dead-hung for non-iter
> > fixed rw") clears the failure.
> >
> > Most likely an #include is missing.
>
> Huh weird how the build bots didn't catch that. Does the below work?

Thanks, this fixes the same issue on SuperH:

Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -69,6 +69,7 @@
>   #include <linux/nospec.h>
>   #include <linux/sizes.h>
>   #include <linux/hugetlb.h>
> +#include <linux/highmem.h>
>
>   #define CREATE_TRACE_POINTS
>   #include <trace/events/io_uring.h>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds