From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: stable@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH] f2fs: get out of a repeat loop when getting a locked data page
Date: Sun, 26 Mar 2023 21:47:14 +0800 [thread overview]
Message-ID: <8aea02b0-86f9-539a-02e9-27b381e68b66@kernel.org> (raw)
In-Reply-To: <20230323213919.1876157-1-jaegeuk@kernel.org>
On 2023/3/24 5:39, Jaegeuk Kim wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=216050
>
> Somehow we're getting a page which has a different mapping.
> Let's avoid the infinite loop.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/data.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index bf51e6e4eb64..80702c93e885 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1329,18 +1329,14 @@ struct page *f2fs_get_lock_data_page(struct inode *inode, pgoff_t index,
> {
> struct address_space *mapping = inode->i_mapping;
> struct page *page;
> -repeat:
> +
> page = f2fs_get_read_data_page(inode, index, 0, for_write, NULL);
> if (IS_ERR(page))
> return page;
>
> /* wait for read completion */
> lock_page(page);
> - if (unlikely(page->mapping != mapping)) {
How about using such logic only for move_data_page() to limit affect for
other paths?
Jaegeuk, any thoughts about why mapping is mismatch in between page's one and
inode->i_mapping?
After several times code review, I didn't get any clue about why f2fs always
get the different mapping in a loop.
Maybe we can loop MM guys to check whether below folio_file_page() may return
page which has different mapping?
struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index,
int fgp_flags, gfp_t gfp)
{
struct folio *folio;
folio = __filemap_get_folio(mapping, index, fgp_flags, gfp);
if (IS_ERR(folio))
return NULL;
return folio_file_page(folio, index);
}
Thanks,
> - f2fs_put_page(page, 1);
> - goto repeat;
> - }
> - if (unlikely(!PageUptodate(page))) {
> + if (unlikely(page->mapping != mapping || !PageUptodate(page))) {
> f2fs_put_page(page, 1);
> return ERR_PTR(-EIO);
> }
next prev parent reply other threads:[~2023-03-26 13:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 21:39 [PATCH] f2fs: get out of a repeat loop when getting a locked data page Jaegeuk Kim
2023-03-26 13:47 ` Chao Yu [this message]
2023-03-27 15:30 ` [f2fs-dev] " Jaegeuk Kim
2023-03-27 16:22 ` Matthew Wilcox
2023-04-05 16:39 ` Jaegeuk Kim
2023-04-05 20:47 ` Jaegeuk Kim
2023-04-06 1:50 ` Chao Yu
2023-04-06 3:18 ` Jaegeuk Kim
2023-04-10 9:57 ` Chao Yu
2023-04-10 23:24 ` Jaegeuk Kim
2023-04-11 8:49 ` Chao Yu
2023-03-30 13:23 ` Chao Yu
2023-07-17 17:34 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aea02b0-86f9-539a-02e9-27b381e68b66@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).