From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFEAC48BE8 for ; Fri, 18 Jun 2021 08:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88598613BD for ; Fri, 18 Jun 2021 08:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231286AbhFRI7f (ORCPT ); Fri, 18 Jun 2021 04:59:35 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:48058 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbhFRI7e (ORCPT ); Fri, 18 Jun 2021 04:59:34 -0400 Received: from mail-ed1-f70.google.com ([209.85.208.70]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1luAJY-00015P-Mv for stable@vger.kernel.org; Fri, 18 Jun 2021 08:57:24 +0000 Received: by mail-ed1-f70.google.com with SMTP id q7-20020aa7cc070000b029038f59dab1c5so3172925edt.23 for ; Fri, 18 Jun 2021 01:57:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=90eZ7DdlkWMvodEOxckCvRjJunUc+CQAeE7AAVorkBo=; b=EJHY7cNPwgwqgpQrOe7fML6Wmvu39XDGEbk9EvtpIihH1hKPvdVorhOrRFGnMDzAuA uLmh291zcXkdgYIMriit1rCKOMIhyANgj3R3CEDz8nsS/+xwzAucvMpiVnwWV3rWevnj sA+ugbvBXJkEQBc3Aiwh054BhMZ8NHS+u+QbNMc6KuX5gGiGtFuigfFs4/P1QSPlHiW1 Ruc/l8hPCYcljrr4pBAZKNGlPihGmqaRjBb//6GhArE8Wh7nFhVfAZE5Dap/hVPyFeoO lIq25bi3YEfVu5GmMiW4rV6721/bc/nmeqsGZZukrF8dCtb3/okPSRa6qxdyQqOSaFeg X5XA== X-Gm-Message-State: AOAM531+2ARYN9hiBqTiZFGNvirkw7DTKXIBlrIKm9P1b9pZ1SleiO24 IwPF3RWDljKW1MEEwGr1/nWChFpOU6UvSe5JqOBMzFtG7jcDLV0PpscNlhjEKFknfJxVar7v5Up j/RO6/B78HiFNxruHzftymGVqssa6CGP3eg== X-Received: by 2002:a17:906:9bef:: with SMTP id de47mr9635396ejc.78.1624006644474; Fri, 18 Jun 2021 01:57:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWHwb0R1Y7NCVvXM1ylqzUaMbxbRhFt2x1HrSz6JE9ym4XOR5P9tZt+dFWHoNsxRJp5m4ygw== X-Received: by 2002:a17:906:9bef:: with SMTP id de47mr9635385ejc.78.1624006644337; Fri, 18 Jun 2021 01:57:24 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id g23sm753292ejh.116.2021.06.18.01.57.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jun 2021 01:57:24 -0700 (PDT) Subject: Re: [PATCH 5.4 031/184] modules: inherit TAINT_PROPRIETARY_MODULE To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org, Daniel Vetter , Christoph Hellwig , Jessica Yu References: <20210510101950.200777181@linuxfoundation.org> <20210510101951.249384110@linuxfoundation.org> From: Krzysztof Kozlowski Message-ID: <8edc6f45-6c42-19c7-6f40-6f1a49cc685b@canonical.com> Date: Fri, 18 Jun 2021 10:57:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210510101951.249384110@linuxfoundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On 10/05/2021 12:18, Greg Kroah-Hartman wrote: > From: Christoph Hellwig > > commit 262e6ae7081df304fc625cf368d5c2cbba2bb991 upstream. > > If a TAINT_PROPRIETARY_MODULE exports symbol, inherit the taint flag > for all modules importing these symbols, and don't allow loading > symbols from TAINT_PROPRIETARY_MODULE modules if the module previously > imported gplonly symbols. Add a anti-circumvention devices so people > don't accidentally get themselves into trouble this way. > > Comment from Greg: > "Ah, the proven-to-be-illegal "GPL Condom" defense :)" Patch got in to stable, so my comments are quite late, but can someone explain me - how this is a stable material? What specific, real bug that bothers people, is being fixed here? Or maybe it fixes serious issue reported by a user of distribution kernel? IOW, how does this match stable kernel rules at all? For sure it breaks some out-of-tree modules already present and used by customers of downstream stable kernels. Therefore I wonder what is the bug fixed here, so the breakage and annoyance of stable users is justified. > > [jeyu: pr_info -> pr_err and pr_warn as per discussion] > Link: http://lore.kernel.org/r/20200730162957.GA22469@lst.de > Acked-by: Daniel Vetter > Reviewed-by: Greg Kroah-Hartman > Signed-off-by: Christoph Hellwig > Signed-off-by: Jessica Yu > Signed-off-by: Greg Kroah-Hartman Best regards, Krzysztof