From: Roberto Sassu <roberto.sassu@huawei.com>
To: Juergen Gross <jgross@suse.com>, Heiko Carstens <hca@linux.ibm.com>
Cc: "gor@linux.ibm.com" <gor@linux.ibm.com>,
"borntraeger@de.ibm.com" <borntraeger@de.ibm.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH v2] s390: Fix strrchr() implementation
Date: Tue, 5 Oct 2021 13:30:45 +0000 [thread overview]
Message-ID: <923ea0761d4d45158acbd1347d9bb6b5@huawei.com> (raw)
In-Reply-To: <4eb4c1ea-d392-62fd-201f-472f24496f46@suse.com>
> From: Juergen Gross [mailto:jgross@suse.com]
> Sent: Tuesday, October 5, 2021 3:25 PM
> On 05.10.21 15:14, Heiko Carstens wrote:
> > On Tue, Oct 05, 2021 at 02:08:36PM +0200, Roberto Sassu wrote:
> >> Fix two problems found in the strrchr() implementation for s390
> >> architectures: evaluate empty strings (return the string address instead of
> >> NULL, if '\0' is passed as second argument); evaluate the first character
> >> of non-empty strings (the current implementation stops at the second).
> >>
> >> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> >> Cc: stable@vger.kernel.org
> >> Reported-by: Heiko Carstens <hca@linux.ibm.com> (incorrect behavior with
> empty strings)
> >> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
> >> ---
> >> arch/s390/lib/string.c | 15 +++++++--------
> >> 1 file changed, 7 insertions(+), 8 deletions(-)
> >
> > Applied, thanks!
> >
>
> Really? I just wanted to write a response: len is unsigned (size_t)
> and compared to be >= 0, which sounds like always true.
Thanks for catching this. Will fix it.
Roberto
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Li Peng, Zhong Ronghua
next prev parent reply other threads:[~2021-10-05 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 12:08 [PATCH v2] s390: Fix strrchr() implementation Roberto Sassu
2021-10-05 13:14 ` Heiko Carstens
2021-10-05 13:24 ` Juergen Gross
2021-10-05 13:30 ` Roberto Sassu [this message]
2021-10-05 13:36 ` Heiko Carstens
2021-10-05 13:39 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=923ea0761d4d45158acbd1347d9bb6b5@huawei.com \
--to=roberto.sassu@huawei.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).