stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: Gao Xiang <hsiangkao@aol.com>, <linux-erofs@lists.ozlabs.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	David Michael <fedora.dm0@gmail.com>,
	Miao Xie <miaoxie@huawei.com>, Fang Wei <fangwei1@huawei.com>,
	Wang Li <wangli74@huawei.com>, Gao Xiang <gaoxiang25@huawei.com>,
	<stable@vger.kernel.org>
Subject: Re: [PATCH] erofs: zero out when listxattr is called with no xattr
Date: Wed, 4 Dec 2019 11:14:37 +0800	[thread overview]
Message-ID: <947ae429-d206-0859-ee5b-9bd37f7fd72b@huawei.com> (raw)
In-Reply-To: <20191201084040.29275-1-hsiangkao@aol.com>

On 2019/12/1 16:40, Gao Xiang wrote:
> From: Gao Xiang <gaoxiang25@huawei.com>
> 
> As David reported [1], ENODATA returns when attempting
> to modify files by using EROFS as a overlayfs lower layer.
> 
> The root cause is that listxattr could return unexpected
> -ENODATA by mistake for inodes without xattr. That breaks
> listxattr return value convention and it can cause copy
> up failure when used with overlayfs.
> 
> Resolve by zeroing out if no xattr is found for listxattr.
> 
> [1] https://lore.kernel.org/r/CAEvUa7nxnby+rxK-KRMA46=exeOMApkDMAV08AjMkkPnTPV4CQ@mail.gmail.com
> Fixes: cadf1ccf1b00 ("staging: erofs: add error handling for xattr submodule")
> Cc: <stable@vger.kernel.org> # 4.19+
> Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>

Reviewed-by: Chao Yu <yuchao0@huawei.com>

Thanks,

      parent reply	other threads:[~2019-12-04  3:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191201084040.29275-1-hsiangkao.ref@aol.com>
2019-12-01  8:40 ` [PATCH] erofs: zero out when listxattr is called with no xattr Gao Xiang
     [not found]   ` <20191202221312.8F590206F0@mail.kernel.org>
2019-12-03  1:52     ` Gao Xiang
2019-12-04  3:14   ` Chao Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=947ae429-d206-0859-ee5b-9bd37f7fd72b@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=fangwei1@huawei.com \
    --cc=fedora.dm0@gmail.com \
    --cc=gaoxiang25@huawei.com \
    --cc=hsiangkao@aol.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=stable@vger.kernel.org \
    --cc=wangli74@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).