stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>,
	Computer Enthusiastic <computer.enthusiastic@gmail.com>
Cc: Salvatore Bonaccorso <carnil@debian.org>,
	stable@vger.kernel.org, Karol Herbst <kherbst@redhat.com>,
	Ben Skeggs <bskeggs@redhat.com>,
	nouveau@lists.freedesktop.org
Subject: Re: [Nouveau] [PATCH] nouveau: explicitly wait on the fence in nouveau_bo_move_m2mf
Date: Mon, 30 Jan 2023 17:27:03 -0500	[thread overview]
Message-ID: <9e4cb1d818e4ce04c3e465a397e5652349e3938a.camel@redhat.com> (raw)
In-Reply-To: <Y9eWhGj/ecjUcYO/@kroah.com>

Thanks a ton for the help Greg!

On Mon, 2023-01-30 at 11:05 +0100, Greg KH wrote:
> On Sun, Jan 29, 2023 at 10:36:31PM +0100, Computer Enthusiastic wrote:
> > Hello Greg,
> > Hello Salvatore,
> > 
> > On 28/01/2023 20:49, Salvatore Bonaccorso wrote:
> > > Hi Greg,
> > > 
> > > I'm not the reporter, so would like to confirm him explicitly, but I
> > > believe I can give some context:
> > > 
> > > On Sat, Jan 28, 2023 at 06:51:08PM +0100, Greg KH wrote:
> > > > On Sat, Jan 28, 2023 at 03:49:59PM +0100, Computer Enthusiastic wrote:
> > > > > Hello,
> > > > > 
> > > > > The patch "[Nouveau] [PATCH] nouveau: explicitly wait on the fence in
> > > > > nouveau_bo_move_m2mf" [1] was marked for kernels v5.15+ and it was merged
> > > > > upstream.
> > > > > 
> > > > > The same patch [1] works with kernel 5.10.y, but it is not been merged
> > > > > upstream so far.
> > > > > 
> > > > > According to Karol Herbst suggestion [2], I'm sending this message to ask
> > > > > for merging it into 5.10 kernel.
> > > > 
> > > > We need to know the git commit id.  And have you tested it on 5.10.y?
> > > > And why are you stuck on 5.10.y for this type of hardware?  Why not move
> > > > to 5.15.y or 6.1.y?
> > > 
> > > This would be commit 6b04ce966a73 ("nouveau: explicitly wait on the
> > > fence in nouveau_bo_move_m2mf") in mainline, applied in 6.0-rc3 and
> > > backported to 5.19.6 and 5.15.64.
> > > 
> > > Computer Enthusiastic, tested it on 5.10.y:
> > > https://lore.kernel.org/nouveau/CAHSpYy1mcTns0JS6eivjK82CZ9_ajSwH-H7gtDwCkNyfvihaAw@mail.gmail.com/
> > > 
> > > It was reported in Debian by the user originally as
> > > https://bugs.debian.org/989705#69 after updating to the 5.10.y series in Debian
> > > bullseye.
> > > 
> > > I guess the user could move to the next stable release Debian bookworm, once
> > > it's released (it's currently in the last milestones to finalize, cf.
> > > https://release.debian.org/ but we are not yet there). In the next release this
> > > will be automatically be fixed indeed.
> > > 
> > > Computer Enthusiastic, can you confirm please to Greg in particular the first
> > > questions, in particular to confirm the commit fixes the suspend issue?
> > > 
> > > Regards,
> > > Salvatore
> > 
> > Thanks for replaying to my request: I really appreciate.
> > 
> > I apologize if my request was not formally correct.
> > 
> > The upstream kernel 5.10.y hangs on suspend or fails to resume if it is
> > suspended to ram or suspended to disk (if nouveau kernel module is used with
> > some nvidia graphic cards).
> > 
> > I confirm the commit ID 6b04ce966a73 (by Karol Herbst) fixes the
> > aforementioned suspend to ram and suspend to disk issues with kernel 5.10.y
> > . It tested it with my own computer.
> > 
> > The last kernel version I tested is 5.10.165, that I patched and installed
> > in Debian Stable (11.6) that I'm currently running and that I tested again
> > today.
> > 
> > It would be nice if the next point release of Debian Stable could ship a
> > kernel that includes patch commit ID 6b04ce966a73 for the benefit of nouveau
> > module users.
> 
> Ok, I've queued it up for 5.10.y now, thanks.
> 
> greg k-h
> 

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat


  reply	other threads:[~2023-01-30 22:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-19 20:09 [PATCH] nouveau: explicitly wait on the fence in nouveau_bo_move_m2mf Karol Herbst
2022-08-22 21:15 ` Lyude Paul
2022-09-20 10:42 ` Salvatore Bonaccorso
2022-09-20 11:36   ` Karol Herbst
2022-09-20 11:59     ` Salvatore Bonaccorso
2022-09-30 21:09       ` Computer Enthusiastic
2022-11-19  5:20 ` [Nouveau] " Computer Enthusiastic
     [not found] ` <CAHSpYy0HAifr4f+z64h+xFUmMNbB4hCR1r2Z==TsB4WaHatQqg@mail.gmail.com>
     [not found]   ` <CACO55tv0jO2TmuWcwFiAUQB-__DZVwhv7WNN9MfgMXV053gknw@mail.gmail.com>
     [not found]     ` <CAHSpYy117N0A1QJKVNmFNii3iL9mU71_RusiUo5ZAMcJZciM-g@mail.gmail.com>
2023-01-28 14:49       ` Computer Enthusiastic
2023-01-28 17:51         ` Greg KH
2023-01-28 19:49           ` Salvatore Bonaccorso
2023-01-29 21:36             ` Computer Enthusiastic
2023-01-30 10:05               ` Greg KH
2023-01-30 22:27                 ` Lyude Paul [this message]
2023-02-01 19:24                   ` Computer Enthusiastic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e4cb1d818e4ce04c3e465a397e5652349e3938a.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=bskeggs@redhat.com \
    --cc=carnil@debian.org \
    --cc=computer.enthusiastic@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kherbst@redhat.com \
    --cc=nouveau@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).