From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022C0C33C8C for ; Mon, 6 Jan 2020 22:51:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC75A2072C for ; Mon, 6 Jan 2020 22:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="gR+oYRZ4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726721AbgAFWvT (ORCPT ); Mon, 6 Jan 2020 17:51:19 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:43320 "EHLO mail-qv1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726735AbgAFWvR (ORCPT ); Mon, 6 Jan 2020 17:51:17 -0500 Received: by mail-qv1-f65.google.com with SMTP id p2so19739385qvo.10 for ; Mon, 06 Jan 2020 14:51:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pd6XIV7OgADHPUC0a4p/Mb4IhnpWoH1UAexZuXJ1p3s=; b=gR+oYRZ4onpW0u9eAxj2ULlDOyWb/ugEKFPgUuK2O9X4B/ADTb1dAA1I8WaavTN82y TKTIz5wUd/O9vHnYgWUUQewQh5/ZQhyv/kzfmjfxmbqrKoLZ8iwhZ4k1SccdXyF2UtbP lyWZ0Yw6bvfq+QSjMpFD5XKceAOGyIPdBuN0s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pd6XIV7OgADHPUC0a4p/Mb4IhnpWoH1UAexZuXJ1p3s=; b=Nt/Nta+oq8Ow5xAwOpf2Xn/aMaRIMRgVj9jaj7vwJvE31J437i6w+FJ1vyPF/Gjeen wikLnrN7gthJDoIuVvW986qnY2hYNhNEOJjFt28IcyCkqHkk7YUGy7ZrX7AlU56+jlzT 0SfAHv5lJV8IE272XOHPJQhuirH4+x1i6aIQ/oIbDGBGvFaBrvlMGZX4TquTdufRw4xk eyA6mr0QSE2wM6IRB8/kKltK/ZGvjfMqhZ3WT5T/F8LWFXywiK7A/1VJRL9yUNBNvKv6 Fn1zkGdS6BjErEG2qJokky8MDiKIHCi5cK7PO47UGrh7tHCL9DOhr87KaWhu61x0Zz2r b0iw== X-Gm-Message-State: APjAAAWfJPmcs7YcncTc2arrF2Y9YN23BBxvFUzaCJG9vOeiBKFzyS1s sxPU0r9nL/Ao7W/tPbMpNsEKvQsXOcw= X-Google-Smtp-Source: APXvYqylR9wEf6FrTxyx5BCG+6gv32vj+l1qKMh00oXgRnNEoHpL0sBughYLDAYwnE+YYAfU+OE7kg== X-Received: by 2002:ad4:5525:: with SMTP id ba5mr78716283qvb.117.1578351075300; Mon, 06 Jan 2020 14:51:15 -0800 (PST) Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com. [209.85.222.182]) by smtp.gmail.com with ESMTPSA id g9sm21305924qkm.9.2020.01.06.14.51.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Jan 2020 14:51:14 -0800 (PST) Received: by mail-qk1-f182.google.com with SMTP id c17so41017221qkg.7 for ; Mon, 06 Jan 2020 14:51:14 -0800 (PST) X-Received: by 2002:a05:620a:2043:: with SMTP id d3mr85418653qka.279.1578351073659; Mon, 06 Jan 2020 14:51:13 -0800 (PST) MIME-Version: 1.0 References: <20200106224212.189763-1-briannorris@chromium.org> In-Reply-To: <20200106224212.189763-1-briannorris@chromium.org> From: Brian Norris Date: Mon, 6 Jan 2020 14:51:02 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] mwifiex: fix unbalanced locking in mwifiex_process_country_ie() To: linux-wireless Cc: Linux Kernel , Ganapathi Bhat , Nishant Sarmukadam , Amitkumar Karwar , Xinming Hu , stable , huangwen Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Jan 6, 2020 at 2:43 PM Brian Norris wrote: > > We called rcu_read_lock(), so we need to call rcu_read_unlock() before > we return. > > Fixes: 3d94a4a8373b ("mwifiex: fix possible heap overflow in mwifiex_process_country_ie()") > Cc: stable@vger.kernel.org > Cc: huangwen > Cc: Ganapathi Bhat > Signed-off-by: Brian Norris I probably should have mentioned somewhere here: the bug is currently in 5.5-rc and is being ported to -stable already (I'll try to head that off). So this probably should have said [PATCH 5.5]. Sorry about that. Brian