From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F67C433DF for ; Thu, 30 Jul 2020 15:13:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA2DE20838 for ; Thu, 30 Jul 2020 15:13:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="McJOS71U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729632AbgG3PNT (ORCPT ); Thu, 30 Jul 2020 11:13:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbgG3PNS (ORCPT ); Thu, 30 Jul 2020 11:13:18 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50964C061575 for ; Thu, 30 Jul 2020 08:13:18 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id o18so28309865eje.7 for ; Thu, 30 Jul 2020 08:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vfXGH/CEwaBaC/kQBLI8IC/drfAO5muRPoqQ1huaXOI=; b=McJOS71UhOePjQddHfrQt53FnJHJC0kuVMQu/+RnujQmsJPvqSwPBy9z8zCkrYYY2T 9ZdqgPN5eXpDFXra002a1uwK/liS5BLPcUlejRgFdKW3LooogLoj/fjnfsXkdw8i5Vup f9PivRMEUHpTG9rhzJAdaWOlFMSurvCygaBEe0eBbeCKDY8s2kxeS+Rm2sdWUTIACFat UOxs1fCjkyUlRBca/MYzag7GDk3MvtA6RhKZzFYXtxGfQGKGvuSxhn/fzdUD/F341109 Chcye3SKwaQBxN/tHr/LWyEEx7wP9nkvRA1tU6nzUS10GF65XzNFLZKPbZ4E187wWFYU bKFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vfXGH/CEwaBaC/kQBLI8IC/drfAO5muRPoqQ1huaXOI=; b=smhbUTFZrJgyrBZSs1rYUyI5kjToQXTdubh/fdJt4Zs0IcnHa0Mwq9j5CFlUn8QpD0 rOIdbhyiwPEsaOc0wromf7Qwk/6+MggFEhm2RFw51/sedQHFG45Lzo4W0eTWxEcjlAIS TCFm4Ez8bUbigoM0WVcj2ED+ORdO5DPRnJ+pkHnutv76/BPHa7rQGTNgwNZG+UsNIxLc KflwT8obGfyDXXY3BnYchuWWMXXqO0rFz089SdTpparAmAY/fI42p/b6AUcQxqZsxE+j 7TILgtcxo92ynPHnyKf4sjRS+Nyp+hJfFxRYCjrY4+LeZtrgz1vlvoWMnQnuXmenqsfU eW/g== X-Gm-Message-State: AOAM532OTtGg5CzSB+qOIm5uFTd306MLWDbTFD5jGGHhKQYTmQmVe+gN Gq8+qpNTutO17dV4wFN9Gm9ZQlZE42YoLvEqONj17A== X-Google-Smtp-Source: ABdhPJzunWv9jHlXQYg33b+C7Rtiu1eMksfQIE/LP2+0U+iyZFw1c/zddv7AfbByWB/s7vUMZbTHhoeQHHnKibfLQVo= X-Received: by 2002:a17:906:694b:: with SMTP id c11mr2989856ejs.232.1596121996817; Thu, 30 Jul 2020 08:13:16 -0700 (PDT) MIME-Version: 1.0 References: <20200729215152.662225-1-samitolvanen@google.com> <20200730122201.GM25149@gaia> In-Reply-To: <20200730122201.GM25149@gaia> From: Sami Tolvanen Date: Thu, 30 Jul 2020 08:13:05 -0700 Message-ID: Subject: Re: [PATCH] arm64/alternatives: move length validation inside the subsection To: Catalin Marinas Cc: Will Deacon , Ard Biesheuvel , Nick Desaulniers , Kees Cook , linux-arm-kernel , LKML , clang-built-linux , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Jul 30, 2020 at 5:22 AM Catalin Marinas wrote: > > On Wed, Jul 29, 2020 at 02:51:52PM -0700, Sami Tolvanen wrote: > > Commit f7b93d42945c ("arm64/alternatives: use subsections for replacement > > sequences") breaks LLVM's integrated assembler, because due to its > > one-pass design, it cannot compute instruction sequence lengths before the > > layout for the subsection has been finalized. This change fixes the build > > by moving the .org directives inside the subsection, so they are processed > > after the subsection layout is known. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/1078 > > Cc: # 4.14+ > > Commit f7b93d42945c went in 5.8-rc4. Why is this cc stable from 4.14? If > Will picks it up for 5.8, it doesn't even need a cc stable. Greg or Sasha can probably answer why, but this patch is in 4.14.189, 4.19.134, 5.4.53, and 5.7.10, which ended up breaking some downstream Android kernel builds. > Please add a Fixes: tag as well. Sure, I'll send v2 shortly with the tag. Thanks. Sami