From: Linus Walleij <linus.walleij@linaro.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: "Michał Stanek" <mst@semihalf.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
stanekm@google.com, stable <stable@vger.kernel.org>,
"Marcin Wojtas" <mw@semihalf.com>,
levinale@chromium.org,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] pinctrl: cherryview: Add quirk with custom translation of ACPI GPIO numbers
Date: Wed, 25 Mar 2020 23:50:43 +0100 [thread overview]
Message-ID: <CACRpkdYP9a0oJnxodiSm8_Jst=3s=S4n82twp9V=8h=WCX5Gtw@mail.gmail.com> (raw)
In-Reply-To: <20200310144913.GY2540@lahna.fi.intel.com>
On Tue, Mar 10, 2020 at 3:49 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
> > With the newer kernel the gpiochip%d number is different so crossystem
> > ends up reading the wrong pin.
>
> Hmm, so gpiochipX is also not considered a stable number. It is based on
> ARCH_NR_GPIOS which may change. So if the userspace is relaying certain GPIO
> chip is always gpichip200 for example then it is wrong.
Yes it has always been clear that sysfs is what one shall use for establishing
the topology of the hardware, so /sys/bus/gpiochip etc.
For example on my laptop:
$ pwd
/sys/bus/gpio/devices
$ ls -al
total 0
drwxr-xr-x. 2 root root 0 25 mar 23.49 .
drwxr-xr-x. 4 root root 0 25 mar 23.49 ..
lrwxrwxrwx. 1 root root 0 25 mar 23.49 gpiochip0 ->
../../../devices/pci0000:00/INT344B:00/gpiochip0
Here we see that this gpiochip is on this PCI card and so on.
Linus
next prev parent reply other threads:[~2020-03-25 22:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 19:48 [PATCH] pinctrl: cherryview: Add quirk with custom translation of ACPI GPIO numbers Michal Stanek
2020-02-06 8:31 ` Mika Westerberg
2020-02-06 22:26 ` Michał Stanek
2020-02-07 7:56 ` Mika Westerberg
2020-02-08 18:43 ` Michał Stanek
2020-02-10 10:14 ` Mika Westerberg
2020-03-10 14:12 ` Michał Stanek
2020-03-10 14:49 ` Mika Westerberg
2020-03-25 22:50 ` Linus Walleij [this message]
2020-04-17 2:06 ` Brian Norris
2020-04-17 9:05 ` Mika Westerberg
2020-04-18 0:55 ` Brian Norris
2020-08-18 13:59 ` Andy Shevchenko
2020-02-10 12:13 ` Linus Walleij
2020-02-06 9:25 ` Andy Shevchenko
2020-02-06 18:31 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYP9a0oJnxodiSm8_Jst=3s=S4n82twp9V=8h=WCX5Gtw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=dmitry.torokhov@gmail.com \
--cc=levinale@chromium.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=mst@semihalf.com \
--cc=mw@semihalf.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=stanekm@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).