From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4703BC433EF for ; Wed, 16 Mar 2022 23:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350150AbiCPXn1 (ORCPT ); Wed, 16 Mar 2022 19:43:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350541AbiCPXnZ (ORCPT ); Wed, 16 Mar 2022 19:43:25 -0400 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDE821B7BD for ; Wed, 16 Mar 2022 16:42:06 -0700 (PDT) Received: by mail-yb1-xb2c.google.com with SMTP id j2so7388806ybu.0 for ; Wed, 16 Mar 2022 16:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IE2Ea1Cz8v1eLhlB/b4Le+DL8OUHmAt2PXNs7TNdYyo=; b=ER72S7HFC008I9si0CLcY2Yjgn92FTTnxYAWgV/xZsbR8TntqsInYe5JWzjOPXFo8S m1FjJ/EF+HY952bZaCaPh6p/vag21pmK9zMwEM+jBa2CTu6G52PYVMMj+od2uod0M+R/ YhABNZVBsE/YqUzLiwiEGMl7x0R/msYx+IuMQAK2a7JVXcH0cVN/5jt4WdOATvY/YFme /6Cx+6b5tQtNjvt4453yzJ4MNSqqs2iUY/x5gOyWApD4VJWZRBKMmIt+c8T4IqMriJMB R5awjV8maBUntFQxzaA/QoQ3vdaT4wX8TFpaLk2oGE6PZo2KBxFwVArNra11iAajEAvp jylw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IE2Ea1Cz8v1eLhlB/b4Le+DL8OUHmAt2PXNs7TNdYyo=; b=BN8WR8j/ypOkWF7Mp8fIl1I1U3v//Ooq1qhZLU7lyxn5zvA7He49OK5sXGHucVbGyS q1kEoxeYiaAgi9lEvxJiM39y7NC+hb6JN23r7wtzVYEqffNTSqoU3/9iSo1rVJFZ4Tn0 D3BQujP0140jG8tFwlu6jbq8S2CyqeRka1b4qApuz0qPZmN5tmzuMhBurM3qACJKcvL3 WOdeyYkJTW+aQNA8vsTA1u5s1jIDysSC+6T0YC/45CGBrVIdWTYk4QOJm8NDOc0GnNsf LtePfkHWTEwmKCOsIRAxbkRDZMU+wU5xcUgatbkAiv2I312v2k9izzP5ZtrRspN9xoGa 2Eww== X-Gm-Message-State: AOAM530QxOArzn4diSQ8D4ueB39NExLiII6UFcJ/aUSBFkh/MYELRhJd bPihO5PihgbeUuA1c60ckBks5iRgqCZFgKEvk1pnKw== X-Google-Smtp-Source: ABdhPJzqz46JGmqxBDLRnCpVdoH9nYY9SgLKyI8nxa65ZhXp3xjQz+PNbeXq6UT9EcgDZkdJ6rRORP/8KhCR/rDTue8= X-Received: by 2002:a25:2308:0:b0:628:9a66:7327 with SMTP id j8-20020a252308000000b006289a667327mr2490701ybj.626.1647474125953; Wed, 16 Mar 2022 16:42:05 -0700 (PDT) MIME-Version: 1.0 References: <20220316141636.248324-1-sashal@kernel.org> <20220316141636.248324-10-sashal@kernel.org> In-Reply-To: From: Linus Walleij Date: Thu, 17 Mar 2022 00:41:54 +0100 Message-ID: Subject: Re: [PATCH AUTOSEL 5.10 10/12] gpio: Revert regression in sysfs-gpio (gpiolib.c) To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Marcelo Roberto Jimenez , Bartosz Golaszewski , linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Mar 16, 2022 at 5:40 PM Sasha Levin wrote: > On Wed, Mar 16, 2022 at 05:06:47PM +0100, Linus Walleij wrote: > >On Wed, Mar 16, 2022 at 3:17 PM Sasha Levin wrote: > > > >> From: Marcelo Roberto Jimenez > >> > >> [ Upstream commit fc328a7d1fcce263db0b046917a66f3aa6e68719 ] > >> > >> Some GPIO lines have stopped working after the patch > >> commit 2ab73c6d8323f ("gpio: Support GPIO controllers without pin-ranges") > >> > >> And this has supposedly been fixed in the following patches > >> commit 89ad556b7f96a ("gpio: Avoid using pin ranges with !PINCTRL") > >> commit 6dbbf84603961 ("gpiolib: Don't free if pin ranges are not defined") > >> > >> But an erratic behavior where some GPIO lines work while others do not work > >> has been introduced. > >> > >> This patch reverts those changes so that the sysfs-gpio interface works > >> properly again. > >> > >> Signed-off-by: Marcelo Roberto Jimenez > >> Signed-off-by: Bartosz Golaszewski > >> Signed-off-by: Sasha Levin > > > > > >I think you should not apply this for stable, because we will revert the revert. > > Okay, I'll give it a week to soak and if the revert is in by then I can > just pick it too for the sake of completeness. The revert of the revert is already in Linus' tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=56e337f2cf1326323844927a04e9dbce9a244835 Yours, Linus Walleij