From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F19C433E0 for ; Wed, 8 Jul 2020 17:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 586FD206F6 for ; Wed, 8 Jul 2020 17:59:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="P9+4sBCX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725879AbgGHR7g (ORCPT ); Wed, 8 Jul 2020 13:59:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726139AbgGHR7f (ORCPT ); Wed, 8 Jul 2020 13:59:35 -0400 Received: from mail-vk1-xa44.google.com (mail-vk1-xa44.google.com [IPv6:2607:f8b0:4864:20::a44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 799EFC08C5C1 for ; Wed, 8 Jul 2020 10:59:35 -0700 (PDT) Received: by mail-vk1-xa44.google.com with SMTP id n137so10459611vkf.7 for ; Wed, 08 Jul 2020 10:59:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hiompu44sJmWIX0VHQ2p43N5hGspvrVdRKwV2/c7PTg=; b=P9+4sBCXeroD/gl9lFaX0m06xjtx10agKSYwDQ+/NbcOaSqY89NkXRbgqBPgQRcOVj 2sE/15k5UksYrS6NLHG1qzC0R1PFVEXJFB/IoQuFPz8kRo7ozYT8rfPO1xJegBPdj20k dgvGQbI7VTNxqtWycqUuFvVewZCIYxRbrTVJY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hiompu44sJmWIX0VHQ2p43N5hGspvrVdRKwV2/c7PTg=; b=Ixo6yLrxZnCQGC3PGGmiIqgr6BoAjU6Bp9l/b8q8pFrfOvsBbik/lEnMfUW4lANvG6 krf71Z7Z71M4WcljNaWGXQsV33KEsDTUjXph6bHS92b5vYIPEHm9zMAt2J284w6UeJOv Ehs1lOiXi0ZEgy5stE/pEyMd/GzyfW6iLqK7BtIsFajuGYGMkoesjjShbx2VsGBvVE5e KizD/pKsziL/zoN4R5q/mudd4xbbKr2FF+emRyqsnQTP0jOKNVXh9Ym+ug0amr4HkB/z k5UAnlsq+5HOhoziNY/1dy6S6YEzPINw+Plhxs1FSjjdtVCf72wEb0AoF3pPshIR5pcv lPhw== X-Gm-Message-State: AOAM532lUJFeueV8orpW+mJ4cxX1givKiFXOxKpzMRQElBPd6Hl/2fa9 4iy+JkqOtghAMf+EF1pdDQU1Y57e7Ck= X-Google-Smtp-Source: ABdhPJw1edB8OQBYGe+MeKLz3KlK/53TNjYXnh0/NUG8sAMcTRwQNl7wIMiCks3qKkoNsKSBplcoxQ== X-Received: by 2002:a1f:b20a:: with SMTP id b10mr44307756vkf.58.1594231174507; Wed, 08 Jul 2020 10:59:34 -0700 (PDT) Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com. [209.85.221.179]) by smtp.gmail.com with ESMTPSA id t2sm83968vka.28.2020.07.08.10.59.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 10:59:32 -0700 (PDT) Received: by mail-vk1-f179.google.com with SMTP id q85so583656vke.4 for ; Wed, 08 Jul 2020 10:59:32 -0700 (PDT) X-Received: by 2002:a1f:3f05:: with SMTP id m5mr18475983vka.92.1594231171733; Wed, 08 Jul 2020 10:59:31 -0700 (PDT) MIME-Version: 1.0 References: <20200630081938.8131-1-sibis@codeaurora.org> In-Reply-To: <20200630081938.8131-1-sibis@codeaurora.org> From: Doug Anderson Date: Wed, 8 Jul 2020 10:59:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Drop the unused non-MSA SID To: Sibi Sankar Cc: Bjorn Andersson , Andy Gross , linux-arm-msm , LKML , Will Deacon , Sai Prakash Ranjan , Rob Herring , Evan Green , Matthias Kaehlcke , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "# 4.0+" Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi, On Tue, Jun 30, 2020 at 1:20 AM Sibi Sankar wrote: > > Having a non-MSA (Modem Self-Authentication) SID bypassed breaks modem > sandboxing i.e if a transaction were to originate from it, the hardware > memory protections units (XPUs) would fail to flag them (any transaction > originating from modem are historically termed as an MSA transaction). > Drop the unused non-MSA modem SID on SC7180 SoCs and cheza so that SMMU > continues to block them. > > Fixes: bec71ba243e95 ("arm64: dts: qcom: sc7180: Update Q6V5 MSS node") > Fixes: 68aee4af5f620 ("arm64: dts: qcom: sdm845-cheza: Add iommus property") > Cc: stable@vger.kernel.org > Reported-by: Sai Prakash Ranjan > Signed-off-by: Sibi Sankar > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +- > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) I'm not sure if my review is worth all that much since it's not my area of expertise, but as far as I can tell this is good / ready to go in. I've confirmed that a similar on my sc7180 board doesn't seem to break anything for me so restricting things like this seems sane. Reviewed-by: Douglas Anderson Tested-by: Douglas Anderson -Doug