From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63D88C072B5 for ; Fri, 24 May 2019 16:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2E1CB217D7 for ; Fri, 24 May 2019 16:49:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zuagl5Op" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391041AbfEXQtl (ORCPT ); Fri, 24 May 2019 12:49:41 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:33791 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390346AbfEXQtl (ORCPT ); Fri, 24 May 2019 12:49:41 -0400 Received: by mail-wr1-f68.google.com with SMTP id d9so10705101wrx.0 for ; Fri, 24 May 2019 09:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Sad9UpfHJ5sdXzTlwQdywQcHgqAyjq3tv2YnvpOkuAU=; b=Zuagl5Op4aTTiGFH4ijpjh5xhLnvU10ZjZST3gg+CW5fzknUbGDlfMQ0SynMNvGBtd RneXrFfLxqGY3LalCqUN4loZBm2JI3I22IFg20e4Wlj7c0cDQOpubtlacf41I3Ro4pqL ehLeIfHCFqv/ZAWKoSCjikLe0gmqgIztpCgXh85cgn+O7X+Qxq2aAdpfDb9tjs8qHw9h 63Ji+wfZIrG3zq2we4eF+kS5Pv/bHiY+MwcXqBv/jjKmrS/A2cSrJGp6Zt9huePKpA+n GPqgtqMM1iqXKIHwnadqtAl3hTrOwk6al4i8ti6A8NnU7xp9KEQXCafqWO7TcKphLj1o O5IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Sad9UpfHJ5sdXzTlwQdywQcHgqAyjq3tv2YnvpOkuAU=; b=Hx0s6cYq3kV3q8/bZ7q1XVpD5UQ+kJgWJ3iDvpY+8FYgP6Ue5NGp4OSUPAEqPVDH+E pK00ogq+UzCAbrbWvYuBJrspCxUmhxFZhtT1o6tNuySz9yqQgsPRLxFZaUMPpzvpp0/R jm2ZYtNWibIKSKd5EVO+mqvp/BcCgSvn6AeafkMaM32NupHDw5DVmal52Q0cr3sPyxXI dbx2sfqduCeiu7ywbjZwbfTm0XTZlD7VHkVH2wZqEg3HuVa/nupar5iRktNuK0bwN8Et lRyZ1Qx3UXDCyWndnGJ4awh7wRGzrgqMSPiau8G/CF9sb/hghDm/UT4ixSWU55JV+0It uNOA== X-Gm-Message-State: APjAAAXZGPZEiqDBXkIfP51X+vKKPg5Hp3kxJ6UxQ7TBcVqcTylLgtn6 nOLgDmp13f9pSE3mJiDTe0LglDMe6OJjL3+rvvw= X-Google-Smtp-Source: APXvYqwZ1Jupf4nzh4giK/K7tUXKf4/KkODs0l91yOUoyoodzJg/m4oK4AGkqJuUW+t/tPN/1tXUuebiAlP1rX9peu8= X-Received: by 2002:adf:b6a5:: with SMTP id j37mr60560521wre.4.1558716579769; Fri, 24 May 2019 09:49:39 -0700 (PDT) MIME-Version: 1.0 References: <20190524153410.19402-1-alexander.deucher@amd.com> In-Reply-To: From: Alex Deucher Date: Fri, 24 May 2019 12:49:27 -0400 Message-ID: Subject: Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2) To: Mike Lothian Cc: amd-gfx list , Alex Deucher , Harry Wentland , Nicholas Kazlauskas , "for 3.8" Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Fri, May 24, 2019 at 12:32 PM Mike Lothian wrote: > > I realise you don't want to enable this as it's breaking some people's > systems, but could we add a new boot parameter to force it for working > systems? Or check against a black list maybe? We could probably add a whitelist. I'm not sure what the best way to id the working systems are though. Alex > > On Fri, 24 May 2019 at 17:20, Alex Deucher wrote: > > > > On Fri, May 24, 2019 at 12:09 PM Mike Lothian wrote: > > > > > > Hi > > > > > > Curious to know what this means for folk that have newer Raven1 boards > > > that didn't have issues loading the firmware > > > > You won't get ABM I think. ABM is the automatic backlight management. > > > > Alex > > > > > > > > Cheers > > > > > > Mike > > > > > > On Fri, 24 May 2019 at 16:34, Alex Deucher wrote: > > > > > > > > From: Harry Wentland > > > > > > > > [WHY] > > > > Some early Raven boards had a bad SBIOS that doesn't play nicely with > > > > the DMCU FW. We thought the issues were fixed by ignoring errors on DMCU > > > > load but that doesn't seem to be the case. We've still seen reports of > > > > users unable to boot their systems at all. > > > > > > > > [HOW] > > > > Disable DMCU load on Raven 1. Only load it for Raven 2 and Picasso. > > > > > > > > v2: Fix ifdef (Alex) > > > > > > > > Signed-off-by: Harry Wentland > > > > Reviewed-by: Nicholas Kazlauskas > > > > Signed-off-by: Alex Deucher > > > > Cc: stable@vger.kernel.org > > > > --- > > > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++++++++++-- > > > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > > index 995f9df66142..bcb1a93c0b4c 100644 > > > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > > @@ -29,6 +29,7 @@ > > > > #include "dm_services_types.h" > > > > #include "dc.h" > > > > #include "dc/inc/core_types.h" > > > > +#include "dal_asic_id.h" > > > > > > > > #include "vid.h" > > > > #include "amdgpu.h" > > > > @@ -640,7 +641,7 @@ static void amdgpu_dm_fini(struct amdgpu_device *adev) > > > > > > > > static int load_dmcu_fw(struct amdgpu_device *adev) > > > > { > > > > - const char *fw_name_dmcu; > > > > + const char *fw_name_dmcu = NULL; > > > > int r; > > > > const struct dmcu_firmware_header_v1_0 *hdr; > > > > > > > > @@ -663,7 +664,14 @@ static int load_dmcu_fw(struct amdgpu_device *adev) > > > > case CHIP_VEGA20: > > > > return 0; > > > > case CHIP_RAVEN: > > > > - fw_name_dmcu = FIRMWARE_RAVEN_DMCU; > > > > +#if defined(CONFIG_DRM_AMD_DC_DCN1_01) > > > > + if (ASICREV_IS_PICASSO(adev->external_rev_id)) > > > > + fw_name_dmcu = FIRMWARE_RAVEN_DMCU; > > > > + else if (ASICREV_IS_RAVEN2(adev->external_rev_id)) > > > > + fw_name_dmcu = FIRMWARE_RAVEN_DMCU; > > > > + else > > > > +#endif > > > > + return 0; > > > > break; > > > > default: > > > > DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type); > > > > -- > > > > 2.20.1 > > > > > > > > _______________________________________________ > > > > amd-gfx mailing list > > > > amd-gfx@lists.freedesktop.org > > > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx