From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65CF2C433B4 for ; Fri, 16 Apr 2021 08:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37A6E6115B for ; Fri, 16 Apr 2021 08:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240620AbhDPIly (ORCPT ); Fri, 16 Apr 2021 04:41:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240613AbhDPIly (ORCPT ); Fri, 16 Apr 2021 04:41:54 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D495C061756 for ; Fri, 16 Apr 2021 01:41:29 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id s14so8747761pjl.5 for ; Fri, 16 Apr 2021 01:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=He3oTSlwnFPi0gSb22caSHrtR7K6cmAux7Z+2T9Xo1o=; b=hacERswIX9cIS1UJydG+GKquH1hgrwS2+nCAq/Bgnj2hhImJuvM1HgFl4cg3S6pZev JCM/D2hsoeC9Cts3k/lDE+Tk9+6VMkX2XSjBRWjIaS+bPe6By0MTX5I0WkSokhwkTZ2s IbESokhSKgVQrq92WrdxoWpJ2zDl3xWxv0TymTHlFtLoHnW/4sc2o/IGhHEL6OREV5PB 6L4ls7hRTeG8WWZxbf/vK4servXkCqbwQ9exsc6rCarR8bBKnafSkErOolvEAnnBOVyk YimIDDJRfC/4fGCP6QUmjQnHe0SUetMfhL8E10Ju8nu1Lfygrl+Nh+deXzi9RCwd4o03 s9RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=He3oTSlwnFPi0gSb22caSHrtR7K6cmAux7Z+2T9Xo1o=; b=Le7unZHSvHkSzEXahSgqua93o1tGF8na3d3tq9e7P80UfIBuoQ6X1nrKbN8jSKiLGn Ulcd/P6/UVP7L7JjlKwoFJkkv4amfQD2lU1sgLSxzM5XCCsPkT2cTtazrlWiuPgD0NrT MVnBIjlnAhxZkCbO6CcuSP4j9rdCHaoWaquxh3awQyUekTqhbxI5dWhVaHNYhSsR8hFA oqGIeZRZPBgPqGqBFVRZ+tqUdLc2ykstG1QeeNINVzYX3COu6gH5CTgG+bsMCeZwlzN1 9J506bzdLRIaZX9vC9QdOHn2GXRkHVkW0Z4Elhx7bBMEvPsA0xY15cJ03y4tjmD5jXvR 1hAg== X-Gm-Message-State: AOAM532blo5FED2diwBXgLf3soAl0zbR+X3a5rjgihYSgfrokr0rqIJQ yMDQysbwv1KxqZb1nXkdr9QZBZVlyYB5mqGMlwEOgg== X-Google-Smtp-Source: ABdhPJwF2oXeuk5v0ZBd9FHld186Dr4jfV9Bgsh1mreQZM+bGYmRq9h7B9YLZnGn9NgnTr0mVBmGQE0fwbP36eT7Of4= X-Received: by 2002:a17:90b:392:: with SMTP id ga18mr8091538pjb.222.1618562488639; Fri, 16 Apr 2021 01:41:28 -0700 (PDT) MIME-Version: 1.0 References: <20210415183619.1431-1-rdunlap@infradead.org> In-Reply-To: <20210415183619.1431-1-rdunlap@infradead.org> From: Robert Foss Date: Fri, 16 Apr 2021 10:41:17 +0200 Message-ID: Subject: Re: [PATCH -next] drm: bridge: fix ANX7625 use of mipi_dsi_() functions To: Randy Dunlap Cc: linux-kernel , kernel test robot , Xin Ji , Sam Ravnborg , dri-devel , Andrzej Hajda , Neil Armstrong , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Thanks Randy! Reviewed-by: Robert Foss On Thu, 15 Apr 2021 at 20:36, Randy Dunlap wrote: > > The Analogix DRM ANX7625 bridge driver uses mips_dsi_() function > interfaces so it should select DRM_MIPI_DSI to prevent build errors. > > > ERROR: modpost: "mipi_dsi_attach" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! > ERROR: modpost: "mipi_dsi_device_register_full" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! > ERROR: modpost: "of_find_mipi_dsi_host_by_node" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! > ERROR: modpost: "mipi_dsi_device_unregister" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! > ERROR: modpost: "mipi_dsi_detach" [drivers/gpu/drm/bridge/analogix/anx7625.ko] undefined! > > > Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Xin Ji > Cc: Sam Ravnborg > Cc: dri-devel@lists.freedesktop.org > Cc: Andrzej Hajda > Cc: Neil Armstrong > Cc: Robert Foss > Cc: stable@vger.kernel.org > --- > drivers/gpu/drm/bridge/analogix/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > --- linux-next-20210414.orig/drivers/gpu/drm/bridge/analogix/Kconfig > +++ linux-next-20210414/drivers/gpu/drm/bridge/analogix/Kconfig > @@ -30,6 +30,7 @@ config DRM_ANALOGIX_ANX7625 > tristate "Analogix Anx7625 MIPI to DP interface support" > depends on DRM > depends on OF > + select DRM_MIPI_DSI > help > ANX7625 is an ultra-low power 4K mobile HD transmitter > designed for portable devices. It converts MIPI/DPI to