From: Paul Moore <paul@paul-moore.com>
To: Daniel Burgener <dburgener@linux.microsoft.com>
Cc: Greg KH <greg@kroah.com>,
stable@vger.kernel.org,
Stephen Smalley <stephen.smalley.work@gmail.com>,
selinux@vger.kernel.org, James Morris <jmorris@namei.org>,
sashal@kernel.org
Subject: Re: [PATCH v5.4 0/3] Update SELinuxfs out of tree and then swapover
Date: Fri, 16 Oct 2020 09:55:25 -0400 [thread overview]
Message-ID: <CAHC9VhR_WG13wLT-rJs0AdDgh6kwN_ei46btyXp5KusUdzuOag@mail.gmail.com> (raw)
In-Reply-To: <9aeaa66d-d369-a1eb-7a07-08d9244585f3@linux.microsoft.com>
On Fri, Oct 16, 2020 at 9:05 AM Daniel Burgener
<dburgener@linux.microsoft.com> wrote:
> Yes, thank you. I will fix up the series with the third commit
> included, and add commit ids. Thanks.
Greg and I have different opinions on what is classified as a good
candidate for the -stable trees, but in my opinion this patch series
doesn't qualify. There are a lot of dependencies, it is intertwined
with a lot of code, and the issue that this patchset fixes has been
around for a *long* time. I personally feel the risk of backporting
this to -stable does not outweigh the potential wins.
My current opinion is that backporting this patchset is not a good
idea; it gets a NACK from me.
Daniel, in the future if this is something you want to see backported
please bring this issue up on the SELinux mailing list when the
patchset is originally posted so we can have a discussion about it and
plan accordingly.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2020-10-16 13:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 19:29 [PATCH v5.4 0/3] Update SELinuxfs out of tree and then swapover Daniel Burgener
2020-10-15 19:29 ` [PATCH v5.4 1/3] selinux: Create function for selinuxfs directory cleanup Daniel Burgener
2020-10-16 4:59 ` Greg KH
2020-10-15 19:29 ` [PATCH v5.4 2/3] selinux: Refactor selinuxfs directory populating functions Daniel Burgener
2020-10-15 19:29 ` [PATCH v5.4 3/3] selinux: Create new booleans and class dirs out of tree Daniel Burgener
2020-10-16 1:50 ` Sasha Levin
2020-10-16 5:00 ` [PATCH v5.4 0/3] Update SELinuxfs out of tree and then swapover Greg KH
2020-10-16 13:05 ` Daniel Burgener
2020-10-16 13:55 ` Paul Moore [this message]
2020-10-16 14:02 ` Daniel Burgener
2020-10-16 14:22 ` Sasha Levin
2020-10-16 14:36 ` Daniel Burgener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhR_WG13wLT-rJs0AdDgh6kwN_ei46btyXp5KusUdzuOag@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=dburgener@linux.microsoft.com \
--cc=greg@kroah.com \
--cc=jmorris@namei.org \
--cc=sashal@kernel.org \
--cc=selinux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).