From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D466C072B5 for ; Fri, 24 May 2019 16:32:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 365822175B for ; Fri, 24 May 2019 16:32:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=fireburn-co-uk.20150623.gappssmtp.com header.i=@fireburn-co-uk.20150623.gappssmtp.com header.b="JWWY34bf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390210AbfEXQc4 (ORCPT ); Fri, 24 May 2019 12:32:56 -0400 Received: from mail-qk1-f195.google.com ([209.85.222.195]:45397 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390021AbfEXQc4 (ORCPT ); Fri, 24 May 2019 12:32:56 -0400 Received: by mail-qk1-f195.google.com with SMTP id j1so8397713qkk.12 for ; Fri, 24 May 2019 09:32:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fireburn-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7JEiTdPVCIFQdDUK8gYkULbjQdi6LzSI19f3jsOolXA=; b=JWWY34bf57x5nejLM6ABDjAsfbAefju5JNa2pbQTKUh3PwauoxTcPsqtzEUAjC9wBU 5A6TTXmHEb8+8R25UPRarpwSkZRG7EhfRdA2RGp49IjKIDDIc5wowc7USygz2s7aisxP +1LuUwKrgU+W3jkszuFAgCRDh6tAzG7VVXvcq3QamKZjQ+ssJQezf2YY4iU8iFFn2eRM k81NPiECRSr0feJvT0n4OL7N9QAGtpR2hF6pvto0xKYHKDm7r2CVVbeiCQ7o8+x8lT60 RoJONSUGQkP0i9qcTBm+5oZ1lcuAuLkj/vHK91HDK9UxnH1nsZcpJrTVFBn6ZdirPD07 7NsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7JEiTdPVCIFQdDUK8gYkULbjQdi6LzSI19f3jsOolXA=; b=o54kl/jqHIqFtuJwSWS8OjC3qbXvPW2SjEGlufkwY4dTcIKMt2DFbM5cKpTmUcHTTV c52fS3hAPDGVELHWy1pdZ5byLzHlnFH7JPBmjYUsS2PdcLJDZOTCoG6wVu/g8cwFsJzr bBdaDUaESJHtZlGXA/m6spfbwRUStjy/L/EvNUX+v1muu+tT74bNCV9VmKS4rs2OXh3w Vf7rTwxJesn4E20RhickBAxMEroZioIwufMvh/fvOZsYvUsXF9/XldhbJ3XKuosA+xn7 iUFd4eaOY4i9XBvi8h7BnDWvwWh4J8Hw+PBbiTyPb7d+4N1bpJSRDrfyvLBIhLsfllhP xf9g== X-Gm-Message-State: APjAAAVwQvGeFbQBemuu0A9+7c8iO3a2YJISMmfinvKbc6b+ijXJTgs0 i1ROS0t+6vY2fnOuqTAZh0hCio2xTK4O1vNlayST/w== X-Google-Smtp-Source: APXvYqxYdKVV/8Z7jqxrd4PGccsInkiA4fhiupq8gF3tQUXKiZbIhhfTAbiz8YkdFjqcsNHfo+Q2OjRtYmk5x+I2d9g= X-Received: by 2002:ac8:534d:: with SMTP id d13mr47604011qto.217.1558715574951; Fri, 24 May 2019 09:32:54 -0700 (PDT) MIME-Version: 1.0 References: <20190524153410.19402-1-alexander.deucher@amd.com> In-Reply-To: From: Mike Lothian Date: Fri, 24 May 2019 17:32:42 +0100 Message-ID: Subject: Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2) To: Alex Deucher Cc: amd-gfx list , Alex Deucher , Harry Wentland , Nicholas Kazlauskas , "for 3.8" Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org I realise you don't want to enable this as it's breaking some people's systems, but could we add a new boot parameter to force it for working systems? Or check against a black list maybe? On Fri, 24 May 2019 at 17:20, Alex Deucher wrote: > > On Fri, May 24, 2019 at 12:09 PM Mike Lothian wrote: > > > > Hi > > > > Curious to know what this means for folk that have newer Raven1 boards > > that didn't have issues loading the firmware > > You won't get ABM I think. ABM is the automatic backlight management. > > Alex > > > > > Cheers > > > > Mike > > > > On Fri, 24 May 2019 at 16:34, Alex Deucher wrote: > > > > > > From: Harry Wentland > > > > > > [WHY] > > > Some early Raven boards had a bad SBIOS that doesn't play nicely with > > > the DMCU FW. We thought the issues were fixed by ignoring errors on DMCU > > > load but that doesn't seem to be the case. We've still seen reports of > > > users unable to boot their systems at all. > > > > > > [HOW] > > > Disable DMCU load on Raven 1. Only load it for Raven 2 and Picasso. > > > > > > v2: Fix ifdef (Alex) > > > > > > Signed-off-by: Harry Wentland > > > Reviewed-by: Nicholas Kazlauskas > > > Signed-off-by: Alex Deucher > > > Cc: stable@vger.kernel.org > > > --- > > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 ++++++++++-- > > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > index 995f9df66142..bcb1a93c0b4c 100644 > > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > > @@ -29,6 +29,7 @@ > > > #include "dm_services_types.h" > > > #include "dc.h" > > > #include "dc/inc/core_types.h" > > > +#include "dal_asic_id.h" > > > > > > #include "vid.h" > > > #include "amdgpu.h" > > > @@ -640,7 +641,7 @@ static void amdgpu_dm_fini(struct amdgpu_device *adev) > > > > > > static int load_dmcu_fw(struct amdgpu_device *adev) > > > { > > > - const char *fw_name_dmcu; > > > + const char *fw_name_dmcu = NULL; > > > int r; > > > const struct dmcu_firmware_header_v1_0 *hdr; > > > > > > @@ -663,7 +664,14 @@ static int load_dmcu_fw(struct amdgpu_device *adev) > > > case CHIP_VEGA20: > > > return 0; > > > case CHIP_RAVEN: > > > - fw_name_dmcu = FIRMWARE_RAVEN_DMCU; > > > +#if defined(CONFIG_DRM_AMD_DC_DCN1_01) > > > + if (ASICREV_IS_PICASSO(adev->external_rev_id)) > > > + fw_name_dmcu = FIRMWARE_RAVEN_DMCU; > > > + else if (ASICREV_IS_RAVEN2(adev->external_rev_id)) > > > + fw_name_dmcu = FIRMWARE_RAVEN_DMCU; > > > + else > > > +#endif > > > + return 0; > > > break; > > > default: > > > DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type); > > > -- > > > 2.20.1 > > > > > > _______________________________________________ > > > amd-gfx mailing list > > > amd-gfx@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx