From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85BC4C61DA4 for ; Thu, 23 Feb 2023 18:04:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbjBWSEI (ORCPT ); Thu, 23 Feb 2023 13:04:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbjBWSEH (ORCPT ); Thu, 23 Feb 2023 13:04:07 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B7254ECC5 for ; Thu, 23 Feb 2023 10:04:04 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id da10so46507752edb.3 for ; Thu, 23 Feb 2023 10:04:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OfV3cj6WkoUxagcNB6bb7SMIfI10z38gFMomhuJjaq0=; b=eVfpkGFam+YRabRFrkEwHVvKKN3r7syztUN7KFC1ScERvdMXEAzeTGxNKhcNGFhDZq JslFqsDg99eaT6JRVWgcR+4bAhW2/a3EtaxQLZQFk9Sp/xbACshQ2iVMqEimUWFpmWhc 2NyNHpRc/aWtBMy+9asms12Z3xb8G7k8jciu0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OfV3cj6WkoUxagcNB6bb7SMIfI10z38gFMomhuJjaq0=; b=bvPFxAkxD5xSMrfkTICm4scf5jmtNicINy7MDtloxY4TZZrE2XpZEwnhgSM7jXVhkx UTddVyZB1QN8eUXtuZuScGX19LqarwImbvtnIRRfU+RwgZN1TgPPhxBhbF5b1rsX9yI2 D8u+3VvqzuG/NZKNn1Tss5BOtYn/KaEo7ZLTaluHFmCmdKU7xAFWHCgoPkPoJB+YLS2c LGHS5rhMys1lGYLR1p7DK3rQO9aUFNO22aMdh8nS5GgkviUddh+VaCkXU1GTosVoWte5 Fx5K+dmd7tu+WoXq74DE/OP82oYteflBkG/Z6Y1TyIfy7tcPGK+BSpqd3fcmrIZU177N +RIA== X-Gm-Message-State: AO0yUKX8n1d7KMnmgKC/8xrkZlzPdPQ9nOGOoYh+CA4yybfFQLGZo6VY /3Rxq2Rpv6A9ppB8rlOe8X8nSGqwbxW5jE8qMlELOg== X-Google-Smtp-Source: AK7set8UeJyH2unACzave0bPU+rFwRAhbILFsvrs50PLgCoGvN8cJU3gU//mj8M/lRzSKp+wzizQ4Q== X-Received: by 2002:a17:907:a40d:b0:878:7349:5ce6 with SMTP id sg13-20020a170907a40d00b0087873495ce6mr26850776ejc.71.1677175442630; Thu, 23 Feb 2023 10:04:02 -0800 (PST) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com. [209.85.208.45]) by smtp.gmail.com with ESMTPSA id fq30-20020a1709069d9e00b008ce5b426d77sm6072054ejc.13.2023.02.23.10.04.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Feb 2023 10:04:02 -0800 (PST) Received: by mail-ed1-f45.google.com with SMTP id da10so46507557edb.3 for ; Thu, 23 Feb 2023 10:04:02 -0800 (PST) X-Received: by 2002:a05:6402:5484:b0:4ad:739c:b38e with SMTP id fg4-20020a056402548400b004ad739cb38emr7772982edb.1.1677175441752; Thu, 23 Feb 2023 10:04:01 -0800 (PST) MIME-Version: 1.0 References: <20230223141542.672463796@linuxfoundation.org> In-Reply-To: From: Linus Torvalds Date: Thu, 23 Feb 2023 10:03:43 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 5.15 00/37] 5.15.96-rc2 review To: Guenter Roeck Cc: Greg Kroah-Hartman , stable@vger.kernel.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com, f.fainelli@gmail.com, sudipm.mukherjee@gmail.com, srw@sladewatkins.net, rwarsow@gmx.de Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Feb 23, 2023 at 9:31 AM Guenter Roeck wrote: > > This isn't the first time this happens. I seem to recall that you mentioned > some time ago that whatever you use to apply patches (quilt ?) doesn't > handle executable permission bits correctly. Note that even though git itself does handle these things right, we've also always said that if some old fogey wants to use tar-balls and patches, that's supposed to still work. I guess the same "old fogey" comment then covers quilt too. End result: we should try to generally not execute our scripts directly, but to explicitly state which interpreter it should use, rather than then depend on the #! in the script itself to do it. In fact, for shell scripting in particular, we go further than that, and use $(CONFIG_SHELL) Of course, in this case, it's actually using the Makefile '$(shell ..)' format, so I guess it looks a bit odd to write it as $(shell $(CONFIG_SHELL) script..) but I do think we should do it. Now, independently of that I also think quilt should probably just learn the git world order about file modes, because let's face it, git _has_ taken over the world. Mwhahahhahahaahaaa! Linus