From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60D70C432C0 for ; Fri, 29 Nov 2019 05:47:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 32EDD20833 for ; Fri, 29 Nov 2019 05:47:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jBqgi2OX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726709AbfK2Fqb (ORCPT ); Fri, 29 Nov 2019 00:46:31 -0500 Received: from mail-il1-f196.google.com ([209.85.166.196]:34184 "EHLO mail-il1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726164AbfK2Fqb (ORCPT ); Fri, 29 Nov 2019 00:46:31 -0500 Received: by mail-il1-f196.google.com with SMTP id p6so26010831ilp.1; Thu, 28 Nov 2019 21:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UeukSdDwiiSgiJFebwv7o38ymarkZLCclxi9kT/TLJY=; b=jBqgi2OXhM53PJuTTmroI75k72bCJvOHMHV08+HLesmvLcf18N2XkDVZzREOvbqnhj WREf6z8VvKHVJjKsia7IhwSv9I1iVh28cArodmOgq9Mye7SOXK7omsqhvnIVlKPSWzaK Anf/SClsiR7/m9uIPQ8i2abUzGeoguiF9FQTWmbbHQsjX06bkoG0cOVGgowF5bt8TFvc Rt0LYK0rKIcehlGh6W/rtE7gwvdmQnTEI9mqvmOPmGe/wIXNPbJKt92n05tnq2rSjZTE BOeEuFbuV7canqF58bE/pVaQFDCve77ktRTtR9+ue2FE2zGxI9h0K/v3sOhtgdln8El8 zssQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UeukSdDwiiSgiJFebwv7o38ymarkZLCclxi9kT/TLJY=; b=MEqxLje1MTLdWyDyGANbaXhI2BCwu2XP76BQ+e87L3BGjjmAYoZ5nvB/biLcGfZY0X DZqCwLhVUe5V/pKEvHiGZlVBCZhAZECjIRZf418eD1qfDB+QcUA6ReX551+AKEhKSxzE fWaVVsqdBN9IIpoKgOEvG1f/Lsz+P1G9sKV3fAjWnkKvDF48BvtXE62C4TrJkyNm/PW9 SRiB18u0ekjbBs+3jbNLpxUHGsWWItuAGotqZlUe48N+9uph9vVpwkliVOnAUFquLn/U UV/eZLa6KrwHq16p+gLu4DZ1s2YOe8+KAZKhNkU6I3CvYPPiA3LQZdle3ZEotAWux6Fz JSNg== X-Gm-Message-State: APjAAAVGA9zDFM4hpj4b31wWorTs5HDD8TCWpcXsW765sy2CI+uKckM/ iXHmq7L7SDgtqDwVj9zP5ZJi2aX6lB1kRnHGw+w= X-Google-Smtp-Source: APXvYqx9/KH+KOpP7pYSBhLZwgrvZVqIKBHf0wQdTXvrM6coKa20viLyZHeeJfy0W9pcVdtF96C02BM82HTYDbiKKV4= X-Received: by 2002:a92:d450:: with SMTP id r16mr8533331ilm.147.1575006390301; Thu, 28 Nov 2019 21:46:30 -0800 (PST) MIME-Version: 1.0 References: <20191127203114.766709977@linuxfoundation.org> <20191128073623.GE3317872@kroah.com> In-Reply-To: <20191128073623.GE3317872@kroah.com> From: Lukas Bulwahn Date: Fri, 29 Nov 2019 06:46:23 +0100 Message-ID: Subject: Re: [PATCH 4.19 000/306] 4.19.87-stable review To: Greg Kroah-Hartman Cc: Naresh Kamboju , open list , Linus Torvalds , Andrew Morton , Guenter Roeck , Shuah Khan , patches@kernelci.org, Ben Hutchings , lkft-triage@lists.linaro.org, linux- stable , Netdev , Al Viro , linux-fsdevel@vger.kernel.org, Eric Dumazet , =?UTF-8?Q?Jouni_H=C3=B6gander?= , "David S. Miller" Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Nov 28, 2019 at 8:37 AM Greg Kroah-Hartman wrote: > > On Thu, Nov 28, 2019 at 12:23:41PM +0530, Naresh Kamboju wrote: > > On Thu, 28 Nov 2019 at 02:25, Greg Kroah-Hartman > > wrote: > > > > > > This is the start of the stable review cycle for the 4.19.87 release. > > > There are 306 patches in this series, all will be posted as a response > > > to this one. If anyone has any issues with these being applied, please > > > let me know. > > > > > > Responses should be made by Fri, 29 Nov 2019 20:18:09 +0000. > > > Anything received after that time might be too late. > > > > > > The whole patch series can be found in one patch at: > > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.87-rc1.gz > > > or in the git tree and branch at: > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > > > and the diffstat can be found below. > > > > > > thanks, > > > > > > greg k-h > > > > Kernel BUG noticed on x86_64 device while booting 4.19.87-rc1 kernel. > > > > The problematic patch is, > > > > > Jouni Hogander > > > net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject > > > > And this kernel panic is been fixed by below patch, > > > > commit 48a322b6f9965b2f1e4ce81af972f0e287b07ed0 > > Author: Eric Dumazet > > Date: Wed Nov 20 19:19:07 2019 -0800 > > > > net-sysfs: fix netdev_queue_add_kobject() breakage > > > > kobject_put() should only be called in error path. > > > > Fixes: b8eb718348b8 ("net-sysfs: Fix reference count leak in > > rx|netdev_queue_add_kobject") > > Signed-off-by: Eric Dumazet > > Cc: Jouni Hogander > > Signed-off-by: David S. Miller > > Now queued up, I'll push out -rc2 versions with this fix. > > greg k-h We have also been informed about another regression these two commits are causing: https://lore.kernel.org/lkml/ace19af4-7cae-babd-bac5-cd3505dcd874@I-love.SAKURA.ne.jp/ I suggest to drop these two patches from this queue, and give us a week to shake out the regressions of the change, and once ready, we can include the complete set of fixes to stable (probably in a week or two). Lukas