From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6146C56201 for ; Thu, 19 Nov 2020 08:37:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64C8A246AD for ; Thu, 19 Nov 2020 08:37:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="i7+TxqaM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbgKSIhJ (ORCPT ); Thu, 19 Nov 2020 03:37:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726463AbgKSIhI (ORCPT ); Thu, 19 Nov 2020 03:37:08 -0500 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53979C0613D4 for ; Thu, 19 Nov 2020 00:37:08 -0800 (PST) Received: by mail-lj1-x241.google.com with SMTP id y16so5372581ljh.0 for ; Thu, 19 Nov 2020 00:37:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=M+a6SBHOIGDEXoUce4L2waaYCg/VrsfsbxsAVjJObJs=; b=i7+TxqaMRgKxz7TG5cv8ZTGsAbtZydVKfDJxoELRlLmYRrbI2Y/oBl9ogL+zhdUjFb 9yy0MmENgbDJmdvePwPaK/lx4FWv3uPc2ZsF6oEAK4+6rZaKhmtHyYG9PBBXKlJvKsU0 XYQxT7qwFfwhUV9VPRdXjY9QCf61OrVaWeZ4eroaL5ZP8yWA1lZCCriVnI2dgGRpt9Tq 0aDudarCu2umDCS1lXfiHO6NXYSVBIHFcDcu4X/81LNxzVNdBefOguxWlwz5ec57rVrQ n9pfAE5w68jI/8GJT3B+BtE9/ye/mV+iZOs2aTO6jJeoAUskQq6lcNLGr+rcsAZuHPy5 QwhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=M+a6SBHOIGDEXoUce4L2waaYCg/VrsfsbxsAVjJObJs=; b=l7N5SexnYD/h26chuaESFp1C2VBnpQtfAO+JolPStLD28HE1FKqrVCJVmgUB+84A2v i0wiMJLv3haQ4DBxFNrD65HVdAZRmSI87jwtGCt8ijjln2HqTVwd4Z4picZLrZ7nTtUy KdtJ4tkcm2PMJCvdVxAS4IC6Eq0Vwro53ffhfL9hGUTYrVu+5HPKqa1gTCWBj1BhWSBt r8NhaW4FkKBoMbFiQ0MXe2sYtijU6N+6OjuOchmGxajVvFiDOavMHQdYduqI8E80VSCe PySJ8Ei/dQnZYXIRTqOMfiy9DVFxMIpAvGwpVIJICfnxM+4f2LDWmkJvzH4sGY7zl8i/ sVdw== X-Gm-Message-State: AOAM533JqAReAJEXZV+JTbnz/COYH7nvB0hWmtQ3RBWcBAHW6HmBZdPM R87iHmi7fJ6NTkzWvCKWPESyaI+xZvpHCGUytPKNhA== X-Google-Smtp-Source: ABdhPJyh3AOhoLZVXBPx2c33/4l51LAm2SjHPARaDKjrDDgbfplrndx8N1XvlKiBRDDzlTxHeRp5AV8lUa9+W76H6mQ= X-Received: by 2002:a2e:b8d4:: with SMTP id s20mr5742322ljp.226.1605775026714; Thu, 19 Nov 2020 00:37:06 -0800 (PST) MIME-Version: 1.0 References: <17fc60a3-cc50-7cff-eb46-904c2f0c416e@canonical.com> <20201118235015.GB6015@geo.homenetwork> <20201119003319.GA6805@geo.homenetwork> In-Reply-To: <20201119003319.GA6805@geo.homenetwork> From: Vincent Guittot Date: Thu, 19 Nov 2020 09:36:55 +0100 Message-ID: Subject: Re: [PATCH v3] sched/fair: fix unthrottle_cfs_rq for leaf_cfs_rq list To: Tao Zhou , "Guilherme G. Piccoli" , "gregkh@linuxfoundation.org" , Sasha Levin , SeongJae Park Cc: Ben Segall , Dietmar Eggemann , Juri Lelli , Tao Zhou , Mel Gorman , Ingo Molnar , Tao Zhou , Phil Auld , Peter Zijlstra , Pavan Kondeti , Steven Rostedt , Jay Vosburgh , Gavin Guo , halves@canonical.com, nivedita.singhvi@canonical.com, linux-kernel , "# v4 . 16+" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, 19 Nov 2020 at 01:36, Tao Zhou wrote: > > On Thu, Nov 19, 2020 at 07:50:15AM +0800, Tao Zhou wrote: > > On Wed, Nov 18, 2020 at 07:56:38PM -0300, Guilherme G. Piccoli wrote: > > > Hi Vincent (and all CCed), I'm sorry to ping about such "old" patch, but > > > we experienced a similar condition to what this patch addresses; it's an > > > older kernel (4.15.x) but when suggesting the users to move to an > > > updated 5.4.x kernel, we noticed that this patch is not there, although > > > similar ones are (like [0] and [1]). > > > > > > So, I'd like to ask if there's any particular reason to not backport > > > this fix to stable kernels, specially the longterm 5.4. The main reason > > > behind the question is that the code is very complex for non-experienced > > > scheduler developers, and I'm afraid in suggesting such backport to 5.4 > > > and introduce complex-to-debug issues. > > > > > > Let me know your thoughts Vincent (and all CCed), thanks in advance. > > > Cheers, > > > > > > > > > Guilherme > > > > > > > > > P.S. For those that deleted this thread from the email client, here's a > > > link: > > > https://lore.kernel.org/lkml/20200513135528.4742-1-vincent.guittot@linaro.org/ > > > > > > > > > [0] > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fe61468b2cb > > > > > > [1] > > > https://lore.kernel.org/lkml/20200506141821.GA9773@lorien.usersys.redhat.com/ > > > <- great thread BTW! > > > > 'sched/fair: Fix unthrottle_cfs_rq() for leaf_cfs_rq list" failed to apply to > > 5.4-stable tree' > > > > You could check above. But I do not have the link about this. Can't search it > > on LKML web: https://lore.kernel.org/lkml/ > > > > BTW: 'ouwen210@hotmail.com' and 'zohooouoto@zoho.com.cn' all is myself. > > > > Sorry for the confusing.. > > > > Thanks. > > Sorry again. I forget something. It is in the stable. > > Here it is: > > https://lore.kernel.org/stable/159041776924279@kroah.com/ I think it has never been applied to stable. As you mentioned, the backport has been sent : https://lore.kernel.org/stable/20200525172709.GB7427@vingu-book/ I received another emailed in September and pointed out to the backport : https://www.spinics.net/lists/stable/msg410445.html >