From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A84EC17443 for ; Sun, 10 Nov 2019 16:26:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F3C9C2085B for ; Sun, 10 Nov 2019 16:26:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cAulYa8Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727005AbfKJQ0c (ORCPT ); Sun, 10 Nov 2019 11:26:32 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:42489 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727010AbfKJQ0c (ORCPT ); Sun, 10 Nov 2019 11:26:32 -0500 Received: by mail-wr1-f68.google.com with SMTP id a15so12029233wrf.9 for ; Sun, 10 Nov 2019 08:26:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EnozZYgq48Ub7OErRTAS6opwPFw2ErTB4hRiw3ntfu8=; b=cAulYa8QWiLTC+LYVwikv9Xp1DhQdoEHRTmBbVMBcK/Q60V2ZXtiiA4Un15UQ0gACg 3k7UZ1IX9aHV8oMhci+9UWIYl+pv1bbNWsL+MNDoC5NOGhSq4CfmiiMMxLQEl624gCDc c7ZGX4OfFLckujkKjO3PTUvTBelBdqcakvQzqSiPf7qtlCyQT/3+KlSqaqlpgsxOGNFK 1jF6JcZT7t7faoB1aMYHsE5DBWB/nB3VB1zXCPc+bT8pH6rEOiSNZSGC30sh3w6Oocdy /Xoin/AIElFI07xPeTkPOkLQz5z/3SPjGyWMkN+KohtSlJdRj/aeB9/+QMh8kLFlRJ1k Fsgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EnozZYgq48Ub7OErRTAS6opwPFw2ErTB4hRiw3ntfu8=; b=CiZqjkoJrGCMFqpLJOkBdYkne/pk9FZ9FtefXqEYq1iJ+hWcRMaXZ6kU6+MRV3IyBm wRsbKFsJ3wzGAMNCmxjgBcyISl/YZgAL2KZlt2mj4Fj9doyUtGirnq+UmXRfWLnVnoDa piRyLldBqUyko6+f5gQVNDRJSQTGAluM7udnYNAlaslnmoAcFcYwuYl0/WznV4rJv+Lz pC8f4yPpHHWxAv7MQmQszKUHfbkyRUqTskZl3SnfWCNTryNsmYvFdW6P94KnqNFSTB7B k+Q95IaSDqvszmC6hLcv4DWOTSVy1ieVR0K90WsqO4Ib4k8zooAE/CYcOFZnKWl/EpUn RXVQ== X-Gm-Message-State: APjAAAVD0adKOh9/dxOK+AUD2kdFaz0bBS5juB06HXBIUi7v3PmQcnu0 RX0hmgpqo/XoX2BqQaecgVopLogXXG3d8JNIuMORPQ== X-Google-Smtp-Source: APXvYqz/qVyZzKKEiMD5Kn0/CYQ5KiLilJu8C+o/QOePighWGP9/mMPGB5cxpk0QCuszSvTL/cE/a/1ffSaZ3SoYRWs= X-Received: by 2002:adf:f743:: with SMTP id z3mr16510655wrp.200.1573403187573; Sun, 10 Nov 2019 08:26:27 -0800 (PST) MIME-Version: 1.0 References: <20191110024013.29782-1-sashal@kernel.org> <20191110024013.29782-133-sashal@kernel.org> <20191110132726.GN4787@sasha-vm> <20191110155655.GO4787@sasha-vm> In-Reply-To: <20191110155655.GO4787@sasha-vm> From: Ard Biesheuvel Date: Sun, 10 Nov 2019 16:26:15 +0000 Message-ID: Subject: Re: [PATCH AUTOSEL 4.19 133/191] efi: honour memory reservations passed via a linux specific config table To: Sasha Levin , Marc Zyngier Cc: Linux Kernel Mailing List , stable , Jeremy Linton , linux-efi Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org (adding Marc, the GIC maintainer) On Sun, 10 Nov 2019 at 15:57, Sasha Levin wrote: > > On Sun, Nov 10, 2019 at 02:16:57PM +0000, Ard Biesheuvel wrote: > >On Sun, 10 Nov 2019 at 13:27, Sasha Levin wrote: > >> > >> On Sun, Nov 10, 2019 at 08:33:47AM +0100, Ard Biesheuvel wrote: > >> >On Sun, 10 Nov 2019 at 03:44, Sasha Levin wrote: > >> >> > >> >> From: Ard Biesheuvel > >> >> > >> >> [ Upstream commit 71e0940d52e107748b270213a01d3b1546657d74 ] > >> >> > >> >> In order to allow the OS to reserve memory persistently across a > >> >> kexec, introduce a Linux-specific UEFI configuration table that > >> >> points to the head of a linked list in memory, allowing each kernel > >> >> to add list items describing memory regions that the next kernel > >> >> should treat as reserved. > >> >> > >> >> This is useful, e.g., for GICv3 based ARM systems that cannot disable > >> >> DMA access to the LPI tables, forcing them to reuse the same memory > >> >> region again after a kexec reboot. > >> >> > >> >> Tested-by: Jeremy Linton > >> >> Signed-off-by: Ard Biesheuvel > >> >> Signed-off-by: Sasha Levin > >> > > >> >NAK > >> > > >> >This doesn't belong in -stable, and I'd be interested in understanding > >> >how this got autoselected, and how I can prevent this from happening > >> >again in the future. > >> > >> It was selected because it's part of a fix for a real issue reported by > >> users: > >> > > > >For my understanding, are you saying your AI is reading launchpad bug > >reports etc? Because it is marked AUTOSEL. > > Not quite. This review set was me feeding all the patches Ubuntu has on > top of stable trees into AUTOSEL, and sending out the output for review. > I doesn't look into launchpad bug reports on it's own, but in my > experience one can find a bug report for mostly everything AUTOSEL > considers to be a bug. > So the assumption is that taking an arbitrary subset of what Ubuntu backported (and tested extensively), and letting that subset be chosen by a bot is a process that improves the quality of stable trees? I'm rather skeptical of that tbh. > >> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1806766 > >> > > > >That pages mentions > > > >""" > >2 upstream patch series are required to fix this: > > https://