stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Desaulniers <ndesaulniers@google.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sasha Levin <sashal@kernel.org>, stable <stable@vger.kernel.org>,
	Dmitry Golovin <dima@golovin.in>,
	Nathan Chancellor <natechancellor@gmail.com>,
	Sedat Dilek <sedat.dilek@gmail.com>,
	Fangrui Song <maskray@google.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Jian Cai <jiancai@google.com>,
	Manoj Gupta <manojgupta@google.com>,
	Luis Lozano <llozano@google.com>
Subject: Re: 5.4 and 4.19 warning fix for LLVM_IAS
Date: Thu, 10 Dec 2020 13:21:00 -0800	[thread overview]
Message-ID: <CAKwvOdkN85dnAEUCvjULh8-gojwmK-e4-aVhNbO0RdyXsO_H2w@mail.gmail.com> (raw)
In-Reply-To: <X9CuL4Kdl1dw2gws@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

On Wed, Dec 9, 2020 at 2:58 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Dec 08, 2020 at 04:43:34PM -0800, Nick Desaulniers wrote:
> > Dear stable kernel maintainers,
> > (Woah, two in one day; have I exceeded my limit?)
> >
> > Please consider the attached patch for 5.4 and 4.19 for commit
> > b8a9092330da ("Kbuild: do not emit debug info for assembly with
> > LLVM_IAS=1"), which fixes a significant number of warnings under arch/
> > when assembling a kernel with Clang.
>
> I also need a version of this for 5.9.y before we can take this for
> older kernels.  Can you provide that as well?

Yes, apologies.  It's similar to the 5.4.y patch, but with a shorter
set of conflicts as noted in the commit message.  Attached.
-- 
Thanks,
~Nick Desaulniers

[-- Attachment #2: b8a9092330da.5.9.patch --]
[-- Type: application/octet-stream, Size: 1811 bytes --]

From afb10106a6b8ea979463daf0a613352bfdf642f3 Mon Sep 17 00:00:00 2001
From: Nick Desaulniers <ndesaulniers@google.com>
Date: Mon, 9 Nov 2020 10:35:28 -0800
Subject: [PATCH] Kbuild: do not emit debug info for assembly with LLVM_IAS=1

commit b8a9092330da2030496ff357272f342eb970d51b upstream.

Clang's integrated assembler produces the warning for assembly files:

warning: DWARF2 only supports one section per compilation unit

If -Wa,-gdwarf-* is unspecified, then debug info is not emitted for
assembly sources (it is still emitted for C sources).  This will be
re-enabled for newer DWARF versions in a follow up patch.

Enables defconfig+CONFIG_DEBUG_INFO to build cleanly with
LLVM=1 LLVM_IAS=1 for x86_64 and arm64.

Cc: <stable@vger.kernel.org>
Link: https://github.com/ClangBuiltLinux/linux/issues/716
Reported-by: Dmitry Golovin <dima@golovin.in>
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Suggested-by: Dmitry Golovin <dima@golovin.in>
Suggested-by: Nathan Chancellor <natechancellor@gmail.com>
Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
Reviewed-by: Fangrui Song <maskray@google.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
[nd: backport to avoid conflicts from:
  commit 695afd3d7d58 ("kbuild: Simplify DEBUG_INFO Kconfig handling")]
---
 Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Makefile b/Makefile
index b98b54758b20..8f8a39624320 100644
--- a/Makefile
+++ b/Makefile
@@ -821,8 +821,11 @@ DEBUG_CFLAGS	+= -gsplit-dwarf
 else
 DEBUG_CFLAGS	+= -g
 endif
+ifneq ($(LLVM_IAS),1)
 KBUILD_AFLAGS	+= -Wa,-gdwarf-2
 endif
+endif
+
 ifdef CONFIG_DEBUG_INFO_DWARF4
 DEBUG_CFLAGS	+= -gdwarf-4
 endif
-- 
2.29.2.576.ga3fc446d84-goog


  reply	other threads:[~2020-12-10 21:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09  0:43 5.4 and 4.19 warning fix for LLVM_IAS Nick Desaulniers
2020-12-09 10:59 ` Greg KH
2020-12-10 21:21   ` Nick Desaulniers [this message]
2020-12-11 14:25     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKwvOdkN85dnAEUCvjULh8-gojwmK-e4-aVhNbO0RdyXsO_H2w@mail.gmail.com \
    --to=ndesaulniers@google.com \
    --cc=dima@golovin.in \
    --cc=gregkh@linuxfoundation.org \
    --cc=jiancai@google.com \
    --cc=llozano@google.com \
    --cc=manojgupta@google.com \
    --cc=masahiroy@kernel.org \
    --cc=maskray@google.com \
    --cc=natechancellor@gmail.com \
    --cc=sashal@kernel.org \
    --cc=sedat.dilek@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).