From: Nick Desaulniers <ndesaulniers@google.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Sasha Levin <sashal@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>,
clang-built-linux <llvm@lists.linux.dev>,
Alexey Alexandrov <aalexand@google.com>,
Bill Wendling <morbo@google.com>,
Greg Thelen <gthelen@google.com>
Subject: Re: backports of 32ef9e5054ec ("Makefile.debug: re-enable debug info for .S files")
Date: Wed, 26 Oct 2022 10:50:45 -0700 [thread overview]
Message-ID: <CAKwvOdkR6Xb4LeJM6K4g-Vdyg9=osfjwphvJzmGxkQa33zqcVQ@mail.gmail.com> (raw)
In-Reply-To: <Y1gUoS73T4nycQwr@dev-arch.thelio-3990X>
On Tue, Oct 25, 2022 at 9:53 AM Nathan Chancellor <nathan@kernel.org> wrote:
>
> On Mon, Oct 24, 2022 at 02:06:52PM -0700, Nick Desaulniers wrote:
> > Dear stable kernel maintainers,
> > Our production kernel team and ChromeOS kernel teams are reporting
> > that they are unable to symbolize addresses of symbols defined in
> > assembly sources due to a regression I caused with
> > commit a66049e2cf0e ("Kbuild: make DWARF version a choice")
>
> I think you mean commit b8a9092330da ("Kbuild: do not emit debug info
> for assembly with LLVM_IAS=1"), which is what you blamed in
> 32ef9e5054ec? a66049e2cf0e does not appear to have any affect on this
> problem?
Ah right, grabbed the wrong sha from the commit messages.
Not an issue in the patches, just the initial email I sent. Should
still be good for stable maintainers to pick up.
>
> > I fixed this upstream with
> > commit 32ef9e5054ec ("Makefile.debug: re-enable debug info for .S files")
> > but I think this is infeasible to backport through to 4.19.y.
> >
> > Do the attached branch-specific variants look acceptable?
>
> I think the stable specific versions should be okay. We should be able
> to deal with any fallout that happens if there is any.
>
> Acked-by: Nathan Chancellor <nathan@kernel.org>
Thanks for triple checking!
--
Thanks,
~Nick Desaulniers
next prev parent reply other threads:[~2022-10-26 17:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 21:06 backports of 32ef9e5054ec ("Makefile.debug: re-enable debug info for .S files") Nick Desaulniers
2022-10-25 16:53 ` Nathan Chancellor
2022-10-26 17:50 ` Nick Desaulniers [this message]
2022-10-27 10:33 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKwvOdkR6Xb4LeJM6K4g-Vdyg9=osfjwphvJzmGxkQa33zqcVQ@mail.gmail.com' \
--to=ndesaulniers@google.com \
--cc=aalexand@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gthelen@google.com \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).