From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B822C433F5 for ; Tue, 14 Sep 2021 19:10:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60AE960E52 for ; Tue, 14 Sep 2021 19:10:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232202AbhINTMC (ORCPT ); Tue, 14 Sep 2021 15:12:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229869AbhINTMB (ORCPT ); Tue, 14 Sep 2021 15:12:01 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECE73C061574 for ; Tue, 14 Sep 2021 12:10:43 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id bq5so575799lfb.9 for ; Tue, 14 Sep 2021 12:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YnOOs7cOY2aRKSHGTS9b6X5LZVhhuvMpnEJwtROL6Vg=; b=CmSn/OlpRAybXvo2UeErWrXzNG9m2iILp0YBMxECF85BY3IxHhiu4pzslIp+7b+0Be Bm0WWmlfJ3SG175Dw9XqJEm940Iu18WhmTkuSpTzzvLmiWoNnEFhA14ZFY2bg/B76lYT uCYW9+o/eDGt9dIpbA5ZdRCGMeDcfh3cYHSC2dUOO3JKIDP+7ZyFOx1lqsAnpjg64F0p Zprz17+VF3OyS6UZXd9xZrfXpJrPNC5BmvjrDLDdvtrJJDiwLv7nBtXHCRQuwgbOe2f7 sC6Yw5XE0Fubwb4lWCCn00wg5b/97LengfgAP7dwKvftDU1W4FliR/y9/sb2q+ucM2En RWGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YnOOs7cOY2aRKSHGTS9b6X5LZVhhuvMpnEJwtROL6Vg=; b=FgW/OUm5k1Q0GYlvMfeqK0s0CCNyk4YuBxfGuZIs9G4y1oKneK+AoWHKvSwUDuF3/g CFE2z8hsNjrwQMjG6Ssn21oVLWpp12YtbJJZ5aIzDThUv48iaAVYAYVdQ9PDc3XlgwJX vLrSiRzq9S03oTMtsJ9nuj3fYB0mXatrJkl/Q+AqsH4mpGuVpfKqUfyy38i1atyU3dLh X+u9PZt3Aqts8LKRfuVYzcMshO3nfg9t83XE85G0ytBVvG0gG5eTR4MMduE+zwErVb/y J4q3IqpIsIcJtpNm5X99gguhl8NWSYKMshzNmamGTDuSu1zxGCphFRaoy0pKmNIRdyNj mCvQ== X-Gm-Message-State: AOAM532tWhV8IleeP+LLmTcdK5nbGE4QYJ5vEMfov9ZSUn4dgufLhn4u rIzfSWUuGm//PBhRfAuxWA2BRXBYOuJjScSLqY7j6w== X-Google-Smtp-Source: ABdhPJw/+zEgpPOLgQMTdXmaDecwRkVFlAfV9dDhd+GqZB/UdQZhqL81/BhGLj2Cq9GXf8kWBJm7Pqb3KORMxQSljvw= X-Received: by 2002:a05:6512:3b9e:: with SMTP id g30mr13975294lfv.651.1631646642092; Tue, 14 Sep 2021 12:10:42 -0700 (PDT) MIME-Version: 1.0 References: <20210913203201.1844253-1-ndesaulniers@google.com> <195b2f47-b92e-a00b-a2bc-d91bfdbd9d12@rasmusvillemoes.dk> <202109141031.AEFD06F03F@keescook> In-Reply-To: From: Nick Desaulniers Date: Tue, 14 Sep 2021 12:10:30 -0700 Message-ID: Subject: Re: [PATCH 5.10] overflow.h: use new generic division helpers to avoid / operator To: Linus Torvalds Cc: Kees Cook , Josef Bacik , Jens Axboe , Rasmus Villemoes , Greg Kroah-Hartman , Sasha Levin , llvm@lists.linux.dev, stable , Arnd Bergmann , Naresh Kamboju , Nathan Chancellor , Stephen Rothwell , Pavel Machek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Sep 14, 2021 at 11:56 AM Linus Torvalds wrote: > > On Tue, Sep 14, 2021 at 11:48 AM Linus Torvalds > wrote: > > > > There was never anything "loff_t" about bitmask at any point. > > Not 'bitmask'. It's 'blksize'. Hopefully that was obvious in context. Isn't the parameter `blksize` of `nbd_set_size` declared as `loff_t`? -- Thanks, ~Nick Desaulniers