From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83429C10F0E for ; Mon, 15 Apr 2019 20:19:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B13F2087C for ; Mon, 15 Apr 2019 20:19:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555359555; bh=wvktTMWEEtjKHS6GEsVhpKDC8rfR3zBfhNlN4gzQv6o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=B3DhJW029uw2wr5X1urD6UtsGnongekUAlII2cyDmnERqLeGhRxOyLAlvtrYxRj0K UBpFCsxUSPn3gFV/0AnsR2GQVFg2/yIC9CUCs2Qn7t1JG46Pc3IdUc5QHRfz0VpCRh oCMnEeDTlAZ6Y23XnlFzJfBFV363qyABJFjrGwdQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728523AbfDOUTK (ORCPT ); Mon, 15 Apr 2019 16:19:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:37952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728243AbfDOUTK (ORCPT ); Mon, 15 Apr 2019 16:19:10 -0400 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DCA52087C for ; Mon, 15 Apr 2019 20:19:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1555359549; bh=wvktTMWEEtjKHS6GEsVhpKDC8rfR3zBfhNlN4gzQv6o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=G+M4PDu4En58IAUFetL/yyP1RRPkr9v8vyYZzcfMiKRobRYDHKUsMONecmGTCpgG7 7HkfJGSKtLwyhnGDylyeB43Pqcqd4DPWOd0Iy122R96VXe9hBn2YjyBZ0M8p+Jf7uQ +u82mlfdHk2MXceJ/WCYGc+eIzp2z8BERO2sjYEA= Received: by mail-wr1-f47.google.com with SMTP id t17so23582409wrw.13 for ; Mon, 15 Apr 2019 13:19:09 -0700 (PDT) X-Gm-Message-State: APjAAAWV7soRDp78esPyZjcn6ZYKAXRYyPPD26zAt/lbwPYHMn394neZ 9xuOZlM0uvVFMHuT6mPQwBindrqXFuhwMuhXlyw5CQ== X-Google-Smtp-Source: APXvYqxEoZHQkSkCkSz4q33m1Xs3bk6vOmhORe7/J6/MaDt8wfgbxl9NWJyOrOLiNe0b/GcLyGEIrZF01y31ltt6ft4= X-Received: by 2002:adf:fd46:: with SMTP id h6mr50713558wrs.139.1555359547852; Mon, 15 Apr 2019 13:19:07 -0700 (PDT) MIME-Version: 1.0 References: <20190415183726.036654568@linuxfoundation.org> <20190415183727.581656002@linuxfoundation.org> <20190415200452.GA25908@amd> In-Reply-To: <20190415200452.GA25908@amd> From: Andy Lutomirski Date: Mon, 15 Apr 2019 13:18:56 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4.14 05/69] x86/power: Make restore_processor_context() sane To: Pavel Machek Cc: Greg Kroah-Hartman , LKML , stable , Jarkko Nikula , Andy Lutomirski , "Rafael J. Wysocki" , Thomas Gleixner , Borislav Petkov , Josh Poimboeuf , Peter Zijlstra , "Rafael J. Wysocki" , Zhang Rui , Ingo Molnar , Sasha Levin , Linus Torvalds Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, Apr 15, 2019 at 1:04 PM Pavel Machek wrote: > > On Mon 2019-04-15 20:58:23, Greg Kroah-Hartman wrote: > > [ Upstream commit 7ee18d677989e99635027cee04c878950e0752b9 ] > > > > My previous attempt to fix a couple of bugs in __restore_processor_context(): > > > > 5b06bbcfc2c6 ("x86/power: Fix some ordering bugs in __restore_processor_context()") > > > > ... introduced yet another bug, breaking suspend-resume. > > > > Rather than trying to come up with a minimal fix, let's try to clean it up > > for real. This patch fixes quite a few things: > > 5b06bbcfc2c6 fixed theoretical bug; rather than porting it to stable > than fixing it up, it would be better not to port it to stable in the > first place or simply revert it there. Are you sure about that? The bug was reported by real users who had their systems really crash: https://lore.kernel.org/lkml/?q=0fede9f9-88b0-a6e7-1027-dfb2019b8ef2%40linux.intel.com https://lore.kernel.org/lkml/CA+55aFwsMuHUBQz5kDNwRf17JnasXMWjvmLq5qXGH-694yeq1w@mail.gmail.com/ And we had a report that the bug got backported: https://lore.kernel.org/stable/20190407160005.djiw4reapwvbxmgo@debian/ And if we're going to backport some of the fix, we should definitely backport the whole set to avoid having the -stable kernels be in a state that was never in any released kernel. --Andy https://lore.kernel.org/stable/20190407160005.djiw4reapwvbxmgo@debian/