stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greening <bgreening@gmail.com>
To: stable@vger.kernel.org
Cc: regressions@lists.linux.dev, rafael@kernel.org,
	linux-acpi@vger.kernel.org
Subject: [Regression] ACPI: video: Change how we determine if brightness key-presses are handled
Date: Tue, 12 Jul 2022 22:27:52 -0700	[thread overview]
Message-ID: <CALF=6jEe5G8+r1Wo0vvz4GjNQQhdkLT5p8uCHn6ZXhg4nsOWow@mail.gmail.com> (raw)

(resending because of HTML formatting)
Hi, I'm on Arch Linux and upgraded from kernel 5.18.9.arch1-1 to
5.18.10.arch1-1. The brightness keys don't work as well as before.
Gnome had 20 degrees of brightness, now it's 10, and Xfce went from 10
to 5. Additionally, on Gnome the brightness keys are a little slow to
respond and there's a bit of a stutter. Don't know why Xfce doesn't
stutter, but halving the degrees of brightness for both makes me
wonder if each press is being counted twice.

Reverting commit 3a0cf7ab8d in acpi_video.c and rebuilding
5.18.10.arch1-1 fixed it.
The laptop is a Dell Inspiron n4010 and I use "acpi_backlight=video"
to make the brightness keys work. Please let me know if there's any
hardware info you need.

#regzbot introduced: 3a0cf7ab8d

             reply	other threads:[~2022-07-13  5:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13  5:27 Ben Greening [this message]
2022-07-13  5:54 ` [Regression] ACPI: video: Change how we determine if brightness key-presses are handled Thorsten Leemhuis
2022-07-13  9:43 ` Hans de Goede
2022-07-13 13:08   ` Ben Greening
2022-07-13 13:29     ` Hans de Goede
2022-07-13 13:49       ` Hans de Goede
2022-07-13 23:56         ` Ben Greening
2022-07-14 19:38           ` Hans de Goede
2022-07-13 13:58       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALF=6jEe5G8+r1Wo0vvz4GjNQQhdkLT5p8uCHn6ZXhg4nsOWow@mail.gmail.com' \
    --to=bgreening@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).