From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66164C433F5 for ; Wed, 10 Nov 2021 22:24:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43D976115B for ; Wed, 10 Nov 2021 22:24:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233570AbhKJW1E (ORCPT ); Wed, 10 Nov 2021 17:27:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:58838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233552AbhKJW1D (ORCPT ); Wed, 10 Nov 2021 17:27:03 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C93AD61213; Wed, 10 Nov 2021 22:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636583055; bh=0fre3SfK7wolFNYE3+elp2EAeuxzNIUlhw2MJlqR2YI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qJwZtK0YNM4LSAIpSGnz+GMPkKwY05rEjGKMOVkYvw1I/fkCQb5+NVkaJ9TMiUUhB oOneNgf//xVucjOdymwI1SYmNF5DLu0FiKFdkc3HgqGm6Os2e7CA2RTNZZTzxLG9Px 62EgLOqgf22/mKhHkxiCjBY+lYYqIujKHlIRGDJrnKcE17hLo5ofrDiGd+cr1A6smN V/1xBUBbXum6TyYTOcBOrLgJsabIfldqU/cITk6ebhCoZsK2hJRIaNwRk6vDWgNUTq /uimdCnaxoEtcg697CvcPGPO7Kwd1ZUmCznmOOwhCVWhh81uR5QUZC+Os2tFbbML+3 EUnOyoe1pRgjA== Received: by mail-oo1-f50.google.com with SMTP id z11-20020a4a870b000000b002b883011c77so1250558ooh.5; Wed, 10 Nov 2021 14:24:15 -0800 (PST) X-Gm-Message-State: AOAM530z5Ls4Qs+6uSrQcNUgdH4d8RAb7p8WRMjSKlifcWxSlMt6BDsF dVXj68w79s/MivTqWVGllL9xhITJmgedmvp8p5s= X-Google-Smtp-Source: ABdhPJwTbANCR4LyGDnbFZlq9QNtUtJ2ht9HKEiYvAszj6gDBkZxO/hSaVifqPNefuFrcmHrEmsRPVYdZZNQeOj2G0Q= X-Received: by 2002:a4a:a641:: with SMTP id j1mr1471623oom.63.1636583055093; Wed, 10 Nov 2021 14:24:15 -0800 (PST) MIME-Version: 1.0 References: <20211110200253.rfudkt3edbd3nsyj@lahvuun> In-Reply-To: <20211110200253.rfudkt3edbd3nsyj@lahvuun> From: Ard Biesheuvel Date: Wed, 10 Nov 2021 23:24:03 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [REGRESSION]: drivers/firmware: move x86 Generic System Framebuffers support To: Ilya Trukhanov Cc: "# 3.4.x" , regressions@lists.linux.dev, linux-efi , Linux PM , Javier Martinez Canillas , Thomas Zimmermann , "Rafael J. Wysocki" , Len Brown , pavel@ucw.cz Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Ilya, On Wed, 10 Nov 2021 at 21:02, Ilya Trukhanov wrote: > > Suspend-to-RAM with elogind under Wayland stopped working in 5.15. > > This occurs with 5.15, 5.15.1 and latest master at > 89d714ab6043bca7356b5c823f5335f5dce1f930. 5.14 and earlier releases work > fine. > > git bisect gives d391c58271072d0b0fad93c82018d495b2633448. > > To reproduce: > - Use elogind and Linux 5.15.1 with CONFIG_SYSFB_SIMPLEFB=n. > - Start a Wayland session. I tested sway and weston, neither worked. > - In a terminal emulator (I used alacritty) execute `loginctl suspend`. > > Normally after the last step the system would suspend, but it no longer > does so after I upgraded to Linux 5.15. After running `loginctl suspend` > in dmesg I get the following: > [ 103.098782] elogind-daemon[2357]: Suspending system... > [ 103.098794] PM: suspend entry (deep) > [ 103.124621] Filesystems sync: 0.025 seconds > > But nothing happens afterwards. > > Suspend works as expected if I do any of the following: > - Revert d391c58271072d0b0fad93c82018d495b2633448. > - Build with CONFIG_SYSFB_SIMPLEFB=y. If this solves the issue, what else is there to discuss? > - Suspend from tty, even if a Wayland session is running in parallel. > - Suspend from under an X11 session. > - Suspend with `echo mem > /sys/power/state`. > > If I attach strace to the elogind-daemon process after running > `loginctl suspend` then the system immediately suspends. However, if > I attach strace *prior* to running `loginctl suspend` then no suspend, > and the process gets stuck on a write syscall to `/sys/power/state`. > > I "traced" a little bit with printk (sorry, I don't know of a better > way) and the call chain is as follows: > state_store -> pm_suspend -> enter_state -> suspend_prepare > -> pm_prepare_console -> vt_move_to_console -> vt_waitactive > -> __vt_event_wait > > __vt_event_wait just waits until wait_event_interruptible completes, but > it never does (not until I attach to elogind-daemon with strace, at > least). I did not follow the chain further. > > - Linux version 5.15.1 (lahvuun@lahvuun) (gcc (Gentoo 11.2.0 p1) 11.2.0, > GNU ld (Gentoo 2.37_p1 p0) 2.37) #51 SMP PREEMPT Tue Nov 9 23:39:25 > EET 2021 > - Gentoo Linux 2.8 > - x86_64 AuthenticAMD > - dmesg: https://pastebin.com/duj33bY8 > - .config: https://pastebin.com/7Hew1g0T