* [PATCH] tools: gpio: Fix out-of-tree build regression
@ 2020-03-25 10:31 Anssi Hannula
2020-03-25 15:24 ` Bartosz Golaszewski
2020-03-27 21:28 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Anssi Hannula @ 2020-03-25 10:31 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski; +Cc: linux-gpio, stable, Laura Abbott
Commit 0161a94e2d1c7 ("tools: gpio: Correctly add make dependencies for
gpio_utils") added a make rule for gpio-utils-in.o but used $(output)
instead of the correct $(OUTPUT) for the output directory, breaking
out-of-tree build (O=xx) with the following error:
No rule to make target 'out/tools/gpio/gpio-utils-in.o', needed by 'out/tools/gpio/lsgpio-in.o'. Stop.
Fix that.
Fixes: 0161a94e2d1c ("tools: gpio: Correctly add make dependencies for gpio_utils")
Cc: <stable@vger.kernel.org>
Cc: Laura Abbott <labbott@redhat.com>
Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
---
The 0161a94e2d1c was also applied to stable releases, which is where I
got hit by the issue.
tools/gpio/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/gpio/Makefile b/tools/gpio/Makefile
index 842287e42c83..440434027557 100644
--- a/tools/gpio/Makefile
+++ b/tools/gpio/Makefile
@@ -35,7 +35,7 @@ $(OUTPUT)include/linux/gpio.h: ../../include/uapi/linux/gpio.h
prepare: $(OUTPUT)include/linux/gpio.h
-GPIO_UTILS_IN := $(output)gpio-utils-in.o
+GPIO_UTILS_IN := $(OUTPUT)gpio-utils-in.o
$(GPIO_UTILS_IN): prepare FORCE
$(Q)$(MAKE) $(build)=gpio-utils
--
2.21.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: gpio: Fix out-of-tree build regression
2020-03-25 10:31 [PATCH] tools: gpio: Fix out-of-tree build regression Anssi Hannula
@ 2020-03-25 15:24 ` Bartosz Golaszewski
2020-03-27 21:28 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2020-03-25 15:24 UTC (permalink / raw)
To: Anssi Hannula; +Cc: Linus Walleij, linux-gpio, Stable # 4 . 20+, Laura Abbott
śr., 25 mar 2020 o 11:33 Anssi Hannula <anssi.hannula@bitwise.fi> napisał(a):
>
> Commit 0161a94e2d1c7 ("tools: gpio: Correctly add make dependencies for
> gpio_utils") added a make rule for gpio-utils-in.o but used $(output)
> instead of the correct $(OUTPUT) for the output directory, breaking
> out-of-tree build (O=xx) with the following error:
>
> No rule to make target 'out/tools/gpio/gpio-utils-in.o', needed by 'out/tools/gpio/lsgpio-in.o'. Stop.
>
> Fix that.
>
> Fixes: 0161a94e2d1c ("tools: gpio: Correctly add make dependencies for gpio_utils")
> Cc: <stable@vger.kernel.org>
> Cc: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
> ---
>
> The 0161a94e2d1c was also applied to stable releases, which is where I
> got hit by the issue.
>
> tools/gpio/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/gpio/Makefile b/tools/gpio/Makefile
> index 842287e42c83..440434027557 100644
> --- a/tools/gpio/Makefile
> +++ b/tools/gpio/Makefile
> @@ -35,7 +35,7 @@ $(OUTPUT)include/linux/gpio.h: ../../include/uapi/linux/gpio.h
>
> prepare: $(OUTPUT)include/linux/gpio.h
>
> -GPIO_UTILS_IN := $(output)gpio-utils-in.o
> +GPIO_UTILS_IN := $(OUTPUT)gpio-utils-in.o
> $(GPIO_UTILS_IN): prepare FORCE
> $(Q)$(MAKE) $(build)=gpio-utils
>
> --
> 2.21.1
>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools: gpio: Fix out-of-tree build regression
2020-03-25 10:31 [PATCH] tools: gpio: Fix out-of-tree build regression Anssi Hannula
2020-03-25 15:24 ` Bartosz Golaszewski
@ 2020-03-27 21:28 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2020-03-27 21:28 UTC (permalink / raw)
To: Anssi Hannula
Cc: Bartosz Golaszewski, open list:GPIO SUBSYSTEM, stable, Laura Abbott
On Wed, Mar 25, 2020 at 11:33 AM Anssi Hannula <anssi.hannula@bitwise.fi> wrote:
> Commit 0161a94e2d1c7 ("tools: gpio: Correctly add make dependencies for
> gpio_utils") added a make rule for gpio-utils-in.o but used $(output)
> instead of the correct $(OUTPUT) for the output directory, breaking
> out-of-tree build (O=xx) with the following error:
>
> No rule to make target 'out/tools/gpio/gpio-utils-in.o', needed by 'out/tools/gpio/lsgpio-in.o'. Stop.
>
> Fix that.
>
> Fixes: 0161a94e2d1c ("tools: gpio: Correctly add make dependencies for gpio_utils")
> Cc: <stable@vger.kernel.org>
> Cc: Laura Abbott <labbott@redhat.com>
> Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
Patch applied with Bartosz' review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-27 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-25 10:31 [PATCH] tools: gpio: Fix out-of-tree build regression Anssi Hannula
2020-03-25 15:24 ` Bartosz Golaszewski
2020-03-27 21:28 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).