From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D87FC6377B for ; Wed, 21 Jul 2021 19:41:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3181261001 for ; Wed, 21 Jul 2021 19:41:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232276AbhGUTA4 (ORCPT ); Wed, 21 Jul 2021 15:00:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229803AbhGUTAz (ORCPT ); Wed, 21 Jul 2021 15:00:55 -0400 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1FF1C061575 for ; Wed, 21 Jul 2021 12:41:31 -0700 (PDT) Received: by mail-yb1-xb34.google.com with SMTP id r132so4860923yba.5 for ; Wed, 21 Jul 2021 12:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jlekstrand-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aE+5WwECBEzPAUwAaWfDdAD19hgeRUlb1b67ifBCq5o=; b=NHYeqjAvIR5LX96lTaPKxGXirYVHohK75u0STCtpH04+EhGdt5RBfH8jzsRvPlV7D0 /YGsy0IYccphno9DdjcT0mO52fkPh+Z+n4iF6zfYXBJdC7kzLk2R/MufTGGJb59S8Uwv ZrQ5prbfZxJTqWGdbeQ54WrSKbtUc424c3vmHupcPvbs9+jMk91TizR1RESmW4P6h+xz kpWv6wz+xHU8UudN2lEvSA51KK28QvhEpJuKfxocw0M+4o6UD7MGlEmQyVyaSbrs7LWy RdkhpSPnCtXSjIT2wRXULKihbl74OMq4F8FDmUHHiZVyUDuycIjVQUs9Z2mCwC1XdGhS YEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aE+5WwECBEzPAUwAaWfDdAD19hgeRUlb1b67ifBCq5o=; b=Z7SJX/N956IaMMigu6ZlTANuKRZWn6LpBflIohE2iDoXT5ARKb2c/Wu7aRacH3OCq0 ukKfYczFOjqs8vbIzSAZtBcEn2KsEY/tOuT+BtPrq1owyJqkG+oHsZ1BNOEzb1drKmPC h5hWafnHC56AaTVMT5jf+FBxl5XGtWonCFvU5UEZguzF1uIrhB5E23ShtGV5Fisi2QR8 TgV2W9oxC18kY+VGT7C889tMxaDH1VXS4Emp9JkGC60zQxrZp5IBimwMABMS3V15+3Hs jPQzUM/eeUQ6BXBHOheMkUDJoI/gJjx89eE+9sF2E84vjcRBgSY1rCfCzBVfBEsYRrTU TJYQ== X-Gm-Message-State: AOAM532S1dJH32mW9oYxoAHznOkzCnzB0hWHVUXxh1zGVXCOnNlBaar5 z0FzFUsx01UoZsAs5vcHUzgijlhE6l7N093HAtof6A== X-Google-Smtp-Source: ABdhPJwv81VIOC4BcCR36exqFNCJG7bRgBnlMaYWgf2/RhJ0NJYg55BQ0FzNosliXCaFLiih8NKuFq7PxdVM6uvCJ44= X-Received: by 2002:a25:aa69:: with SMTP id s96mr48626057ybi.241.1626896490772; Wed, 21 Jul 2021 12:41:30 -0700 (PDT) MIME-Version: 1.0 References: <20210721062607.512307-1-zhenyuw@linux.intel.com> In-Reply-To: From: Jason Ekstrand Date: Wed, 21 Jul 2021 14:41:19 -0500 Message-ID: Subject: Re: [Intel-gfx] [PATCH] drm/i915/gvt: Fix cached atomics setting for Windows VM To: Daniel Vetter Cc: Zhenyu Wang , "Bloomfield, Jon" , intel-gfx , "Xu, Terrence" , intel-gvt-dev , stable Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Jul 21, 2021 at 4:08 AM Daniel Vetter wrote: > > On Wed, Jul 21, 2021 at 8:21 AM Zhenyu Wang wrote: > > We've seen recent regression with host and windows VM running > > simultaneously that cause gpu hang or even crash. Finally bisect to > > 58586680ffad ("drm/i915: Disable atomics in L3 for gen9"), which seems > > cached atomics behavior difference caused regression issue. > > > > This trys to add new scratch register handler and add those in mmio > > save/restore list for context switch. No gpu hang produced with this one. > > > > Cc: stable@vger.kernel.org # 5.12+ > > Cc: "Xu, Terrence" > > Fixes: 58586680ffad ("drm/i915: Disable atomics in L3 for gen9") > > Signed-off-by: Zhenyu Wang > > Adding Jon Bloomfield, since different settings between linux and > windows for something that can hard-hang the machine on gen9 sounds > ... not good. The difference there is legit and intentional. As far as what we do about it for GVT, if we can safely smash L3 atomics off underneath Windows without causing problems for the VM, we should do that. If not, we need to discuss this internally before proceeding. --Jason > -Daniel > > > --- > > drivers/gpu/drm/i915/gvt/handlers.c | 1 + > > drivers/gpu/drm/i915/gvt/mmio_context.c | 2 ++ > > 2 files changed, 3 insertions(+) > > > > diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c > > index 98eb48c24c46..345b4be5ebad 100644 > > --- a/drivers/gpu/drm/i915/gvt/handlers.c > > +++ b/drivers/gpu/drm/i915/gvt/handlers.c > > @@ -3134,6 +3134,7 @@ static int init_bdw_mmio_info(struct intel_gvt *gvt) > > MMIO_DFH(_MMIO(0xb100), D_BDW, F_CMD_ACCESS, NULL, NULL); > > MMIO_DFH(_MMIO(0xb10c), D_BDW, F_CMD_ACCESS, NULL, NULL); > > MMIO_D(_MMIO(0xb110), D_BDW); > > + MMIO_D(GEN9_SCRATCH_LNCF1, D_BDW_PLUS); > > > > MMIO_F(_MMIO(0x24d0), 48, F_CMD_ACCESS | F_CMD_WRITE_PATCH, 0, 0, > > D_BDW_PLUS, NULL, force_nonpriv_write); > > diff --git a/drivers/gpu/drm/i915/gvt/mmio_context.c b/drivers/gpu/drm/i915/gvt/mmio_context.c > > index b8ac80765461..f776c470914d 100644 > > --- a/drivers/gpu/drm/i915/gvt/mmio_context.c > > +++ b/drivers/gpu/drm/i915/gvt/mmio_context.c > > @@ -105,6 +105,8 @@ static struct engine_mmio gen9_engine_mmio_list[] __cacheline_aligned = { > > {RCS0, COMMON_SLICE_CHICKEN2, 0xffff, true}, /* 0x7014 */ > > {RCS0, GEN9_CS_DEBUG_MODE1, 0xffff, false}, /* 0x20ec */ > > {RCS0, GEN8_L3SQCREG4, 0, false}, /* 0xb118 */ > > + {RCS0, GEN9_SCRATCH1, 0, false}, /* 0xb11c */ > > + {RCS0, GEN9_SCRATCH_LNCF1, 0, false}, /* 0xb008 */ > > {RCS0, GEN7_HALF_SLICE_CHICKEN1, 0xffff, true}, /* 0xe100 */ > > {RCS0, HALF_SLICE_CHICKEN2, 0xffff, true}, /* 0xe180 */ > > {RCS0, HALF_SLICE_CHICKEN3, 0xffff, true}, /* 0xe184 */ > > -- > > 2.32.0.rc2 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx