From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FE09C43603 for ; Wed, 11 Dec 2019 23:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61BE12173E for ; Wed, 11 Dec 2019 23:30:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=intel-com.20150623.gappssmtp.com header.i=@intel-com.20150623.gappssmtp.com header.b="ijN0BBii" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbfLKXax (ORCPT ); Wed, 11 Dec 2019 18:30:53 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:43098 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726890AbfLKXaw (ORCPT ); Wed, 11 Dec 2019 18:30:52 -0500 Received: by mail-oi1-f195.google.com with SMTP id x14so314280oic.10 for ; Wed, 11 Dec 2019 15:30:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=u5EYBeY7DMUFDYGcRwf5OFQhhNuQnK3tgQ7xtLF/bL0=; b=ijN0BBiifrHOQUvBafavzPiAtfcjrHqSWNBtq7gCsmBw3lOMLU5xy2mEy+NAB2WCfZ QXMTvO+d2I6Tcn3VJk+x6SfqhAhnBHDF0hbU1WxTxKaOpnL+xUkp+jVe4Bvz+uoiHxH1 auO0DvWjcmNwkom7gtlF7YZKxpBsil4zLgi+1bFXkDujDluhddarjR4cXvvLKBBq5W/j pB6KrFffB7ThG5i27LLkqbIzqGa04oovBm2zbwEOJR1eB4LFjCOD6hpRwf3+laE8R+eb AclMiFO+ekBDEy9Sarhe4JUZurtOoikzqnoJmc15XLfkfVRRvsumrut/YJ3t4O38ubix mmSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=u5EYBeY7DMUFDYGcRwf5OFQhhNuQnK3tgQ7xtLF/bL0=; b=E1RHnhhJ3XE122um3auo4ffr3cYsrszOun1ZYVORX9UdFHYnoeVi6DJ8uTEfGaPuGd R44zYQrYVrp23Ocnm7AJZcXT3TcoPNyG814fsIzw/3DKTngioX85qu/y4+vV+X+IiZCo Hwz7RB1Xl6jr9FYKoOcy73IkW3VOfv4RAcdb5K47ZypWtmSmBYNdTZfCqy3sBA1mIpFS ghKUq9KdSgHWLlADtih3t3pMI29sRE9oyIM8ZtPM2GAEMYXv8bvL7tfSg2Ww65KFV79C k5IwWV9nBjMehHbEE0xVHfzOWkZOrMSb15BSYqQHI6LPESSIWjCmpN1UKZ8vU2rdDYeI B1ew== X-Gm-Message-State: APjAAAUQr1CYzVLbBuUJ1sjGd6nCPTNhkfVMXeNc/cF6lnD1AWYyJJJ7 bNvOknGN9JdcOajMS1C9+EmuR2uNc+Sy4KKTefOTAw== X-Google-Smtp-Source: APXvYqyLZkYhBOvDF9PkIrrn7AL6acOwV56SY7wGTAM47hWUspRcfbKnDMcStIbXUHhF5Dvhm19L5lJjHK5XdwPeG34= X-Received: by 2002:a05:6808:7da:: with SMTP id f26mr4285646oij.73.1576107051733; Wed, 11 Dec 2019 15:30:51 -0800 (PST) MIME-Version: 1.0 References: <20191211231758.22263-1-jsnitsel@redhat.com> <20191211232612.miaizaxxikhlgvfj@cantor> In-Reply-To: <20191211232612.miaizaxxikhlgvfj@cantor> From: Dan Williams Date: Wed, 11 Dec 2019 15:30:40 -0800 Message-ID: Subject: Re: [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core_init To: Jerry Snitselaar , Linux Kernel Mailing List , Christian Bundy , Dan Williams , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Stefan Berger , stable , linux-integrity@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Wed, Dec 11, 2019 at 3:27 PM Jerry Snitselaar wrote: > > On Wed Dec 11 19, Jerry Snitselaar wrote: > >Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when > >issuing commands to the tpm during initialization, just reserve the > >chip after wait_startup, and release it when we are ready to call > >tpm_chip_register. > > > >Cc: Christian Bundy > >Cc: Dan Williams > >Cc: Peter Huewe > >Cc: Jarkko Sakkinen > >Cc: Jason Gunthorpe > >Cc: Stefan Berger > >Cc: stable@vger.kernel.org > >Cc: linux-intergrity@vger.kernel.org > > Typo on the list address, do you want me to resend Jarkko? > > >Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()") > >Signed-off-by: Jerry Snitselaar > >--- > > I did some initial testing with both a 1.2 device and a 2.0 device here. > Christian, can you verify that this still solves your timeouts problem > you were seeing? Dan, can you try this on the internal system with > the interrupt issues? I will see if I can get the t490s owner to run > it as well. Will do. I assume you'd also want to add 'Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")' if it works?