From: Dan Williams <dan.j.williams@intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christian Bundy <christianbundy@fraction.io>,
Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Stefan Berger <stefanb@linux.vnet.ibm.com>,
stable <stable@vger.kernel.org>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init
Date: Wed, 11 Dec 2019 18:18:17 -0800 [thread overview]
Message-ID: <CAPcyv4jUz9X-eyf7M78dfS-7pzi4Xqs+LdpUSD=eoeQjd1kxug@mail.gmail.com> (raw)
In-Reply-To: <CAPcyv4j_FJ9teSyfodCjXs5Wz2Pj7BjqKX6Mx53OtPnVu0mjGA@mail.gmail.com>
On Wed, Dec 11, 2019 at 6:15 PM Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Wed, Dec 11, 2019 at 3:56 PM Jerry Snitselaar <jsnitsel@redhat.com> wrote:
> >
> > Instead of repeatedly calling tpm_chip_start/tpm_chip_stop when
> > issuing commands to the tpm during initialization, just reserve the
> > chip after wait_startup, and release it when we are ready to call
> > tpm_chip_register.
> >
> > Cc: Christian Bundy <christianbundy@fraction.io>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Peter Huewe <peterhuewe@gmx.de>
> > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Cc: Jason Gunthorpe <jgg@ziepe.ca>
> > Cc: Stefan Berger <stefanb@linux.vnet.ibm.com>
> > Cc: stable@vger.kernel.org
> > Cc: linux-integrity@vger.kernel.org
> > Fixes: a3fbfae82b4c ("tpm: take TPM chip power gating out of tpm_transmit()")
> > Fixes: 5b359c7c4372 ("tpm_tis_core: Turn on the TPM before probing IRQ's")
>
> Ugh, sorry, I guess this jinxed it. This patch does not address the
> IRQ storm on the platform I reported earlier.
Are the reverts making their way upstream?
next prev parent reply other threads:[~2019-12-12 2:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 23:17 [PATCH] tpm_tis: reserve chip for duration of tpm_tis_core_init Jerry Snitselaar
2019-12-11 23:26 ` Jerry Snitselaar
2019-12-11 23:30 ` Dan Williams
2019-12-11 23:49 ` Jerry Snitselaar
2019-12-11 23:54 ` [PATCH v2] " Jerry Snitselaar
2019-12-12 2:15 ` Dan Williams
2019-12-12 2:18 ` Dan Williams [this message]
2019-12-17 1:25 ` Jarkko Sakkinen
2019-12-17 0:58 ` Jarkko Sakkinen
2019-12-17 1:18 ` Dan Williams
2019-12-17 2:00 ` Jerry Snitselaar
2019-12-17 2:14 ` Dan Williams
2019-12-17 12:05 ` Jarkko Sakkinen
2019-12-17 17:18 ` Jerry Snitselaar
2019-12-17 17:26 ` Jerry Snitselaar
2019-12-18 23:09 ` Jarkko Sakkinen
2019-12-18 23:06 ` Jarkko Sakkinen
2019-12-18 23:31 ` Dan Williams
2019-12-19 10:07 ` Jerry Snitselaar
2019-12-27 5:09 ` Jarkko Sakkinen
2019-12-27 5:42 ` Jarkko Sakkinen
2019-12-27 6:03 ` Jarkko Sakkinen
2019-12-17 20:29 ` Jerry Snitselaar
2019-12-18 23:12 ` Jarkko Sakkinen
2019-12-17 1:19 ` Jarkko Sakkinen
2019-12-17 0:43 ` [PATCH] " Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPcyv4jUz9X-eyf7M78dfS-7pzi4Xqs+LdpUSD=eoeQjd1kxug@mail.gmail.com' \
--to=dan.j.williams@intel.com \
--cc=christianbundy@fraction.io \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=jsnitsel@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).