From: "Elliott, Robert (Servers)" <elliott@hpe.com>
To: Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Amit Shah <amit@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi <linux-scsi@vger.kernel.org>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] mpt3sas: Fix kernel panic observed on soft HBA unplug
Date: Sat, 14 Mar 2020 02:25:17 +0000 [thread overview]
Message-ID: <DF4PR8401MB1241779D53613DD3986893F7ABFB0@DF4PR8401MB1241.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAK=zhgp-oFoMkG_X8e5sm13=14TA5WZAHXYSeuZAV2fmUKbPow@mail.gmail.com>
> -----Original Message-----
> From: linux-scsi-owner@vger.kernel.org <linux-scsi-
> owner@vger.kernel.org> On Behalf Of Sreekanth Reddy
> Sent: Wednesday, March 11, 2020 6:50 AM
> To: Amit Shah <amit@kernel.org>
> Subject: Re: [PATCH] mpt3sas: Fix kernel panic observed on soft HBA
> unplug
>
> On Wed, Mar 11, 2020 at 4:55 PM Sreekanth Reddy
> <sreekanth.reddy@broadcom.com> wrote:
> >
> > On Wed, Mar 11, 2020 at 4:35 PM Amit Shah <amit@kernel.org> wrote:
...
> > > > @@ -9992,8 +9992,8 @@ static void scsih_remove(struct pci_dev
> *pdev)
> > >
> > > Just a note: this function is scsih_shutdown(). Doesn't block
> > > application of the patch, though. Just wondering how the patch was
> > > created.
>
> I got your query now, yes this hunk change is in scsih_shutdown()
> function. I am not sure why scsih_remove name is getting displayed
> here in this hunk. I have used 'git format-patch' to generate the
> patch.
>
The scsih_shutdown() function definition is spread over three lines
(although it could easily fit on one line), while scsih_remove() was
the last function whose definition was on one line. git is apparently
not recognizing scsi_shutdown() as a function definition.
next prev parent reply other threads:[~2020-03-14 2:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 10:36 [PATCH] mpt3sas: Fix kernel panic observed on soft HBA unplug Sreekanth Reddy
2020-03-11 11:04 ` Amit Shah
2020-03-11 11:25 ` Sreekanth Reddy
2020-03-11 11:49 ` Sreekanth Reddy
2020-03-11 14:48 ` Amit Shah
2020-03-14 2:25 ` Elliott, Robert (Servers) [this message]
2020-03-14 2:25 ` Elliott, Robert (Servers)
2020-03-16 6:15 ` Sreekanth Reddy
2020-03-27 1:50 ` Martin K. Petersen
2020-03-27 10:35 ` Sreekanth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF4PR8401MB1241779D53613DD3986893F7ABFB0@DF4PR8401MB1241.NAMPRD84.PROD.OUTLOOK.COM \
--to=elliott@hpe.com \
--cc=amit@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).