From: "Wan, Kaike" <kaike.wan@intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: "Dalessandro, Dennis" <dennis.dalessandro@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"Marciniszyn, Mike" <mike.marciniszyn@intel.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH for-rc 1/2] IB/hfi1: Fix memory leaks in sysfs registration and unregistration
Date: Thu, 26 Mar 2020 23:30:55 +0000 [thread overview]
Message-ID: <MW3PR11MB4665CC64F56087B2AA5A726AF4CF0@MW3PR11MB4665.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200326223653.GQ20941@ziepe.ca>
> -----Original Message-----
> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Thursday, March 26, 2020 6:37 PM
> To: Wan, Kaike <kaike.wan@intel.com>
> Cc: Dalessandro, Dennis <dennis.dalessandro@intel.com>;
> dledford@redhat.com; linux-rdma@vger.kernel.org; Marciniszyn, Mike
> <mike.marciniszyn@intel.com>; stable@vger.kernel.org
> Subject: Re: [PATCH for-rc 1/2] IB/hfi1: Fix memory leaks in sysfs registration
> and unregistration
>
> On Thu, Mar 26, 2020 at 10:24:51PM +0000, Wan, Kaike wrote:
>
> > > To see if there is an issue here delete the kobject_del and
> > > kobject_put entirely to leave a dangling sysfs during registration
> > > and see if ib device unregistration explodes.
>
> > I tried a patch wherein the function hfi1_verbs_unregister_sysfs() is
> > never called at all and when unloading the driver the ib device
> > un-registration went through smoothly(no error, the
> > /sys/class/infiniband/hfi1_0 directory gone). Only kmemleak complaints
> > were observed.
>
> Then perhaps there is nothing to worry about and the patches are fine
>
Then I don't have to re-spin the patches?
Kaike
next prev parent reply other threads:[~2020-03-26 23:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200326163619.21129.13002.stgit@awfm-01.aw.intel.com>
2020-03-26 16:38 ` [PATCH for-rc 1/2] IB/hfi1: Fix memory leaks in sysfs registration and unregistration Dennis Dalessandro
2020-03-26 17:25 ` Jason Gunthorpe
2020-03-26 19:09 ` Wan, Kaike
2020-03-26 19:42 ` Jason Gunthorpe
2020-03-26 22:24 ` Wan, Kaike
2020-03-26 22:36 ` Jason Gunthorpe
2020-03-26 23:30 ` Wan, Kaike [this message]
2020-03-26 16:38 ` [PATCH for-rc 2/2] IB/hfi1: Call kobject_put() when kobject_init_and_add() fails Dennis Dalessandro
2020-03-26 16:40 ` Dennis Dalessandro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR11MB4665CC64F56087B2AA5A726AF4CF0@MW3PR11MB4665.namprd11.prod.outlook.com \
--to=kaike.wan@intel.com \
--cc=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).