From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36801C31D63 for ; Mon, 21 Jan 2019 07:13:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA35020880 for ; Mon, 21 Jan 2019 07:13:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="Iyb90hH1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726040AbfAUHN5 (ORCPT ); Mon, 21 Jan 2019 02:13:57 -0500 Received: from mail-eopbgr70058.outbound.protection.outlook.com ([40.107.7.58]:24864 "EHLO EUR04-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726125AbfAUHN4 (ORCPT ); Mon, 21 Jan 2019 02:13:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jOQATpe/gN8xI0AvuyqOkObsmw/ZQ+/OvnrJY57qNGY=; b=Iyb90hH1RSMcS6n+8a4NtndZqeoZbcrnYw10hF865o6Nc3RA9Ua6jtCI9AJKnRvr6jA/m7+UmtsM0GY0zEHsMgxdB5Vk47h8r1QFPwzLtrGUxmGwhksNHt7GvUKPz5OAskBa7Q0IFlUfAFJmpIeSnVvBtI5tonR4GO8f71SQCBo= Received: from VI1PR04MB5327.eurprd04.prod.outlook.com (20.177.52.16) by VI1PR04MB5693.eurprd04.prod.outlook.com (20.178.126.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.24; Mon, 21 Jan 2019 05:29:19 +0000 Received: from VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::482:b606:281d:ebf5]) by VI1PR04MB5327.eurprd04.prod.outlook.com ([fe80::482:b606:281d:ebf5%4]) with mapi id 15.20.1537.031; Mon, 21 Jan 2019 05:29:19 +0000 From: Peter Chen To: "gregkh@linuxfoundation.org" , "dan.carpenter@oracle.com" , "stable@vger.kernel.org" Subject: RE: patch "usb: chipidea: fix static checker warning for NULL pointer" added to usb-linus Thread-Topic: patch "usb: chipidea: fix static checker warning for NULL pointer" added to usb-linus Thread-Index: AQHUrwljyFOvpgmbmkWRngR6nzdfHKW5NP5A Date: Mon, 21 Jan 2019 05:29:19 +0000 Message-ID: References: <15478007419157@kroah.com> In-Reply-To: <15478007419157@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=peter.chen@nxp.com; x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB5693;6:8K39Tn7kEUQqrxJCUV6m3peDCHlFK+qR+zRvVPMquIZi5d2mqKIxglQIFVgu8hDwcw3a5wqFBo9V99ivFwPZemjsF81+bV89wUB+fvcVDHez3hWHGcbVdphXRfe3lafS5v0ZFYZmsGmYy2e05Dg/aJhNwHy+9tPcuqz7lkVHAKTMyCuDJeUCyxjLceZtJmsBWOwNulx2z6zwgmMaYbODDGz5QSNsZSKteldxQNx52WAMQuqY/BDZIAR3tERIXMMSsLJqOgAQ1EMgjn7F0/FhOL/MRdx5+PVcqrn77Oo1KgLHlWk55eQMnwFGS35ej6usph/iRGyOqsx8JNQEIuk0qKBdZxGqSHmPIBlsEG56kRniBodTgQSVPRbisAFWv3O6fHGDHydk3B173fnDSEsU60oLjXbmqOPGOCvRivPakp77iHoA3ICHPmFp4b2lxOwj9YTPNTxPXM4IZ1a15xffAw==;5:jwDO70Dv7zP6WLKUqgct7FafG9HdEN9EKxDmM5a29q/vHwmHMSgX3tjijf3DlHzq+fS73VqsyFI8vTM9FlaH8VZ/PRKcMqhqXGNichRZzb8ldR1OR9tfos745O1sZmctn1t/hSkUSk7USvqs0tMuvGO9OfelciYPnW7SU4khvM4V1JA+XXXYmerPn05fv58yt5XbOEHylaemWC/NXlZBUQ==;7:d3hm3hzqu/6BiJh4OzFUVG39yP9dY8TGtbz0IXOPOdhN2Onpv5FcfxkBUmE5JCxHYpdg59hEvmTLKuh+Qx1Tw0zc21HfigiJtKlqXUiTvtPKp8yFG32JsJ0utinYPA6Id/GjKE3O0h3d2npHY5fXzA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 8eefa857-b225-47f3-97a3-08d67f6164b0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600109)(711020)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5693; x-ms-traffictypediagnostic: VI1PR04MB5693: x-microsoft-antispam-prvs: x-forefront-prvs: 0924C6A0D5 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(396003)(136003)(346002)(39860400002)(376002)(52024003)(189003)(199004)(14454004)(25786009)(478600001)(229853002)(55016002)(74316002)(6436002)(106356001)(105586002)(44832011)(2906002)(68736007)(486006)(7736002)(97736004)(2501003)(305945005)(99286004)(6116002)(316002)(33656002)(71200400001)(86362001)(110136005)(2201001)(71190400001)(81156014)(186003)(8676002)(9686003)(102836004)(81166006)(26005)(53936002)(3846002)(476003)(6506007)(53546011)(6246003)(7696005)(76176011)(11346002)(66066001)(446003)(14444005)(256004)(8936002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5693;H:VI1PR04MB5327.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: gA1tzycxQpolenz0bRu8QNbZwiDVemLKeauQiUYSemt9bQfHu/9aiOaN59XGZfc733AObBU0vmA54Fc7iumKmUscP3tfMkMykacwcc1hMZmddH19zkQUEJTAtPXAhRSzcHBcdlxpJETYgQYMAhtPkpOgO3D1iwHepqxVg55y6mikZCKJOLCAPEhCfjn0XE846yqK+hFyM1iRf6Gd8ky2/1qJyi8ADdbJgYQPw8cxaqdvseZ0hOysTNjN86CsWWQ3s4MIz7bycLKczxH/xOgFZ2UNYzRESUeS/tGTFIiRZPiAeGCQiHri0Q1B1OBHULV2498dXIrU12t9vsJujXxYlNkoZgyXk/3Wj0+xU2oZkTIKx0aQzNvJ6YyzFjYEwcmsbFM4ET25AB1SW7EZ540+EXolN9HWBaczYr8+u/zVeEk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8eefa857-b225-47f3-97a3-08d67f6164b0 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2019 05:29:19.5792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5693 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org =20 > This is a note to let you know that I've just added the patch titled >=20 > usb: chipidea: fix static checker warning for NULL pointer >=20 > to my usb git tree which can be found at > git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > in the usb-linus branch. >=20 > The patch will show up in the next release of the linux-next tree (usuall= y sometime > within the next 24 hours during the week.) >=20 > The patch will hopefully also be merged in Linus's tree for the next -rc = kernel > release. >=20 > If you have any questions about this process, please let me know. >=20 >=20 Hi Greg, This patch does not need to go stable tree, this issue is introduced by v5.= 0-rc1. Thanks. Peter > From 8ff396fe56f5593640a8ce7223cac33a2cda619e Mon Sep 17 00:00:00 2001 > From: Peter Chen > Date: Thu, 17 Jan 2019 09:24:20 +0000 > Subject: usb: chipidea: fix static checker warning for NULL pointer >=20 > During the static checker, "data->usbmisc_data" may be NULL. > Fix it by adding this pointer judgement before using. >=20 > Reported-by: Dan Carpenter > Signed-off-by: Peter Chen > Cc: stable > Signed-off-by: Greg Kroah-Hartman > --- > drivers/usb/chipidea/ci_hdrc_imx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci= _hdrc_imx.c > index e81de9ca8729..9b45aa422e69 100644 > --- a/drivers/usb/chipidea/ci_hdrc_imx.c > +++ b/drivers/usb/chipidea/ci_hdrc_imx.c > @@ -316,7 +316,8 @@ static int ci_hdrc_imx_probe(struct platform_device *= pdev) > if (IS_ERR(data->usbmisc_data)) > return PTR_ERR(data->usbmisc_data); >=20 > - if (of_usb_get_phy_mode(dev->of_node) =3D=3D > USBPHY_INTERFACE_MODE_HSIC) { > + if ((of_usb_get_phy_mode(dev->of_node) =3D=3D > USBPHY_INTERFACE_MODE_HSIC) > + && data->usbmisc_data) { > pdata.flags |=3D CI_HDRC_IMX_IS_HSIC; > data->usbmisc_data->hsic =3D 1; > data->pinctrl =3D devm_pinctrl_get(dev); > -- > 2.20.1 >=20