From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 399D2C5519F for ; Wed, 18 Nov 2020 05:58:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7F2124695 for ; Wed, 18 Nov 2020 05:58:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WhnbSfvo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725497AbgKRF6e (ORCPT ); Wed, 18 Nov 2020 00:58:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:40914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgKRF6e (ORCPT ); Wed, 18 Nov 2020 00:58:34 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1B2D24695; Wed, 18 Nov 2020 05:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1605679112; bh=ZcUyWSCoBjaWm0AcTDZxDi16hdqrDgiVXzupYNuDxI8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WhnbSfvoiUoZr9VYCBzXMK/AA4bju1vuSoQvGamg0fLxQaLoA+CA5Gc1wVe8Blgu0 ZFWzqK7jk4AGStTZjWNYOaHgbzWjnVErCrcVjVaUMGYamG0s4XLbjp7tBqNZu+eGK3 8wW8dGwDPLrEiO50FDwpbOggzg+37XHqDjFIdem8= Date: Wed, 18 Nov 2020 06:58:29 +0100 From: Greg Kroah-Hartman To: Salvatore Bonaccorso Cc: Guenter Roeck , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, shuah@kernel.org, patches@kernelci.org, lkft-triage@lists.linaro.org, pavel@denx.de, stable@vger.kernel.org Subject: Re: [PATCH 4.19 000/264] 4.19.153-rc1 review Message-ID: References: <20201027135430.632029009@linuxfoundation.org> <20201028171035.GD118534@roeck-us.net> <20201028195619.GC124982@roeck-us.net> <20201031094500.GA271135@eldamar.lan> <7608060e-f48b-1a7c-1a92-9c41d81d9a40@roeck-us.net> <20201114083501.GA468764@eldamar.lan> <0a338aae-c3cc-97d4-825e-9082a9659504@roeck-us.net> <20201117193621.GA25637@eldamar.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201117193621.GA25637@eldamar.lan> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Nov 17, 2020 at 08:36:21PM +0100, Salvatore Bonaccorso wrote: > Hi Guenter, > > On Sat, Nov 14, 2020 at 05:27:41AM -0800, Guenter Roeck wrote: > > On 11/14/20 12:35 AM, Salvatore Bonaccorso wrote: > > > Hi Guenter, > > > > > > On Sat, Oct 31, 2020 at 07:31:32AM -0700, Guenter Roeck wrote: > > >> On 10/31/20 2:45 AM, Salvatore Bonaccorso wrote: > > >>> Hi Greg, > > >>> > > >>> On Wed, Oct 28, 2020 at 12:56:19PM -0700, Guenter Roeck wrote: > > >>>> Retry. > > >>>> > > >>>> On Wed, Oct 28, 2020 at 10:10:35AM -0700, Guenter Roeck wrote: > > >>>>> On Tue, Oct 27, 2020 at 02:50:58PM +0100, Greg Kroah-Hartman wrote: > > >>>>>> This is the start of the stable review cycle for the 4.19.153 release. > > >>>>>> There are 264 patches in this series, all will be posted as a response > > >>>>>> to this one. If anyone has any issues with these being applied, please > > >>>>>> let me know. > > >>>>>> > > >>>>>> Responses should be made by Thu, 29 Oct 2020 13:53:47 +0000. > > >>>>>> Anything received after that time might be too late. > > >>>>>> > > >>>>> > > >>>>> Build results: > > >>>>> total: 155 pass: 152 fail: 3 > > >>>>> Failed builds: > > >>>>> i386:tools/perf > > >>>>> powerpc:ppc6xx_defconfig > > >>>>> x86_64:tools/perf > > >>>>> Qemu test results: > > >>>>> total: 417 pass: 417 fail: 0 > > >>>>> > > >>>>> perf failures are as usual. powerpc: > > >>> > > >>> Regarding the perf failures, do you plan to revert b801d568c7d8 ("perf > > >>> cs-etm: Move definition of 'traceid_list' global variable from header > > >>> file") included in 4.19.152 or is a bugfix underway? > > >>> > > >> > > >> The problem is: > > >> > > >> In file included from util/evlist.h:15:0, > > >> from util/evsel.c:30: > > >> util/evsel.c: In function ‘perf_evsel__exit’: > > >> util/util.h:25:28: error: passing argument 1 of ‘free’ discards ‘const’ qualifier from pointer target type > > >> /usr/include/stdlib.h:563:13: note: expected ‘void *’ but argument is of type ‘const char *’ > > >> extern void free (void *__ptr) __THROW; > > >> > > >> This is seen with older versions of gcc (6.5.0 in my case). I have no idea why > > >> newer versions of gcc/glibc accept this (afaics free() still expects a char *, > > >> not a const char *). The underlying problem is that pmu_name should not be > > >> declared const char *, but char *, since it is allocated. The upstream version > > >> of perf no longer uses the same definition of zfree(). It was changed from > > >> #define zfree(ptr) ({ free(*ptr); *ptr = NULL; }) > > >> to > > >> #define zfree(ptr) __zfree((void **)(ptr)) > > >> which does the necessary typecast. The fix would be to either change the definition > > >> of zfree to add the typecast, or to change the definition of pmu_name to drop the const. > > >> Both would only apply to v4.19.y. I don't know if either would be acceptable. > > >> > > >> Either case, reverting b801d568c7d8 won't solve that problem. > > > > > > Are we talking about the same problem though? With v4.19.157 and > > > building with "gcc (Debian 8.3.0-6) 8.3.0", with an unpatched source: > > > > > > $ LC_ALL=C.UTF-8 ARCH=x86 make perf > > > mkdir -p . > > > make --no-print-directory -C perf O= subdir= > > > BUILD: Doing 'make -j2' parallel build > > > Warning: Kernel ABI header at 'tools/include/uapi/drm/i915_drm.h' differs from latest version at 'include/uapi/drm/i915_drm.h' > > > diff -u tools/include/uapi/drm/i915_drm.h include/uapi/drm/i915_drm.h > > > Warning: Kernel ABI header at 'tools/include/uapi/linux/kvm.h' differs from latest version at 'include/uapi/linux/kvm.h' > > > diff -u tools/include/uapi/linux/kvm.h include/uapi/linux/kvm.h > > > Warning: Kernel ABI header at 'tools/include/uapi/linux/perf_event.h' differs from latest version at 'include/uapi/linux/perf_event.h' > > > diff -u tools/include/uapi/linux/perf_event.h include/uapi/linux/perf_event.h > > > Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h' > > > diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h > > > Warning: Kernel ABI header at 'tools/arch/x86/include/uapi/asm/kvm.h' differs from latest version at 'arch/x86/include/uapi/asm/kvm.h' > > > diff -u tools/arch/x86/include/uapi/asm/kvm.h arch/x86/include/uapi/asm/kvm.h > > > Warning: Kernel ABI header at 'tools/arch/x86/lib/memcpy_64.S' differs from latest version at 'arch/x86/lib/memcpy_64.S' > > > diff -u tools/arch/x86/lib/memcpy_64.S arch/x86/lib/memcpy_64.S > > > Warning: Kernel ABI header at 'tools/include/uapi/linux/mman.h' differs from latest version at 'include/uapi/linux/mman.h' > > > diff -u tools/include/uapi/linux/mman.h include/uapi/linux/mman.h > > > > > > Auto-detecting system features: > > > ... dwarf: [ on ] > > > ... dwarf_getlocations: [ on ] > > > ... glibc: [ on ] > > > ... gtk2: [ OFF ] > > > ... libaudit: [ on ] > > > ... libbfd: [ OFF ] > > > ... libelf: [ on ] > > > ... libnuma: [ on ] > > > ... numa_num_possible_cpus: [ on ] > > > ... libperl: [ on ] > > > ... libpython: [ on ] > > > ... libslang: [ on ] > > > ... libcrypto: [ on ] > > > ... libunwind: [ on ] > > > ... libdw-dwarf-unwind: [ on ] > > > ... zlib: [ on ] > > > ... lzma: [ on ] > > > ... get_cpuid: [ on ] > > > ... bpf: [ on ] > > > > > > Makefile.config:456: No sys/sdt.h found, no SDT events are defined, please install systemtap-sdt-devel or systemtap-sdt-dev > > > Makefile.config:623: GTK2 not found, disables GTK2 support. Please install gtk2-devel or libgtk2.0-dev > > > Makefile.config:682: No 'python-config' tool was found: disables Python support - please install python-devel/python-dev > > > Makefile.config:853: No alternatives command found, you need to set JDIR= to point to the root of your Java directory > > > Warning: Kernel ABI header at 'tools/include/uapi/linux/bpf.h' differs from latest version at 'include/uapi/linux/bpf.h' > > > CC util/cs-etm-decoder/cs-etm-decoder.o > > > CC util/intel-pt.o > > > util/cs-etm-decoder/cs-etm-decoder.c: In function 'cs_etm_decoder__buffer_packet': > > > util/cs-etm-decoder/cs-etm-decoder.c:287:24: error: 'traceid_list' undeclared (first use in this function); did you mean 'trace_event'? > > > inode = intlist__find(traceid_list, trace_chan_id); > > > ^~~~~~~~~~~~ > > > trace_event > > > util/cs-etm-decoder/cs-etm-decoder.c:287:24: note: each undeclared identifier is reported only once for each function it appears in > > > make[6]: *** [/build/linux-stable/tools/build/Makefile.build:97: util/cs-etm-decoder/cs-etm-decoder.o] Error 1 > > > make[5]: *** [/build/linux-stable/tools/build/Makefile.build:139: cs-etm-decoder] Error 2 > > > make[5]: *** Waiting for unfinished jobs.... > > > make[4]: *** [/build/linux-stable/tools/build/Makefile.build:139: util] Error 2 > > > make[3]: *** [Makefile.perf:633: libperf-in.o] Error 2 > > > make[2]: *** [Makefile.perf:206: sub-make] Error 2 > > > make[1]: *** [Makefile:70: all] Error 2 > > > make: *** [Makefile:77: perf] Error 2 > > > > > > Reverting b801d568c7d8 would still fix the issue for me. > > > > > > > You are correct, that is a different issue, and b801d568c7d8 will need to be reverted > > to fix it. I just can't figure out how to convince perf to compile this file for me. > > Thanks for confirming/acking. > > So how to move from here, Greg do you need an explicit patch with the > revert or can it be taken from here? An explicit patch is always best, as I can't test this because I have the same build problems that Guenter has for this. thanks, greg k-h