From: Greg KH <gregkh@linuxfoundation.org>
To: Quentin Perret <qperret@google.com>
Cc: stable@vger.kernel.org, sashal@kernel.org,
Rick Yiu <rickyiu@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Valentin Schneider <valentin.schneider@arm.com>
Subject: Re: [PATCH 5.4] sched/fair: Fix overutilized update in enqueue_task_fair()
Date: Mon, 23 Nov 2020 12:30:15 +0100 [thread overview]
Message-ID: <X7udR7EupRVR8IF/@kroah.com> (raw)
In-Reply-To: <20201123101827.451304-1-qperret@google.com>
On Mon, Nov 23, 2020 at 10:18:27AM +0000, Quentin Perret wrote:
> [ Upstream commit 8e1ac4299a6e8726de42310d9c1379f188140c71 ]
>
> enqueue_task_fair() attempts to skip the overutilized update for new
> tasks as their util_avg is not accurate yet. However, the flag we check
> to do so is overwritten earlier on in the function, which makes the
> condition pretty much a nop.
>
> Fix this by saving the flag early on.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2020-11-23 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 10:18 [PATCH 5.4] sched/fair: Fix overutilized update in enqueue_task_fair() Quentin Perret
2020-11-23 11:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7udR7EupRVR8IF/@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rickyiu@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).