From: Greg KH <greg@kroah.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>, stable@vger.kernel.org
Subject: Re: [PATCH for 4.14] speakup: Reject setting the speakup line discipline outside of speakup
Date: Wed, 9 Dec 2020 13:12:55 +0100 [thread overview]
Message-ID: <X9C/R1JKgjicHR5o@kroah.com> (raw)
In-Reply-To: <20201209110722.7jpp7bk7p54hudnd@function>
On Wed, Dec 09, 2020 at 12:07:22PM +0100, Samuel Thibault wrote:
> [backport of 5.10 commit f0992098cadb4c9c6a00703b66cafe604e178fea]
>
> Speakup exposing a line discipline allows userland to try to use it,
> while it is deemed to be useless, and thus uselessly exposes potential
> bugs. One of them is simply that in such a case if the line sends data,
> spk_ttyio_receive_buf2 is called and crashes since spk_ttyio_synth
> is NULL.
>
> This change restricts the use of the speakup line discipline to
> speakup drivers, thus avoiding such kind of issues altogether.
>
> Cc: stable@vger.kernel.org
> Reported-by: Shisong Qin <qinshisong1205@gmail.com>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> Tested-by: Shisong Qin <qinshisong1205@gmail.com>
> Link: https://lore.kernel.org/r/20201129193523.hm3f6n5xrn6fiyyc@function
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Both of these worked, thanks!
greg k-h
next prev parent reply other threads:[~2020-12-09 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 11:07 [PATCH for 4.14] speakup: Reject setting the speakup line discipline outside of speakup Samuel Thibault
2020-12-09 12:12 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-12-09 10:27 Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9C/R1JKgjicHR5o@kroah.com \
--to=greg@kroah.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).